Commit Graph

382 Commits

Author SHA1 Message Date
Michal Kordas 55b266cd92 Fix AtclauseOrder check violations in codebase, issue #978 2015-04-26 02:30:41 +02:00
Michal Kordas 31db0435b7 Resolve Javadoc problems found by Checkstyle, issue #978 2015-04-26 01:42:24 +02:00
Michal Kordas 53eddca5d1 Replace all occurrences of FastStack with ArrayDeque, issue #86 2015-04-25 16:35:30 -07:00
Michal Kordas b29ca6b5f6 Fix and suppress PMD violations from ShortClassName rule, issue #982 2015-04-24 23:09:13 +02:00
Michal Kordas 4ac32a7c0c Fix PMD violations from ShortMethodName rule, issue #982 2015-04-24 21:21:29 +02:00
Michal Kordas f9a9d6c3d3 Fix PMD violations from BooleanGetMethodName rule, issue #982 2015-04-24 21:19:14 +02:00
Michal Kordas 5cd16d56a2 Fix PMD violations - AvoidFieldNameMatchingTypeName rule, issue #982 2015-04-24 21:12:15 +02:00
Roman Ivanov 589c5a261a added validation for header in setHeader in RegexpHeaderCheck.java to provide better feedback when an invalid Pattern is specified (was InvocationTargetException only before). Changes are made base on @krichter722 commit. Issue #897 2015-04-24 09:10:26 -07:00
Damian Szczepanik ab2f93f9bf Delete System.exit() and delegate exit control into separate method.
Issue #596
2015-04-23 22:18:45 -07:00
Roman Ivanov 3d3f3d5f9c PMD rule AbstractClassWithoutAbstractMethod is activated. Issue #744 2015-04-23 19:51:10 -04:00
Roman Ivanov 18ed7958cf PMD rule AvoidSynchronizedAtMethodLevel is activated. Issue #744 2015-04-23 19:34:59 -04:00
Roman Ivanov e30fa27dc4 PMD Rule:AccessorClassGeneration Priority:3 Avoid instantiation through private constructors from outside of the constructors class. Issue #744 2015-04-23 18:52:43 -04:00
Roman Ivanov 8bd1d6869b PMD rule AvoidDeeplyNestedIfStmts is activated. Issue #744 2015-04-23 18:09:00 -04:00
Roman Ivanov 232246fb93 PMD Rule:SwitchStmtsShouldHaveDefault Priority:3 Switch statements should have a default label. Issue #744 2015-04-23 16:48:10 -04:00
Michal Kordas 9399831eea Extend LeftCurly check to verify static initializers, issue #966 2015-04-23 13:11:19 -07:00
Mehmet Can Cömert 335d28b494 issue969: Fix upper/lower case conversation, enhance tests 2015-04-23 12:43:24 -07:00
Michal Kordas 9ea33d0720 Extend EmptyBlock check to verify synchronized blocks, issue #964 2015-04-23 21:24:55 +02:00
Roman Ivanov dd6b080a16 all TODO/FIXME were removed , some of them converted to issues 2015-04-23 13:38:31 -04:00
Roman Ivanov bc9eae330a PMD Rule:OneDeclarationPerLine Priority:4 Use one line for each declaration, it enhances code readability. Issue #744 2015-04-22 17:05:31 -04:00
Roman Ivanov a733182557 PMD Rule:AssignmentInOperand Priority:3 Avoid assignments in operands. Issue #744 2015-04-22 16:37:37 -04:00
Roman Ivanov 9b5594952d Rule:UnnecessaryConstructor Priority:3 Avoid unnecessary constructors - the compiler will generate these for you. Issue #744 2015-04-22 12:38:46 -07:00
Roman Ivanov ece98b65cb Rule:CommentRequired Priority:3 XXXXXXXXXXCommentRequirement Required. Issue #744 2015-04-21 16:48:57 -04:00
Roman Ivanov 3b0a914b39 Rule:CommentRequired Priority:3 headerCommentRequirement Required. Issue #744 2015-04-21 13:42:05 -07:00
Roman Ivanov cbb51d7852 Rule:CommentRequired Priority:3 XXXXXXXXXXCommentRequirement Required. Issue #744 2015-04-21 13:33:45 -07:00
Roman Ivanov c9cf116fcb PMD Rule:ExcessiveMethodLength Priority:3 Avoid really long methods. Issue #744 2015-04-21 10:48:28 -07:00
Roman Ivanov 7f65ac9c09 PMD Rule:ExcessiveMethodLength Priority:3 Avoid really long methods . Issue #744 2015-04-21 09:52:03 -07:00
Michal Kordas 3ab0516997 Fix PMD violations from RedundantFieldInitializer rule, issue #942 2015-04-20 14:30:34 -07:00
Michal Kordas ba4f230c35 Fix generics with arrays handling in NoWhitespaceAfter, issue #931 2015-04-18 23:38:54 -07:00
liscju ffde404dba Introduce new handler SynchronizedHandler for checking identation. Fixes Issue #580 2015-04-16 11:34:11 -07:00
Michal Kordas 8dbfd35435 Fix PMD violations from 'sunsecure' ruleset, issue #874 2015-04-16 07:07:41 -07:00
Michal Kordas 1c42e3eeb9 Fix PMD violations from 'strings' ruleset, issue #873 2015-04-15 17:56:07 +02:00
Roman Ivanov 22a5c6af71 fix for findbugs violation SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS. Issue #912 2015-04-13 17:09:12 -07:00
Roman Ivanov d4578980b0 fix for findbugs violation JavadocNodeImpl to not return null for array type. Issue #912 2015-04-13 16:40:24 -07:00
Roman Ivanov 4ffb4d7f1b fix for findbugs violation RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE. Issue #912 2015-04-13 16:40:19 -07:00
Michal Kordas 63b127c70d Add tests to increase coverage after changes, issue #871 2015-04-13 14:43:00 -07:00
Michal Kordas ee518dfe86 Fix PMD violations from 'logging-jakarta' ruleset, issue #871 2015-04-13 14:43:00 -07:00
Roman Ivanov efc6142fb0 fix for build problems at JavadocNodeImpl 2015-04-13 10:37:52 -07:00
Roman Ivanov 032faf4eb4 fix and suppressions for Findbugs violations UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR. Issue #912 2015-04-12 23:45:56 -07:00
Roman Ivanov 7dd24c8c35 fix for Findbugs violations NM_CONFUSING. Issue #912 2015-04-11 15:41:46 -07:00
Roman Ivanov e1d0e7f636 fix for findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE. Issue #912 2015-04-10 16:20:20 -07:00
Michal Kordas d9415ac10c Fix PMD violation from 'migrating' ruleset, issue #869 2015-04-10 10:21:23 -07:00
Michal Kordas fc0d10e8f4 Fix PMD violations from 'braces' ruleset, issue #876 2015-04-09 16:10:31 -07:00
Roman Ivanov 702a1a9576 fix for Findbugs violation DM_DEFAULT_ENCODING. Issue #778 2015-04-08 22:37:46 -07:00
Roman Ivanov fb68212a18 fix for Findbugs violation DM_DEFAULT_ENCODING. Issue #778 2015-04-08 13:17:25 -07:00
Michal Kordas 95fc97c6d8 Fix PMD violations from 'typeresolution' ruleset, issue #875 2015-04-08 21:11:54 +02:00
Roman Ivanov 362abdf0ca fix for EI_EXPOSE_REP. Issue #778 2015-04-08 09:26:09 -07:00
Roman Ivanov a8f5fa3225 fix for EI_EXPOSE_REP. Issue #778 2015-04-08 08:33:04 -07:00
Roman Ivanov 01b9628d34 fix for RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE. Issue #778 2015-04-07 16:36:05 -07:00
Roman Ivanov 547fb51b1d fix for NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH. Issue #778 2015-04-07 16:15:15 -07:00
Roman Ivanov cce20fc3c7 fix for SF_SWITCH_FALLTHROUGH. Issue #778 2015-04-06 23:16:29 -07:00