TouchInstinct
/
checkstyle
306
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
166 Commits 3 Branches 71 Tags 51 MiB
Commit Graph

166 Commits

Author SHA1 Message Date
Oliver Burn e10faf3315 First cut at doing left curly checking for methods. This is definitely a work 
in progress that will change a lot as I add checking for other constructs. I
always tend to evolve to the general solution. :-)
 2002-02-20 23:08:21 +00:00
Oliver Burn 73f1a6f70f Added format for method braces 2002-02-20 23:05:17 +00:00
Oliver Burn 1fd18cde7b Now support setting the left curly placement option for methods. I am 
implementing this example first, before doing it for types, statics, arrays,
anon inners, etc.
 2002-02-20 02:52:27 +00:00
Oliver Burn 14d5ead27a First cut at an options class for placement of left curly braces 2002-02-19 22:54:47 +00:00
Oliver Burn 048d0cdaf4 Changed the error reporting format for the modifier order check. In using the 
feature, I found that it was very helpful to know which modifier to correct.
 2002-02-19 22:52:49 +00:00
Oliver Burn 22885be800 Fixed checkstyle error 2002-02-19 22:39:35 +00:00
Oliver Burn e61ba618f2 Scaring myself, but writing the documentation first for the brace checking. 2002-02-19 02:50:35 +00:00
Oliver Burn 5e4b582734 Fixed the Javadoc comment. Not sure if the old style will create valid 
output.
 2002-02-18 00:37:04 +00:00
Lars Kühne b7c466d38c replaced Netbeans from the list of IDE's missing Checkstyle integration 
instead added VisualCafe
 2002-02-17 10:52:11 +00:00
Oliver Burn b174220a66 Made Defn public so it can be reference outside the package 2002-02-16 22:13:59 +00:00
Oliver Burn d097038b81 added reference to nbCheckstyle 2002-02-16 22:07:30 +00:00
Oliver Burn 946f15a105 Contribution of a stylesheet from Stephane Bailliez (who wrote it) and 
Scott McCrory (who organised it).
 2002-02-16 21:49:05 +00:00
Lars Kühne faf76530d8 RFE #514033, check order of modifiers (implementation, test, and documentation) 2002-02-15 06:47:51 +00:00
Oliver Burn c9db9f82e2 Just some small refactoring 2002-02-11 05:38:09 +00:00
Lars Kühne 913028d7f2 Implementation, docs and test for RFE 438478, ignore multiple lines in header. 
This change is compatible for command line, Ant, and API.

The API compatibility resulted in some deprecated methods in Configuration,
you can remove them if you think that API compatibility is not as
important as clean code.
 2002-02-10 18:29:10 +00:00
Oliver Burn bdd55605c0 Clarified (hopefully:-) how line counts are made on methods 2002-02-09 13:26:25 +00:00
Oliver Burn db84febeb5 Update the tests and documentation for checking whitespace around periods. 
#493383
 2002-02-09 13:18:30 +00:00
Oliver Burn 241c48750b Added a method to verify that a dot is correctly surrounded by whitespace. 2002-02-09 12:00:32 +00:00
Oliver Burn 7fa84f981c Made Checkstyle more "ant friendly" but having a anttasks.properties file. 
This allows declaritions of the taskdef in ant 1.4+ as:

        <taskdef resource="anttasks.properties">
            <classpath refid="run.classpath"/>
        </taskdef>

Also, in a moment of madness, I re-indented the build.xml file to 4 spaces.
 2002-02-09 11:03:56 +00:00
Oliver Burn a1dda4f264 Reordered the logic for ignoring lines. 2002-02-08 00:42:21 +00:00
Oliver Burn 1ca4d43ce8 <picky>Made mConfig final</picky> 2002-02-08 00:35:39 +00:00
Lars Kühne c7e7af8f7d added test for new feature 'headerfile regular expression support', rfe #499259 
moved creation of Configuration to setUp() to ensure that
each test is run with a well known Configuration that is not
influenced by other tests.
 2002-02-07 20:39:51 +00:00
Lars Kühne 6fc674d4bf new feature 'headerfile regular expression support, rfe #499259' 2002-02-07 20:34:11 +00:00
Oliver Burn fdd9ae8297 Incorporate patch from Andrew Lang to support having javadoc with the format: 
/**
     * @param aTwo
     *     This is a multiline piece of javadoc
     **/

Also changes the wording of "is not proceeded with whitespace" to
"is not followed by whitespace". This makes things a tad clearer.
 2002-02-07 05:25:30 +00:00
Oliver Burn d4f1261a61 Refactored the MethodSignature class to contain all the information. Also added 
helper methods.
 2002-02-06 23:15:05 +00:00
Oliver Burn ea01eaaa85 Just tweaked the style a bit to be consistent with else where. I kept the 
braces on a new line though. ;-)
 2002-02-06 21:55:08 +00:00
Oliver Burn 6df3e84393 Changed a comment to C++ style 2002-02-06 05:49:22 +00:00
Oliver Burn d7bc542ef7 fixed copy & paste error 2002-02-06 05:45:48 +00:00
Oliver Burn 6350e4c223 Updated version to 2.1 - as building for Conor who wants the requirePackageHtml 
option.
 2002-02-06 05:39:38 +00:00
Oliver Burn 9be48298c3 Fixed checkstyle errors 2002-02-06 05:37:26 +00:00
Oliver Burn d5efededc6 Fixed for version 2.1 2002-02-06 05:34:42 +00:00
Oliver Burn 2ceae1b3c4 Small cleanup 2002-02-06 05:33:59 +00:00
Lars Kühne 46667e3599 Added tests for allowProtected (old feature without tests), allowPackage, requirePackageHtml, methodPattern, localVarPattern 2002-02-05 20:40:50 +00:00
Lars Kühne aeacc039ed Added documentation for new parameters 
requirePackageHtml, methodPattern, localVarPattern, allowPackage
 2002-02-05 20:34:21 +00:00
Lars Kühne c617457933 Implementation for RFEs 466756, 500378, 504964, 510441 
Details:

466756 - Check for package.html:
 - new parameter requirePackageHtml, default is false

500378 - Check names of methods + local variables
 - new parameters methodPattern and localVarPattern,
   default is ^[a-z][a-zA-Z0-9]*$

504964 - no default access
510441 - allowprotect should incl. packageprivate (requests the same feature)
 - new parameter allowPackage, default is false

Sorry that I did not split this into separate patches, I had this in
my local tree as is and it would require too much work to split it.  I
think the changes are easy enough to review three feature
implementations in one go.
 2002-02-05 20:22:02 +00:00
Oliver Burn 9acdd1b97e opps - forgot to include lib. 2002-02-05 02:50:19 +00:00
Oliver Burn b779f3c1da Updated to the LGPL and version 2.0. 2002-02-04 12:44:04 +00:00
Oliver Burn a98340a539 Removed trailing whitespace - do not ask why? ;-) 2002-02-04 12:40:53 +00:00
Lars Kühne 2aa584f3ad renamed tests.failed to check.tests.failed to avoid "tests.failed" during build 
when actually the tests have been succesful

adapted have.xalan so that it works with the xalan version
included in jdk 1.4 (no Version class there)
 2002-02-02 13:24:30 +00:00
Oliver Burn b66b7a0662 Added check for Xalan in the classpath. The Xalan.jar file is rather large, 
so decided against putting it into the lib/ directory.
 2002-02-01 04:15:43 +00:00
Oliver Burn 37aa8fad69 Added a check to ensure JUnit is in the classpath before running the tests. 2002-02-01 03:58:00 +00:00
Oliver Burn 12e8532fb9 Made reference to lib/junit.jar 2002-02-01 03:33:42 +00:00
Oliver Burn cb5d9e659e Release 3.7 2002-02-01 03:32:27 +00:00
Oliver Burn 448680ed26 Now uses the JARs in the lib directory. 2002-02-01 03:09:25 +00:00
Oliver Burn 0ba8ef9e87 JARs required to build & run Checkstyle. I remembered the -kb option. ;-) 2002-02-01 03:06:51 +00:00
Oliver Burn 8f5eb02840 Changed so you no longer need to have ANTLR in your classpath when running ANT. 
This cleans up the really ugly hack of using the reverseloader + makes it easier
to make build "out-of-the-box".
 2002-02-01 02:48:29 +00:00
Oliver Burn a5abed5101 Changed direct reference to getProject() 2002-01-28 22:15:08 +00:00
Lars Kühne 8e6328559e fix bug #508010, documentation and code are inconsistent 2002-01-24 18:34:47 +00:00
Oliver Burn 82ed05b01a Fixed HTML errors reported by Tidy. 2002-01-24 04:10:58 +00:00
Oliver Burn 01f4ac16ed Fixed the home page to be sourceforge 2002-01-24 02:44:29 +00:00