Commit Graph

477 Commits

Author SHA1 Message Date
Lars Kühne e20d45697c finally managed to tell beanutils what I want, checks now have their 'natural' api 2002-10-06 13:14:16 +00:00
Lars Kühne 1efd41aa92 cleanup after port of illegal instantiations 2002-10-01 21:07:42 +00:00
Oliver Burn eb7b7bfd3e Major refactoring to support correct column numbers. Also removed all the old
code for whitespace checking around things. This required fixing the grammar
to not consume COLON tokens. Looks like you are onto something Lars with your
previous email (made it easy to find the bug).
2002-10-01 08:47:26 +00:00
Lars Kühne 81dab0c141 included the new patterns suggested by Vijay R. Aravamudhan 2002-10-01 05:14:05 +00:00
Lars Kühne ce175a83d8 ported the illegal instantiations check
still need to remove the old code
2002-09-29 19:43:38 +00:00
Lars Kühne 65d3c9814b removed unused private methods 2002-09-29 14:46:36 +00:00
Lars Kühne 6d191d438b completed port of modifier order check, removed old code 2002-09-29 14:28:10 +00:00
Lars Kühne 553a1aec9f removed redundant modifier checks from old code 2002-09-29 14:16:38 +00:00
Lars Kühne 021d6344b6 ups..., removing local test code 2002-09-29 14:08:13 +00:00
Lars Kühne d7c1da9a93 removed tab check and file length check from old code 2002-09-29 14:04:36 +00:00
Lars Kühne f7b0ed0a76 added test for tab character check 2002-09-29 13:46:35 +00:00
Lars Kühne a7c5f33141 Added test for FileLengthCheck 2002-09-29 12:58:27 +00:00
Lars Kühne 031bc6f277 fixed style problem (package visible member) 2002-09-29 09:37:10 +00:00
Oliver Burn 18d65a1993 Moved across all the import checks 2002-09-29 05:55:02 +00:00
Oliver Burn 856fdd282b Added the ability to selectively run a test 2002-09-29 05:53:30 +00:00
Oliver Burn 84c1f8375f Clean up of import checks - removed old code 2002-09-29 05:19:13 +00:00
Oliver Burn aa5dbacdcb Moved across nearly all the unit tests, just the illegal import to go 2002-09-29 05:01:34 +00:00
Lars Kühne 11fad553fd added TODO comment about incomplete port 2002-09-28 21:05:13 +00:00
Lars Kühne 4b209708c6 ported FileLengthCheck and TabCharacterCheck, tests still missing 2002-09-28 20:55:43 +00:00
Lars Kühne 4f6596703f removed all traces of header checks in old impl and tests 2002-09-28 19:37:02 +00:00
Lars Kühne f24c8ee834 implemented header checks, still need to remove old code 2002-09-28 19:09:34 +00:00
Lars Kühne c2afeecbf7 remove debug output 2002-09-28 17:48:22 +00:00
Lars Kühne d28a2aa39e Call the lifecycle methods (beginTree, ...) of a
Check even if the Check does not visit any tokens.

This is required for Checks that do not operate on
the parse tree, e.g. the Header Checks
2002-09-28 17:46:48 +00:00
Lars Kühne f8ca7fdb34 make class abstract so IDEA's JUnit integration knows that this is not a test to be run 2002-09-28 16:38:36 +00:00
Oliver Burn f32694566e Removed the old implementation of the package name check. 2002-09-27 07:20:00 +00:00
Oliver Burn ba942fa395 fix problem with binaries 2002-09-27 06:54:03 +00:00
Oliver Burn d077a402da Added a lot more checks for name format. Also endeavouring to get Checkstyle
passing Javadoc again before it gets out of control.
2002-09-27 06:41:28 +00:00
Oliver Burn d7142fd15f Implemented the parameter name check. Oh so easy. :-) 2002-09-25 13:43:06 +00:00
Oliver Burn 03c8a0a7ee Refactoring the way the Checker is configured. Not happy with the current
approach - it was hack. Changing to be that the Configuration will eventually
contain the CheckConfiguration objects.

Also adding support setting the properties on created checks. I am adding this
using the Jakarta Commons library as it makes it very easy.

Oh - I am now back online - no thanks to Sprint blocking my ISP for a couple
of days. I may have lost a couple of emails. :-(
2002-09-25 12:24:50 +00:00
Lars Kühne 9fdee8a722 Started converting the header check.
Oliver, this checkin is mainly to keep you informed what I am doing so
that we avoid duplicate work. Please email me once your ISP starts working
again (do you have an alternate email address or a webmail account?)
2002-09-25 05:35:21 +00:00
Lars Kühne 8857b09cb3 added project files for VisualSlickEdit IDE (requested by VRAravamudhan at thoughtworks) 2002-09-25 04:36:15 +00:00
Oliver Burn 563f76592d Moved across the check for upper case ell 2002-09-24 11:46:34 +00:00
Oliver Burn e77f0c5c6e cleaned up some imports 2002-09-24 11:11:17 +00:00
Oliver Burn 49b2c72373 Refactored the tests to only use the Checker interface 2002-09-24 07:06:25 +00:00
Oliver Burn e3134ab9b1 added reminder 2002-09-24 06:47:35 +00:00
Oliver Burn b84b3fd04a Implemented a new version of Checker for that uses the Checks. The intent is
to be able reuse the existing checker.

OT: Due to ISP problems, I am unable to receive email at the moment.
2002-09-24 06:34:11 +00:00
Lars Kühne fe6e0fd423 changed param name to match checkstyle naming rules 2002-09-23 05:57:48 +00:00
Lars Kühne 85db5df9c1 check for redundant modifier 2002-09-23 05:56:05 +00:00
Lars Kühne daf94e4e8e WhitespaceAround PLUS and MINUS 2002-09-22 14:00:32 +00:00
Lars Kühne 8313819dcb WhitespaceAround deals with 'return;' 2002-09-22 13:29:57 +00:00
Lars Kühne 0fdfc2f360 intruduced AbstractCheckTestCase to provide common functionality for
all tests for Checks

use Java14 grammar in TreeWalker to be able to parse InputWhitespace.java

improved WhitespaceAroundCheck and added test
2002-09-22 12:27:55 +00:00
Lars Kühne e4434ebe00 added new Java 1.4 grammar 2002-09-22 12:21:39 +00:00
Oliver Burn 78bc37d673 Fixed bug in Check 2002-09-21 14:04:16 +00:00
Oliver Burn 7e570084e6 Nearly for the first test to run. Having problems with loading resource
bundles.
2002-09-21 13:49:01 +00:00
Oliver Burn 03f8352479 Got the unit tests to pass again. They highlighted a bug in the recent
changes, and once again prove they are worth the effort. ;-)
2002-09-19 09:07:57 +00:00
Oliver Burn 1b7d45aed3 Got the unit test to pass 2002-09-19 08:54:43 +00:00
Oliver Burn 40c826f820 changed so that the class loader can be specified. 2002-09-19 00:34:35 +00:00
Oliver Burn 4ef220d914 fixed the problem of line/column numbers not being in the AST. 2002-09-18 23:33:17 +00:00
Oliver Burn bd79d6897e need to eventually fix the checkstyle errors 2002-09-18 23:22:51 +00:00
Lars Kühne 4880b50a3a improved resource bundle handling:
- plugins can use their own bundle (location determined automatically)
- return the message key if ResourceBundle is not available
- added log helper methods in Check.java
2002-09-18 05:08:34 +00:00