Commit Graph

538 Commits

Author SHA1 Message Date
Oliver Burn e44cd4ec43 Added Constant Name Check 2002-10-27 21:58:10 +00:00
Oliver Burn 4d9e56e2b3 Start of port of javadoc check for types. 2002-10-26 08:00:35 +00:00
Oliver Burn b881f65b1a removing dead code 2002-10-26 07:01:32 +00:00
Oliver Burn 0c58241ecd removing dead code 2002-10-26 06:34:46 +00:00
Oliver Burn 8dd406793d Removed unused imports and also refactor scope utilities into a simple class. 2002-10-26 06:21:02 +00:00
Oliver Burn c8958bcd0e added bin to ignore list (Eclipse thing) 2002-10-25 21:58:39 +00:00
Lars Kühne 45e8617a5f removed DnD todo entry 2002-10-25 09:03:25 +00:00
Lars Kühne 5f19a9c5a7 fixed javadoc warning 2002-10-25 07:19:40 +00:00
Lars Kühne 87e4f786a5 Incorporated Rick's cleanup 2002-10-25 06:57:57 +00:00
Lars Kühne 91875d1901 incorporated drag and drop support, patch contributed by Rick Giles
Does not work with Linux/KDE, probably because of java bug #4638443
2002-10-24 17:51:21 +00:00
Oliver Burn 5922229625 Implemented the first Javadoc test. Still need to add some Javadoc (no pun
intended) and also refactor the utility methods.
2002-10-24 14:33:31 +00:00
Oliver Burn 7af9e82fc1 Refactored the comment manager class to having a file contents class. This
class has the file name, lines and comments.
2002-10-24 13:34:30 +00:00
Oliver Burn dcf0d774fa Been replaced by something bigger, brighter and better. 2002-10-24 13:32:24 +00:00
Lars Kühne d43823775a added missing input file for SimplifyBoolean Checks 2002-10-23 05:17:13 +00:00
Lars Kühne c2b22a74a2 fix for bug #626875, array instantiation incorrectly flagged 2002-10-22 14:13:34 +00:00
Lars Kühne acc3f40015 Added branchContains() to DetailAST.
Currently only used in EqualsHashCodeCheck to simplify code,
but I think this will be the main source of performance improvements in TreeWalker
2002-10-22 12:28:09 +00:00
Oliver Burn 65d7c52cf5 Removed unused whitespace 2002-10-22 12:01:05 +00:00
Lars Kühne c28f32e2a8 cleanup of duplicate parsing code in Checker and gui 2002-10-22 11:05:15 +00:00
Lars Kühne 9cd5e92d94 removed line/method length stuff from old codebase 2002-10-22 10:38:13 +00:00
Lars Kühne ceff53c8a4 added generic check for illegal regexps, RFEs #595254 and #621247 2002-10-22 08:02:57 +00:00
Lars Kühne 14e0b00df5 added javadoc, fixed typo in method name 2002-10-22 06:37:34 +00:00
Lars Kühne fc24f5f8b6 added check for equals() vs. hashCode, RFE #554373
see also Item 8 of "Bloch, Effective Java"
2002-10-21 18:04:54 +00:00
Lars Kühne dcca9953bc added Check for inner assignments
wow - took me 30 minutes, this is so easy !!!
2002-10-21 13:54:56 +00:00
Lars Kühne e5a3f98314 added package docs 2002-10-21 12:50:36 +00:00
Lars Kühne c77321d499 added class javadoc 2002-10-21 08:36:57 +00:00
Lars Kühne f1ef403f5e Added SimplifyBooleanExpressionCheck to find code like "if (b == true)".
Also fixed SimplyfyBooleanReturnCheck and introduced tests.
2002-10-21 07:20:19 +00:00
Lars Kühne 54b9235aed also added offending import in avoidStar message 2002-10-21 05:54:38 +00:00
Lars Kühne 768664d654 incorporated patch 626058 from Ville Skytte, Output duplicate/redundant import names 2002-10-21 05:19:15 +00:00
Lars Kühne 404fcfba9c removed line legth checks from old codebase 2002-10-19 13:30:45 +00:00
Lars Kühne 1050efd1ce ported LineLengthCheck 2002-10-19 13:19:41 +00:00
Oliver Burn 84eddc3673 Added a new class TokenTypes that contains all the type constants. This class
breaks the circular dependencies - the cost is needing to maintain this class
when a new grammar is introduced.
2002-10-19 06:28:06 +00:00
Oliver Burn 3f14872d33 Added a target to run the gui 2002-10-19 06:26:09 +00:00
Oliver Burn 94facbbd4d Changed to now display the Token Type as a name 2002-10-19 06:25:45 +00:00
Lars Kühne 5635ac93dc fixed typo in comment 2002-10-18 05:42:46 +00:00
Lars Kühne 7f35e143a2 cleanup of checkstyle errors 2002-10-17 22:52:25 +00:00
Lars Kühne 19708f9811 Added MethodLengthCheck + test
Added some helpers to DetailAST to simplify the implementation of the MethodLengthCheck
2002-10-17 22:08:54 +00:00
Lars Kühne d91c5c64f5 Forgot to commit visibility changes required for the parsing hack in the new
gui to work.

This change should be reverted once we have a central place for parsing.
Each change is marked with a TODO comment.
2002-10-17 20:13:18 +00:00
Lars Kühne c3e5b68479 removed old visibility modifier checks 2002-10-17 20:10:18 +00:00
Lars Kühne d3433c91e0 Added initial GUI.
Oliver, please check that the file headers do not
lead to license problems with Sun - maybe we need to remove
our own header and exclude the gui package from the run.checkstyle
target?
2002-10-17 00:13:04 +00:00
Lars Kühne 220f6cb5d9 ported member visibility checks 2002-10-17 00:07:42 +00:00
Lars Kühne d144d69181 clear childCount cache when branch is thrown away 2002-10-17 00:04:58 +00:00
Oliver Burn dd1421cc88 Removed the old parameter number check. 2002-10-14 23:45:33 +00:00
Oliver Burn 696e7f063f Implemented the parameter number check.
Also fixed more Javadoc.
2002-10-14 23:36:11 +00:00
Oliver Burn 253994d210 Changed so that todo checking is off by default 2002-10-14 11:55:53 +00:00
Oliver Burn 63664e0b01 An attempt to get the Checkstyle error count reduced. Please help....... 2002-10-13 23:41:00 +00:00
Oliver Burn 98f0c51ab0 Moved PadOption 2002-10-13 14:18:18 +00:00
Oliver Burn a0411608c3 Removed the old paren pad check 2002-10-13 14:15:31 +00:00
Oliver Burn aede54ee77 Fully implemented the paren pad check 2002-10-13 14:05:42 +00:00
Oliver Burn 5fd3fab179 Stopped the tokens LPAREN and RPAREN being silently eaten by the grammar. Now
need to implement the ParenPad check. Should be easy.

Also need to refactor some the existing tests to use utility methods for
locating tokens in the tree. Currently hard code the positions, which is not
ideal.
2002-10-13 13:31:42 +00:00
Oliver Burn 5e1da0a269 Moved location of LeftCurlyOption 2002-10-13 12:53:21 +00:00