TouchInstinct
/
java-cas-client
303
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NOJIRA 

switch to stringbuilder since we're on Java 5
This commit is contained in:
Scott Battaglia 2011-02-12 18:29:41 +00:00
parent 035a6f7a8e
commit ec87c31ecd
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cas-client-core/src/main/java/org/jasig/cas/client/util/XmlUtils.java
View File

@ -128,7 +128,7 @@ public final class XmlUtils {
public static String getTextForElement(final String xmlAsString,
final String element) {
final XMLReader reader = getXmlReader();
final StringBuffer buffer = new StringBuffer();
final StringBuilder builder = new StringBuilder();
final DefaultHandler handler = new DefaultHandler() {
@ -152,7 +152,7 @@ public final class XmlUtils {
public void characters(char[] ch, int start, int length)
throws SAXException {
if (this.foundElement) {
buffer.append(ch, start, length);
builder.append(ch, start, length);
}
}
};
@ -167,6 +167,6 @@ public final class XmlUtils {
return null;
}
return buffer.toString();
return builder.toString();
}
}

3
cas-client-core/src/main/java/org/jasig/cas/client/validation/Cas20ServiceTicketValidator.java
View File

@ -87,8 +87,7 @@ public class Cas20ServiceTicketValidator extends AbstractCasProtocolUrlBasedTick
}
final String principal = XmlUtils.getTextForElement(response, "user");
final String proxyGrantingTicketIou = XmlUtils.getTextForElement(
response, "proxyGrantingTicket");
final String proxyGrantingTicketIou = XmlUtils.getTextForElement(response, "proxyGrantingTicket");
final String proxyGrantingTicket = this.proxyGrantingTicketStorage != null ? this.proxyGrantingTicketStorage.retrieve(proxyGrantingTicketIou) : null;
if (CommonUtils.isEmpty(principal)) {