Commit Graph

469 Commits

Author SHA1 Message Date
Scott a8dc2bdc7d Added license headers 2014-12-22 23:55:23 -05:00
Scott 053f26ccb4 Merge branch 'master' into CASC-231 2014-12-22 23:54:46 -05:00
Scott 0911fc7d29 Merge pull request #89 from battags/CASC-200
CASC-200 Introduce Properties File Configuration Option
2014-12-22 22:10:50 -05:00
Scott e0b2618b3d CASC-200 Introduce Properties File Configuration Option
Problem: We can configure via JNDI, WebXML (or both) but not by properties file.
Solution: Introduce a method to use property files.
2014-12-07 14:14:08 -05:00
Scott a7010659f1 CASC-231 HttpsURLConnectonFactory is Not Serializable
Problem: THe HttpsURLConnectionFactory is not serializable, causing problems for clients that must serialize
the principal (which depends on a ProxyRetriever).

Solution: Make the HttpsURLConnectionFactory serializable.

QA Notes: added unit test to confirm serialize-deserialize
2014-12-07 13:32:14 -05:00
Scott a4d3cb77aa Merge pull request #87 from battags/CASC-233
CASC-233 ErrorRedirectFilter Can throw Null Pointer Exception
2014-12-07 12:13:27 -05:00
Scott b76ede66fb Merge pull request #86 from battags/CASC-200-rebasefail
CASC-200 Introduce Mechanism to Indicate Method of Configuration
2014-12-07 12:12:56 -05:00
Scott 4d8057462f Merge branch 'master' into CASC-200-rebasefail
Conflicts:
	cas-client-core/src/main/java/org/jasig/cas/client/session/SingleSignOutFilter.java
2014-12-07 12:11:42 -05:00
Scott Battaglia c89eba7141 Updated try/catch loop to log when a class is not found. 2014-11-30 17:09:09 -05:00
Scott Battaglia f65d227a48 Addressed formatting feedback as well as reserved keywords. 2014-11-26 22:58:12 -05:00
Scott Battaglia 56467dd463 Per feedback, scoped catch block to Exception instead of Throwable 2014-11-26 22:31:01 -05:00
Scott Battaglia 3ea2c3a47e CASC-233 ErrorRedirectFilter Can throw Null Pointer Exception
Problem: the ErrorRedirectFilter assumes there is a root cause and will null pointer if there is not.
Solution: Only use the root cause if there is one, otherwise use the original exception.

QA Notes: Added unit test to confirm non-root cause error.
2014-11-20 16:29:29 -05:00
Scott Battaglia bca2c5e52d Unused reference to Mockito 2014-11-20 16:03:19 -05:00
Scott Battaglia 31d7337124 Removed unused mockito dependency 2014-11-20 16:01:02 -05:00
Scott Battaglia 035a63fe8f Added missing javadoc for Protocol enumeration 2014-11-20 15:58:52 -05:00
Scott Battaglia a997b25f35 Added additional keys that were new from the single signout refactor. 2014-11-20 15:31:31 -05:00
Scott Battaglia 603beabefc CASC-200 Create a ConfigurationStrategy to allow for pluggable configurations.
Problem: The lookup strategy for configuration is hard-coded into the filter, making it impossible to replace or expand.
Solution: Pull the strategies into their own classees and make it configurable.  Default to the previous strategy.

QA Notes: The current unit tests work.  New unit tests for the configuration will have to be added once the design is approved.
2014-11-20 15:30:38 -05:00
Marvin S. Addison 51f6a82a40 [maven-release-plugin] prepare for next development iteration 2014-08-15 08:52:01 -04:00
Marvin S. Addison 32b0d7c882 [maven-release-plugin] prepare release cas-client-3.3.3 2014-08-15 08:51:04 -04:00
Marvin S. Addison 88af091741 Update notice files. 2014-08-15 08:48:05 -04:00
Scott ad904d13c0 Merge pull request #79 from battags/CASC-229
CASC-229 Make Front Channel SSO Optional so that backwards compatibility...
2014-08-13 10:13:45 -04:00
Scott 8e28efce4c Merge pull request #80 from battags/CASC-230
CASC-230 Call HttpServletRequest#logout() via Reflection to Improve Back...
2014-08-13 10:13:28 -04:00
Scott 6a72f0e6e1 Merge pull request #78 from battags/CASC-225
CASC-225 Restore Removed Constructor for Backwards Compatibility
2014-08-13 10:13:20 -04:00
Scott Battaglia 58ead5b9a8 Updated code to abstract the reflection logic a bit more behind a strategy interface. 2014-08-11 23:04:24 -04:00
Scott Battaglia a02cf851c5 CASC-230 Call HttpServletRequest#logout() via Reflection to Improve Backwards Compatibility with Spring Security 2014-08-11 22:50:23 -04:00
Scott Battaglia e70a7a0e7c CASC-229 Make Front Channel SSO Optional so that backwards compatibility is maintained.
Problem: Spring Security adopters will fail to be able to drop in a new version of CAS Client for Java if this feature is enabled by default/required.
Solution: Force a fail-safe optional mode if the value is not provided.
2014-08-11 22:36:27 -04:00
Scott Battaglia 5fd3d11c40 CASC-225 Restore Removed Constructor for Backwards Compatibility
Problem: We removed the two string constructor which breaks Spring Security compatibility.
Solution: Add it back as deprecated so that Spring Security can upgrade.
2014-08-11 22:09:27 -04:00
Scott Battaglia e8c78b8dd3 [maven-release-plugin] prepare for next development iteration 2014-08-03 00:22:49 -04:00
Scott Battaglia 3263202762 [maven-release-plugin] prepare release cas-client-3.3.2 2014-08-03 00:22:14 -04:00
Scott Battaglia e4d925c4ae Added missing license header. 2014-08-03 00:03:25 -04:00
Scott Battaglia d2d7af065d CASC-224 Replace URL with String to remain compatible with Spring Security 2014-07-20 20:31:35 -04:00
Scott ab6cbdc3da Merge pull request #73 from battags/CASC-228
CASC-228 URL Encode Paramaters Passed to Server via Validate
2014-06-29 15:11:58 -04:00
Scott Battaglia ae37092100 CASC-228 URL Encode Paramaters Passed to Server via Validate
Problem: We currently don't pass encoded values to the server, possibly resolving in parsing/extraction errors.
Solution: URL Encode all values instead of just the service url.

QA Notes: Added unit test.
2014-06-24 18:44:45 -04:00
Scott fd962da5c4 Merge pull request #72 from battags/CASC-223
CASC-223 Backwards Compatibility for Initializing Sign Out Handler in Filter
2014-05-22 22:03:26 -04:00
Scott b1e4726e7b Merge pull request #71 from battags/CASC-224
CASC-224 Public API Method Removed without Deprecation
2014-05-12 22:34:01 -04:00
Scott Battaglia 795506f22b Removed no-longer valid test. 2014-05-06 23:17:32 -04:00
Scott Battaglia cacc85c513 Synchronize the init method in case we have multiple concurrent requests at the same time. 2014-05-06 22:53:05 -04:00
Scott Battaglia db4057815a CASC-223 SingleSignOutFilter requires init method to be called which changes the contract with previous versions
Problem: Some clients such as Spring Security configure the filter via Spring configuration, meaning the handler's init method
is not called vai the Filter#init method.

Solution: For now, have an atomic boolean to determine if init was called or not and call it if necessary as part of the flow.
2014-05-06 22:35:55 -04:00
Scott Battaglia b59df9a661 CASC-224 Public API Method Removed without Deprecation
Problem: Previous versions of the CAS Client remove a public API method without sufficient deprecation time resulting in
problems for clients who want to upgrade.

Solution: Add Method back and mark it as deprecated.
2014-05-06 22:12:59 -04:00
LELEU Jérôme 8abbc136aa Merge pull request #68 from leleuj/CASC-220
CASC-220: Support front channel SLO logout
2014-04-09 08:10:42 +02:00
Jérôme LELEU a838bb6c5d CASC-220: Support front channel SLO logout
Update after new Misagh's comments
2014-04-07 18:54:40 +02:00
LELEU Jerome c3ee8b07c9 CASC-220: Support front channel SLO logout
Updates after Marvin's code review
2014-04-01 16:46:19 +02:00
Jérôme LELEU e3cd32cd25 CASC-220: Support front channel SLO logout
Update after Scott's code review
2014-03-27 21:02:30 +01:00
Jérôme LELEU f5c47b857b CASC-220: Support front channel SLO logout
Updates after Misagh's code review
2014-03-21 14:10:33 +01:00
Scott Battaglia 53130b9c34 [maven-release-plugin] prepare for next development iteration 2014-03-19 20:55:47 -04:00
Scott Battaglia 6c34fa929f [maven-release-plugin] prepare release cas-client-3.3.1 2014-03-19 20:55:38 -04:00
Scott Battaglia 2ef3223faa Updated to parent pom 39 2014-03-19 20:50:45 -04:00
Scott Battaglia da00f51d39 Added in missing license header. 2014-03-18 19:26:45 -04:00
unknown 33d39be658 Merge remote-tracking branch 'upstream/master' into CASC-220 2014-03-18 08:16:29 +01:00
Misagh Moayyed 0d83afcc97 Merge pull request #67 from battags/CASC-214
CASC-214 Improve Service Url Construction to Add Non-Standard Ports
2014-03-17 09:15:29 -07:00