Commit Graph

4754 Commits

Author SHA1 Message Date
Michal Kordas 1dcb4b201f Issue #1555: Convert method with array parameter to vararg
Fixes `MethodCanBeVariableArityMethod` inspection violations.

Description:
>Reports methods with which can be converted to be a variable arity/varargs method, available in Java 5 and newer.
This inspection only reports if the project or module is configured to use a language level of 5.0 or higher.
2015-08-29 22:32:25 -07:00
Michal Kordas 0beb5abf9a Issue #1555: Fix malformed JUnit Rule
Fixes `JUnitRule` inspection violations.

Description:
>Reports malformed @Rule/@ClassRule usages:
* Checks for any member that is annotated with @Rule but is not public.
* Checks for any member that is annotated with @ClassRule but is not public or not static.
2015-08-29 22:31:45 -07:00
Michal Kordas 8f16a480da Issue #1555: Remove usage of obsolete junit.framework.Assert
Fixes `UseOfObsoleteAssert` inspection violations.

Description:
>Reports any calls to methods from the junit.framework.Assert class. This class is obsolete and the calls can be replaced by calls to methods from the org.junit.Assert class.
2015-08-29 22:30:30 -07:00
Michal Kordas f418179fce Issue #1555: Rename method returning boolean to use question word
Fixes `BooleanMethodNameMustStartWithQuestion` inspection violations.

Description:
>Reports boolean methods whose names do not start with a question word. Boolean methods that override library methods are ignored by this inspection.
2015-08-29 22:29:43 -07:00
Michal Kordas 1f54d3d689 Issue #1555: Mark methods as static
Fixes `MethodMayBeStatic` inspection violations.

Description:
>Reports any methods which may safely be made static. A method may be static if it is not synchronized, it does not reference any of its class' non static methods and non static fields and is not overridden in a sub class.
2015-08-29 22:28:58 -07:00
Michal Kordas f1cd01472d Issue #1555: Remove unused assignments
Fixes `UnusedAssignment` inspection violations.

Description:
>This inspection points out the cases where a variable value is never used after its assignment
2015-08-29 22:28:16 -07:00
Michal Kordas 2ec015a814 Issue #1555: Remove unsafe calls to Class.newInstance()
Fixes `ClassNewInstance` inspection violations.

Description:
>Reports any calls to java.lang.Class.newInstance(). The newInstance method propagates any exception thrown by the no-arg constructor, including checked exceptions. Use of this method effectively bypasses the compile-time exception checking that would otherwise be performed by the compiler. Replacing such a method call with a call to the java.lang.reflect.Constructor.newInstance() method avoids this problem by wrapping any exception thrown by the constructor in a java.lang.reflect.InvocationTargetException.
2015-08-29 22:27:18 -07:00
Michal Kordas f96930d1a7 Issue #1555: Use function after definition
Fixes some `JSLint` inspection violations.

Description:
>JSLint: 'main' was used before it was defined.
2015-08-29 22:26:30 -07:00
Michal Kordas a1dba1d4a1 Issue #1555: Use previously unused parameter
Fixes `UnusedParameters` inspection violations.

Description:
>This inspection reports parameters that are not used by their methods and all method implementations/overriders.
2015-08-29 17:51:45 -07:00
Michal Kordas c74d7b7549 Issue #1555: Use try-with-resources in test code
The issue was stream not being closed at all or closed, but not in finally block.

Fixes some `IOResource` inspection violations.

Description:
>Reports any I/O resource which is not safely closed in a finally block. Such resources may be inadvertently leaked if an exception is thrown before the resource is closed. I/O resources checked by this inspection include java.io.InputStream, java.io.OutputStream, java.io.Reader, java.io.Writer and java.io.RandomAccessFile. I/O resources which are wrapped by other I/O resources are not reported, as the wrapped resource will be closed by the wrapping resource.
2015-08-29 17:49:43 -07:00
Michal Kordas 7b0388ee96 Issue #1555: Replace for loop that misses component with while loop
Fixes `ForLoopWithMissingComponent` inspection violation.

Description:
>Reports for loops that lack initialization, condition, or update clauses. Some coding styles prohibit such loops.
2015-08-29 15:43:48 -07:00
Michal Kordas 1ad7c80579 Issue #1555: Replace complex boolean expression with set of tokens
Fixes `OverlyComplexBooleanExpression` inspection violation.

Description:
>Reports boolean expressions with too many terms. Such expressions may be confusing and bug-prone.
2015-08-29 15:42:25 -07:00
Ruslan Diachenko 936501d034 Issue #1566: 'missing javadoc comment' violations fixed in Main, AbstractTreeTableModel 2015-08-29 15:39:56 -07:00
Ruslan Diachenko c70cf22d39 Issue #1566: 'missing javadoc comment' violations fixed in ParseTreeModel, TreeTableModelAdapter 2015-08-29 15:39:06 -07:00
Ruslan Diachenko 60b7d4a59d Issue #1566: 'missing javadoc comment' violations fixed in ParseTreeInfoPanel 2015-08-29 15:38:35 -07:00
Ruslan Diachenko 6731df9da7 Issue #1566: 'missing javadoc comment' violations fixed in JTreeTable 2015-08-29 15:37:52 -07:00
Ruslan Diachenko 6a39af3d61 Issue #1566: 'missing javadoc comment' violations fixed in FileDrop 2015-08-29 15:37:24 -07:00
Ruslan Diachenko f0e57dd3c5 Issue #1566: 'missing javadoc comment' violations fixed in CodeSelector 2015-08-29 15:36:58 -07:00
Ruslan Diachenko 1198054650 Issue #1566: 'missing javadoc comment' violations fixed in AbstractJavadocCheck 2015-08-29 15:30:45 -07:00
Ruslan Diachenko 22af64a28c Issue #1566: 'missing javadoc comment' violations fixed for Check, JavadocNodeImpl 2015-08-29 20:39:01 +01:00
Ruslan Diachenko c6e035bb66 Issue #1566: 'missing javadoc comment' violations fixed for JavadocTokenTypes 2015-08-29 20:13:50 +01:00
Baratali Izmailov f32bcd07ee Issue #1566: Fixed CyclomaticCompexityCheck violation in RightCurlyCheck 2015-08-29 14:47:22 -04:00
Baratali Izmailov 9ae0be5921 Issue #1566: Fixed CyclomaticComplexityCheck violation (partial) 2015-08-29 09:41:11 -04:00
Michal Kordas 3d9f726c2d Issue #1555: Decrease visibility of public constructor in non-public class
Fixes `PublicConstructorInNonPublicClass` inspection violations.

Description:
>Reports all constructors in non-public classes that are declared public.
2015-08-29 06:13:47 -07:00
Ruslan Diachenko a95266d1a1 Issue #1566: ReturnCount check activated 2015-08-29 06:13:15 -07:00
Michal Kordas 9cd3660fd5 Issue #1555: Remove usage of obsolete collection
Fixes `ObsoleteCollection` inspection violations.

Description:
>Reports any uses of java.util.Vector or java.util.Hashtable. While still supported, these classes were made obsolete by the JDK1.2 collection classes, and should probably not be used in new development.
2015-08-29 06:12:45 -07:00
Michal Kordas e2f265251a Issue #1555: Avoid reusing variables
Fixes `ReuseOfLocalVariable` inspection violation.

Description:
>Reports local variables that are "reused", overwriting their values with new values unrelated to their original use. Such local variable reuse may be confusing, as the intended semantics of the local variable may vary with each use. It may also be prone to bugs, if code changes result in values that were thought to be overwritten actually being live. It is good practices to keep variable lifetimes as short as possible, and not reuse local variables for the sake of brevity.
2015-08-29 06:12:16 -07:00
Michal Kordas 531327f8c7 Issue #1555: Remove catch of unexpected exceptions in tests
Test will fail anyway, and failure message along with stacktrace will not be lost.
2015-08-29 06:11:42 -07:00
Michal Kordas f3ab307142 Issue #1555: Rename variables with unused exceptions
Fixes `UnusedCatchParameter` inspection violations.

Description:
>Reports any catch parameters that are unused in their corresponding blocks. This inspection will not report any catch parameters named "ignore" or "ignored". Conversely this inspection will warn on any catch parameters named "ignore" or "ignored" that are actually used.
2015-08-29 06:11:42 -07:00
Aleksandr Ivanov 4913b287c0 fixed problem with lexical order in CustomImportOrder #1469 2015-08-28 23:32:56 -07:00
Ruslan Diachenko ef1e65fb51 Issue #1566: ReturnCount violation fixed for CheckUtils 2015-08-28 23:06:51 -07:00
Ruslan Diachenko a09875b9f9 Issue #1566: ReturnCount violation fixed for ParseTreeModel 2015-08-28 23:05:38 -07:00
Ruslan Diachenko e66c64585f Issue #1566: ReturnCount violation fixed for SuppressionCommentFilter 2015-08-28 23:00:10 -07:00
Ruslan Diachenko c3c1b9ae06 Issue #1566: ReturnCount violation fixed for SuppressWithNearbyCommentFilter 2015-08-28 22:59:41 -07:00
Michal Kordas c3674faad8 Issue #1555: Fix some typos in checks package
Fixes some `SpellCheckingInspection` inspection violations.

Description:
>Spellchecker inspection helps locate typos and misspelling in your code, comments and literals.
2015-08-28 22:59:11 -07:00
Michal Kordas 07b24dd81c Issue #1555: Fix various typos
Fixes some `SpellCheckingInspection` inspection violations.

Description:
>Spellchecker inspection helps locate typos and misspelling in your code, comments and literals.
2015-08-28 22:53:43 -07:00
Michal Kordas 46a52f84c0 Issue #1555: Rename methods returning boolean to use question word
Fixes some `BooleanMethodNameMustStartWithQuestion` inspection violations.

Description:
>Reports boolean methods whose names do not start with a question word. Boolean methods that override library methods are ignored by this inspection.
2015-08-28 22:50:51 -07:00
Ruslan Diachenko 904de34fcd Issue #1566: ReturnCount violation fixed for WhitespaceAroundCheck 2015-08-28 22:49:55 -07:00
Michal Kordas e9ec5bfbd5 Issue #1555: Avoid reusing variables
Fixes some `ReuseOfLocalVariable` inspection violations.

Description:
>Reports local variables that are "reused", overwriting their values with new values unrelated to their original use. Such local variable reuse may be confusing, as the intended semantics of the local variable may vary with each use. It may also be prone to bugs, if code changes result in values that were thought to be overwritten actually being live. It is good practices to keep variable lifetimes as short as possible, and not reuse local variables for the sake of brevity.
2015-08-28 22:49:12 -07:00
Michal Kordas 9cc86b38df Issue #1555: Specify encoding explicitly
Fixes `ImplicitDefaultCharsetUsage` inspection violations.

Description:
>Reports method and constructor calls which implicitly use the platform's default charset. These can produce different results on (e.g. foreign language) systems that use a different default charset, resulting in unexpected behaviour.
2015-08-28 22:48:12 -07:00
Ruslan Diachenko a827b7cbbf Issue #1566: ReturnCount violation fixed for ModifierOrderCheck 2015-08-28 22:47:37 -07:00
Ruslan Diachenko c3af7d4b0e Issue #1566: ReturnCount violation fixed for JavadocStyleCheck 2015-08-28 22:46:44 -07:00
Ruslan Diachenko 8da3b6dea4 Issue #1566: ReturnCount violation fixed for AbstractJavadocCheck 2015-08-28 22:45:58 -07:00
Ruslan Diachenko 7b26e83b92 Issue #1566: ReturnCount violation fixed for AbstractExpressionHandler 2015-08-28 22:45:17 -07:00
Ruslan Diachenko f02d45fd6d Issue #1566: ReturnCount violation fixed for DesignForExtensionCheck 2015-08-28 22:44:41 -07:00
Michal Kordas f58f92adf6 Issue #1555: Fix false-positive in mismatched array read write rule
False-positive reported to JetBrains as [IDEA-144521](https://youtrack.jetbrains.com/issue/IDEA-144521).

Fixes `MismatchedArrayReadWrite` inspection violations.

Description:
>Reports any array fields or variables whose contents are read but not written, or written but not read. Such mismatched reads and writes are pointless, and probably indicate dead, incomplete or erroneous code.
2015-08-28 22:43:58 -07:00
Michal Kordas 8985e645a8 Issue #1555: Rename boolean methods to start with question word
Fixes `BooleanMethodNameMustStartWithQuestion` inspection violations.

Description:
>Reports boolean methods whose names do not start with a question word. Boolean methods that override library methods are ignored by this inspection.
2015-08-28 22:43:04 -07:00
Michal Kordas 1e541f0b98 Issue #1555: Delete unnecessary imports
Fixes `UnusedImport` inspection violations.

Description:
>Reports any import statements that are unused. Since IDEA can automatically detect and fix such statements with its "Optimize Imports" command, this inspection is mostly useful for off-line reporting on code bases that you don't intend to change.
2015-08-28 22:42:18 -07:00
Michal Kordas 83396526ac Issue #1555: Use constant for empty array of zero length
Fixes `ZeroLengthArrayInitialization` inspection violations.

Description:
>Reports on allocations of arrays with known lengths of zero. Since array lengths in Java are non-modifiable, it is almost always possible to share zero-length arrays, rather than repeatedly allocating new zero-length arrays. Such sharing may provide useful optimizations in program runtime or footprint. Note that this inspection does not report zero-length arrays allocated as static final fields, as it is assumed that those arrays are being used to implement array sharing.
2015-08-28 22:41:09 -07:00
Michal Kordas 4d0c118595 Issue #1555: Remove unnecessary boxing
Fixes `CachedNumberConstructorCall` inspection violations.

Description:
>Reports any attempt to instantiate a new Long, Integer, Short or Byte object from a primitive long, integer, short or byte argument. It may be more efficient to use the static method valueOf() here (introduced in Java 5), which will cache objects for values between -128 and 127 inclusive.
This inspection only reports if the project or module is configured to use a language level of 5.0 or higher.
2015-08-28 22:40:36 -07:00