Commit Graph

607 Commits

Author SHA1 Message Date
Oleg Sukhodolsky c4c966c971 Fix grammar build process (RFE 827781) 2003-11-13 16:32:53 +00:00
Lars Kühne 4f9debc29b fixed copy+paste problem in examples of StrictDuplicateCode check
damn, there's always something you notice right after making a release
2003-11-12 05:17:55 +00:00
Lars Kühne 392e556d70 made optional.jar maven friendly (requested by V.Massol, maintainer of Maven plugin) 2003-11-11 05:53:07 +00:00
Oliver Burn ac9fe51610 Added JBuilder link 2003-11-10 09:35:25 +00:00
Rick Giles f90a08de09 spelling correction 2003-11-08 20:56:25 +00:00
Rick Giles b7d4d721a2 spelling correction 2003-11-08 12:50:51 +00:00
Lars Kühne 53638cd097 added note about core vs optional 2003-11-08 12:43:19 +00:00
Lars Kühne 5c3762cef2 fixed bug 837012, false alarms for abstract classes 2003-11-08 12:29:19 +00:00
Rick Giles 476f90c5d3 update Filter UML diagram 2003-11-07 14:57:24 +00:00
Oleg Sukhodolsky 8d242382f8 Filter.accept() now takes AuditEvent, not an Object. 2003-11-07 04:49:54 +00:00
Lars Kühne 100353f305 ... and antlr has been version 2.7.2 since March. I guess it's too late to put that into the 3.1 releasenotes :-) 2003-11-05 05:22:50 +00:00
Lars Kühne 5fa9891d4b we now use jakarta-regexp 1.3 2003-11-05 05:16:08 +00:00
Oleg Sukhodolsky 778e844080 Added removeListener() and removeFilter() to Checker (bug 834367) 2003-11-05 04:26:12 +00:00
Lars Kühne 08a76dba14 fixed bug 824754 2003-10-27 06:14:36 +00:00
Rick Giles 84d33e55d9 Fixed HiddenFieldCheck error for a local variable of a static
method with same name as an instance field(bug 827713)
2003-10-27 00:32:00 +00:00
Lars Kühne 60ecfe9c06 documented StrictDuplicate code check and incompatible API change 2003-10-24 05:43:11 +00:00
Lars Kühne e16c4a8259 spec for StrictDuplicateCode 2003-10-12 07:15:52 +00:00
Oleg Sukhodolsky 861e2af0e1 Changed default format for ConstantName. (see bug 807571). 2003-10-09 04:20:46 +00:00
Oleg Sukhodolsky 984eb8d742 ExplicitInitialization added to checkstyle's style. Fixed problems it found. 2003-10-08 17:46:58 +00:00
Oliver Burn 1bb0fb09a3 Upgraded to jakarta-regexp-1.3. 2003-10-08 13:02:30 +00:00
Oleg Sukhodolsky 03c3efabf3 Check for variable explicit initialization (request 614387) 2003-10-04 17:01:27 +00:00
Oleg Sukhodolsky 194f86d218 Release notes update. 2003-10-04 01:28:58 +00:00
Oleg Sukhodolsky 868ae755c1 Fixed documentation for Indentation check. 2003-09-30 10:06:53 +00:00
Lars Kühne 2200323756 fixed typos and html layout 2003-09-28 05:27:00 +00:00
Oleg Sukhodolsky 60d0673dcc Documentation for Indentation check. 2003-09-27 05:26:28 +00:00
Oleg Sukhodolsky ee987808d1 Update for releasenotes 2003-09-22 12:47:03 +00:00
Rick Giles 0527cab338 documented optional Checks (bug 806961) 2003-09-21 14:11:28 +00:00
Oleg Sukhodolsky 2a1705e70d ImportOrder check from Bill Schneider (request 745548)docs/releasenotes.html 2003-09-16 18:37:57 +00:00
Oleg Sukhodolsky 77ca904cf5 Fixed 806242 (NoWhitespaceBeforeCheck error with an interface).
Fixed 806243 (NoWhitespaceBeforeCheck error for anonymous inner
class).
Now build will fail if antlr fails to process the grammar.
2003-09-15 06:01:31 +00:00
Rick Giles cdbb83775e Fixed Unused... checks don't work together (bug 805954) 2003-09-14 22:39:58 +00:00
Rick Giles 0c717ef2ab Added FinalLocalVariable check from Roland Auckenthaler and Kevin Gibbs. 2003-09-11 12:01:47 +00:00
Oleg Sukhodolsky 2acda3b127 Fix for 803577 (allowThrowsTagsForSubclasses/allowMissingThrowsTag interfere) 2003-09-11 03:53:51 +00:00
Oleg Sukhodolsky 15ccd93806 Added ParameterAssignment check contributed by Simon Harris (request 750748).
Fixed internatialization support in DeclarationOrder check.
2003-09-07 11:15:58 +00:00
Oleg Sukhodolsky d041e5226b DeclarationOrder check contibuted by Roland Auckenthaler 2003-09-06 20:14:39 +00:00
Oleg Sukhodolsky 75773acf4f Added IllegalType check from Simon Harris (request 750739).
Added getter for illegalClassNames property of IllegalCatch check.
2003-09-04 18:35:22 +00:00
Rick Giles 39c810009d Commented out HeaderCheck.
Now sun_checks.xml can be used without setting properties for property expansion.
2003-09-02 19:47:29 +00:00
Oleg Sukhodolsky a56be052af Changed configuration documentation example from checkstyle_checks.xml to sun_checks.xml (see bug 750169) 2003-09-02 17:27:52 +00:00
Rick Giles 4ba49828ac Fixed bug 798111: Unused local variables are not always detected.
Example given was caused by incorrectly considering a typecast to
be a variable reference. Types were also incorrectly considered as
variable references.
2003-09-02 09:30:51 +00:00
Rick Giles 611722a893 Fixed bug 798405 JavadocStyleCheck doesn't accept {@inheritDoc} javadoc 2003-09-01 10:10:40 +00:00
Rick Giles a00160b33c Added property to HiddenFieldCheck to ignore constructor parameters (request 798240). 2003-08-31 21:35:07 +00:00
Rick Giles 20b7faa450 Moved ExecutableStatementCountCheck to sizes package. 2003-08-31 16:26:01 +00:00
Rick Giles d8766886f2 Added INSTANCE_INIT to tokens for EmptyBlockCheck. 2003-08-31 10:26:42 +00:00
Rick Giles b8f9b199ad Added ExecutableStatementCount check from Simon Harris (request 750751). 2003-08-30 21:17:41 +00:00
Rick Giles 1952077d3e Changed configuration documentation example from checkstyle_checks.xml
to sun_checks.xml  (see bug 750169)
2003-08-29 19:12:47 +00:00
Rick Giles 32fcc5d7db documented CyclomaticComplexity (bug 783800) 2003-08-29 18:44:59 +00:00
Rick Giles 6b1ad4f2d6 corrected usage checks documentation (bug 790457) 2003-08-29 15:05:02 +00:00
Oleg Sukhodolsky 9bc9f41827 Added ThrowsCount check from Simon Harris (request 750742).
Added ReturnCount check from Simon Harris (request 750745).
Minor fixes in release notes.
2003-08-28 19:18:31 +00:00
Oleg Sukhodolsky ec796dc641 moving/renaming [Illegal]AbstractClassName check to naming package. 2003-08-28 06:50:45 +00:00
Oleg Sukhodolsky f06e7b12c3 Added IllegalAbstractClassName check (request 750749). 2003-08-27 21:14:39 +00:00
Oleg Sukhodolsky 5245c14883 Added MutableException check (request 750750).
This is a very simple algorithm, but, I believe, it catches most of
real-life problems.
2003-08-26 20:06:58 +00:00
Oleg Sukhodolsky 92d37dd95e Applying patch 783672 (Package names.xml documentation). 2003-08-26 16:21:11 +00:00
Oleg Sukhodolsky 76f1dd84bf Added JUnitTestCase check. (request 750761). 2003-08-25 18:12:12 +00:00
Oleg Sukhodolsky bdaf63e08c Added PackageDeclaration check. (request 750753). 2003-08-22 15:24:27 +00:00
Oleg Sukhodolsky 67da361a9a illegalClassNames property added to IllegalCatch check. 2003-08-21 20:55:19 +00:00
Oleg Sukhodolsky 9aa9d75107 IllegalCatchCheck (request 750746). 2003-08-21 20:04:46 +00:00
Oleg Sukhodolsky 5bac11f295 Release notes update 2003-08-20 11:50:57 +00:00
Rick Giles d468d6151d minor grammar corrections 2003-08-20 11:49:08 +00:00
Rick Giles 5c9578a108 Removed finder restrictions of LocalHomeInterfaceCheck and RemoteHomeInterfaceCheck (bug 791591) 2003-08-20 10:07:01 +00:00
Oleg Sukhodolsky 1d0c8e6e0e Documentation for DescendantToken check 2003-08-19 16:45:47 +00:00
Oleg Sukhodolsky 0855fff95e Fix for NoSuchMethodError when line wrapped at dot operator (bug 790209) 2003-08-19 04:54:31 +00:00
Rick Giles dc3fc5fab0 Added property to HiddenFieldCheck to ignore the parameter of
property setter methods (request 790456).
2003-08-18 12:27:55 +00:00
Rick Giles af1b996a4e fixed bug 787672, NullPointerException in Unused... checks 2003-08-16 10:54:41 +00:00
Rick Giles 60847a32d5 fixed bug 788106, MagicNumberCheck does not permits negative constants 2003-08-13 23:59:39 +00:00
Rick Giles 113ea8405c Corrected RedundantModifierCheck error for public modifier of a
method defined in an inner implementation (bug 784814).
2003-08-10 10:39:33 +00:00
Rick Giles 927ec62235 fixed NoSuchElementException in JavadocStyleCheck (bug 785514) 2003-08-09 16:46:25 +00:00
Lars Kühne e9cc31b2ec added docs for duplicate code detection 2003-08-09 06:30:58 +00:00
Lars Kühne d974a457e1 use 3.x instead of 3.0 as the upgrade target 2003-08-09 05:46:50 +00:00
Lars Kühne bb1db4938c fixed bug #772832, Confusion about class named 'Boolean' 2003-08-03 13:22:44 +00:00
Rick Giles 2d1687465f minor technical correction to documentation 2003-08-02 15:57:55 +00:00
Oleg Sukhodolsky 1c7341013d fixed typo in config file. 2003-07-29 09:05:28 +00:00
Rick Giles 3535f542dc Added a check for illegal token text (requests 740694 and 750633) 2003-07-26 20:16:24 +00:00
Rick Giles 8a12b000f2 Added MethodLengthCheck option for counting empty and comment lines (requests 589358 and 654039). 2003-07-26 11:32:38 +00:00
Rick Giles ee8467d367 Corrected EmptyForIteratorPadCheck errors when line wrap occurs
at the iterator, bug 777471
2003-07-25 16:13:32 +00:00
Rick Giles 89188bf3eb minor HTML correction 2003-07-21 19:13:10 +00:00
Rick Giles 3ed2fd68f8 Enhanced RedundantModifier to check that all private methods and all methods in a
final class do not contain modifier final (discussed in request 775011)
2003-07-21 19:05:13 +00:00
Oleg Sukhodolsky 57ea0b6a11 Made basedir property of Checker OS agnostic (663149) 2003-07-20 08:17:36 +00:00
Rick Giles dd477210ae Custom listeners can be incorported as config modules,
not command line arguments and ant task elements.
2003-07-18 11:31:45 +00:00
Rick Giles 524dd37a5b documentation for Filter/FilterSet 2003-07-16 10:20:46 +00:00
Rick Giles a9bfdceec2 completed Filter docs. 2003-07-15 11:10:15 +00:00
Rick Giles 0587b63fec documented Filter configuration 2003-07-14 20:28:12 +00:00
Rick Giles 524a7eca73 Renamed "filter" package to "filters" for consistency with "checks".
Incorporated "filters" in package names.
2003-07-14 18:43:49 +00:00
Rick Giles e464c7197a spelling 2003-07-14 17:48:19 +00:00
Oliver Burn 51dae59b8d New Javadoc style check from Chris Stillwell. 2003-07-14 12:31:52 +00:00
Rick Giles e55435125e corrected misspelling of "precede", bug 744342 2003-07-14 10:24:01 +00:00
Rick Giles ea10feeb83 usage docs 2003-07-11 18:37:45 +00:00
Rick Giles bb52a25c6c added check that overriding finalize method calls super.finalize 2003-07-07 09:17:30 +00:00
Rick Giles 18718ffeab added check that an overriding clone() method calls super.clone(). 2003-07-06 22:33:59 +00:00
Rick Giles b904923180 docs for j2ee checks 2003-07-05 17:17:28 +00:00
Lars Kühne 59de966a7e Added allowInSwitchCase property to AvoidNestedBlocksCheck
to allow limiting the scope of variables to one case of a switch statement.

Also currently playing with the Clover IDEA plugin - man, this rocks!!
2003-07-05 11:09:52 +00:00
Rick Giles f9e4b4c304 minor grammar correction 2003-07-02 19:50:41 +00:00
Rick Giles b07f845ac1 added IllegalTokenCheck, request 750755 2003-07-02 12:48:43 +00:00
Oleg Sukhodolsky 50c242141a indent.severity removed, translation.severity added to checkstyle.style target 2003-06-29 12:56:51 +00:00
Oleg Sukhodolsky 8de6dda16b Fix javadoc problem. 2003-06-29 10:04:52 +00:00
Oleg Sukhodolsky a30cd217f3 Implementation for NestedIfDepthCheck and NestedTryDepthCheck.
Thanks Simon.
2003-06-28 20:02:25 +00:00
Oliver Burn 768256c32a I am sick of Spam! :-( 2003-06-27 11:04:38 +00:00
Lars Kühne cc822a77b4 fixed typo (security vs severity) 2003-06-27 04:25:12 +00:00
Rick Giles 71d92d649f check that a class that defines a covariant equals method also overrides
equals(java.lang.Object)
2003-06-26 16:19:46 +00:00
Lars Kühne b19b59296f added docs for StringLiteralEquality 2003-06-26 04:43:28 +00:00
Oliver Burn 3a75454e8d Added CyclomaticComplexityCheck from Simon Harris.
Refactored quite a bit
2003-06-24 12:35:40 +00:00
Lars Kühne 731b581a1c Added excludes property to AvoidStarImport, request 744955
contributed by Bill Schneider
2003-06-23 21:11:23 +00:00
Oliver Burn cf089fe1a1 Fix the Checkstyle errors created by Spud's patch. 2003-06-23 11:36:07 +00:00
Oliver Burn e03dab4d1f Patch from Matt Quail to stop the ugly hack of having hard
coded constants in TokenTypes. The big risk was that when
the grammar changed, the generated constants could
change. (patch 757846)
2003-06-21 12:34:01 +00:00
Oleg Sukhodolsky f4a85d495c Fix for bug#755744 2003-06-20 08:51:47 +00:00
Oliver Burn db5ec5f654 Nice patch from Matt Quail to DetailAST to replace all the repeated int[] array construction with a BitSet. 2003-06-19 13:20:33 +00:00
Oliver Burn 9920857810 Refactored the Coding checks 2003-06-15 12:39:40 +00:00
Oleg Sukhodolsky 41758923b8 Fix for [ 694111 ] Syntax error crashes Checkstyle. Update for release notes missed from previous putback 2003-06-14 17:07:26 +00:00
Rick Giles ca5c92f2e7 Added ignoreFormat property to HiddenFieldCheck (request 748830). 2003-06-12 17:30:23 +00:00
Oliver Burn 889587fdd2 Updated the license file for the current year. All this legal license stuff is
a real drag. :-(
2003-06-09 07:48:20 +00:00
Oliver Burn 99ed7a7d2c bug-750348: added check for typecast parens. Involved
a bit of refactoring.
2003-06-09 06:20:19 +00:00
Oliver Burn 75a289111e bug-750348: removed broken support for checking typecasts 2003-06-09 05:17:39 +00:00
Oleg Sukhodolsky e2b680ab7e Corrected package name for AnonInnerLength. 2003-06-07 16:25:48 +00:00
Lars Kühne bd5093dcc1 added new feature AnonInnerLength 2003-06-07 08:38:42 +00:00
Lars Kühne 8499348b9a added docs for AnonInnerLength 2003-06-07 08:33:46 +00:00
Oleg Sukhodolsky 7a8113d383 Package names corrected in config documentation. 2003-06-07 08:18:25 +00:00
Rick Giles 679f818267 fixed NumberFormatException in MagicNumberCheck (bug 748913) 2003-06-04 16:08:36 +00:00
Oleg Sukhodolsky a395eeeb9b fix for 748028 (PackageName documentation error). Removing one extra slash from default value of format property. 2003-06-03 11:51:32 +00:00
Rick Giles 4981978ee2 Corrected bug 747530, inner class fields interpreted as local variables.
Incorporated catch parameters as local variables.
2003-06-02 18:06:35 +00:00
Rick Giles 17f01c9f0c fixed bug 747400, EmptyBlock does not accept stmt option 2003-06-02 09:17:59 +00:00
Oleg Sukhodolsky 40de78da0f ArrayTrailingComma added to Checkstyle style.
All new failures fixed.
2003-06-01 00:13:22 +00:00
Rick Giles 2cd7daccf2 minor improvement in severity example 2003-05-31 13:42:51 +00:00
Rick Giles e01e5e09c1 added docs for severity (bug 745937) 2003-05-31 12:17:41 +00:00
Lars Kühne 4331cca642 small fixes 2003-05-31 04:57:23 +00:00
Oleg Sukhodolsky 1878e21451 Added check for uncommented main methods (debugging leftovers). (module UncommentedMain,request 732257) 2003-05-30 19:35:55 +00:00
Rick Giles e8ad93aea6 corrected false MagicNumberCheck errors for interfaces (bug 745941)
MagicNumberCheck now checks array initializers. (request 745949)
2003-05-30 10:37:35 +00:00
Lars Kühne 38b9cdcf6e fixed bug #743973, typo in HideUtilityClassContructor docs 2003-05-29 06:19:05 +00:00
Oleg Sukhodolsky 55512ae033 Added check for trailing comma in array initialization. (module ArrayTrailingComma, request 696301) 2003-05-29 03:30:44 +00:00
Rick Giles 45ce38623f finish custom listeners documentation 2003-05-28 11:56:41 +00:00
Oliver Burn 5133219581 Fixed NPE when running ArrayTypeStyle check (bug 744573) 2003-05-28 08:40:16 +00:00
Rick Giles 5599c68a82 added documentation for CommonsLoggingListener 2003-05-27 23:45:26 +00:00
Rick Giles f2b01a44a2 Added custom listener feature 2003-05-27 17:33:24 +00:00
Oliver Burn eaa7b83bc9 Add template for the next release 2003-05-27 10:21:41 +00:00
Oliver Burn 3f0ff8a7e7 minor clean up 2003-05-23 07:30:21 +00:00
Oliver Burn 6d0cb22edf Revamped to include all checks. Also hopefully improved the documentation. 2003-05-23 07:21:21 +00:00
Oliver Burn 8531b2b318 Fixed so that the translation check will be run, except under GUMP conditions. 2003-05-23 01:18:29 +00:00
Rick Giles 9bb2ad91c9 renamed DesignForInheritanceCheck to DesignForExtensionCheck 2003-05-22 23:25:22 +00:00
Rick Giles bf8012b13d updated screenshot with Reload Java File button 2003-05-21 15:14:58 +00:00
Rick Giles 1e67ec5577 Incorporated patch from Bill Schneider to add property to
GenericIllegalRegexpCheck for case-insensitive matches
(request 740112).
2003-05-21 13:39:23 +00:00
Rick Giles cb5ab77359 document patch by Dale King for request 740545 2003-05-20 16:30:25 +00:00
Oliver Burn 8cf07f17e8 RFE 739881: Moved the location of the file
checkstyle_packages.xml to be in the directory
com/puppycrawl/tools/checkstyle. This is to work around
a bug in NetBeans.
2003-05-20 13:30:41 +00:00
Rick Giles e1c6922152 updated URL 2003-05-20 09:51:04 +00:00
Lars Kühne 1624dcb01e note about bugfix for 724573 2003-05-20 05:40:25 +00:00
Rick Giles 9b585ff48b added EmptyForIteratorPad docs 2003-05-19 19:54:53 +00:00
Rick Giles bc39ac3463 added link to BlueJ Checkstyle extension 2003-05-19 19:15:50 +00:00
Oleg Sukhodolsky f0edd3eaf1 Indentation:
fix for indentation problems found be Indentation check.
Indentation check added to checkstyle_checkstyle.xml with "warning" severity.
2003-05-19 17:34:26 +00:00
Oliver Burn 2f98a4aa29 Document bug fixed about closing files 2003-05-19 03:22:43 +00:00
Oleg Sukhodolsky 896b671caa Added property for GenericIllegalRegexp to customize reported message.
(module GenericIllegalRegexp, property message, request 738567)
2003-05-17 18:09:28 +00:00
Lars Kühne 7b745053e4 small fixes 2003-05-16 15:34:01 +00:00
Oliver Burn a4d63db21d Disabled the translation check for the moment.
Added a check to detect trailing whitespace as discussed today and fixed all
the resulting errors. Thank god for Emacs, I recorded a keyboard macro to fix
all the errors. Otherwise this would have been a tough task.
2003-05-14 08:11:49 +00:00
Oliver Burn 93277b0730 Cosmetic changes 2003-05-14 07:47:41 +00:00
Oleg Sukhodolsky bb0a041a3a Added check for redundant exceptions in
throws clause (module RedundantThrows, request 579056)
2003-05-14 03:18:33 +00:00