Commit Graph

607 Commits

Author SHA1 Message Date
Oliver Burn cf089fe1a1 Fix the Checkstyle errors created by Spud's patch. 2003-06-23 11:36:07 +00:00
Oliver Burn e03dab4d1f Patch from Matt Quail to stop the ugly hack of having hard
coded constants in TokenTypes. The big risk was that when
the grammar changed, the generated constants could
change. (patch 757846)
2003-06-21 12:34:01 +00:00
Oleg Sukhodolsky f4a85d495c Fix for bug#755744 2003-06-20 08:51:47 +00:00
Oliver Burn db5ec5f654 Nice patch from Matt Quail to DetailAST to replace all the repeated int[] array construction with a BitSet. 2003-06-19 13:20:33 +00:00
Oliver Burn 9920857810 Refactored the Coding checks 2003-06-15 12:39:40 +00:00
Oleg Sukhodolsky 41758923b8 Fix for [ 694111 ] Syntax error crashes Checkstyle. Update for release notes missed from previous putback 2003-06-14 17:07:26 +00:00
Rick Giles ca5c92f2e7 Added ignoreFormat property to HiddenFieldCheck (request 748830). 2003-06-12 17:30:23 +00:00
Oliver Burn 889587fdd2 Updated the license file for the current year. All this legal license stuff is
a real drag. :-(
2003-06-09 07:48:20 +00:00
Oliver Burn 99ed7a7d2c bug-750348: added check for typecast parens. Involved
a bit of refactoring.
2003-06-09 06:20:19 +00:00
Oliver Burn 75a289111e bug-750348: removed broken support for checking typecasts 2003-06-09 05:17:39 +00:00
Oleg Sukhodolsky e2b680ab7e Corrected package name for AnonInnerLength. 2003-06-07 16:25:48 +00:00
Lars Kühne bd5093dcc1 added new feature AnonInnerLength 2003-06-07 08:38:42 +00:00
Lars Kühne 8499348b9a added docs for AnonInnerLength 2003-06-07 08:33:46 +00:00
Oleg Sukhodolsky 7a8113d383 Package names corrected in config documentation. 2003-06-07 08:18:25 +00:00
Rick Giles 679f818267 fixed NumberFormatException in MagicNumberCheck (bug 748913) 2003-06-04 16:08:36 +00:00
Oleg Sukhodolsky a395eeeb9b fix for 748028 (PackageName documentation error). Removing one extra slash from default value of format property. 2003-06-03 11:51:32 +00:00
Rick Giles 4981978ee2 Corrected bug 747530, inner class fields interpreted as local variables.
Incorporated catch parameters as local variables.
2003-06-02 18:06:35 +00:00
Rick Giles 17f01c9f0c fixed bug 747400, EmptyBlock does not accept stmt option 2003-06-02 09:17:59 +00:00
Oleg Sukhodolsky 40de78da0f ArrayTrailingComma added to Checkstyle style.
All new failures fixed.
2003-06-01 00:13:22 +00:00
Rick Giles 2cd7daccf2 minor improvement in severity example 2003-05-31 13:42:51 +00:00
Rick Giles e01e5e09c1 added docs for severity (bug 745937) 2003-05-31 12:17:41 +00:00
Lars Kühne 4331cca642 small fixes 2003-05-31 04:57:23 +00:00
Oleg Sukhodolsky 1878e21451 Added check for uncommented main methods (debugging leftovers). (module UncommentedMain,request 732257) 2003-05-30 19:35:55 +00:00
Rick Giles e8ad93aea6 corrected false MagicNumberCheck errors for interfaces (bug 745941)
MagicNumberCheck now checks array initializers. (request 745949)
2003-05-30 10:37:35 +00:00
Lars Kühne 38b9cdcf6e fixed bug #743973, typo in HideUtilityClassContructor docs 2003-05-29 06:19:05 +00:00
Oleg Sukhodolsky 55512ae033 Added check for trailing comma in array initialization. (module ArrayTrailingComma, request 696301) 2003-05-29 03:30:44 +00:00
Rick Giles 45ce38623f finish custom listeners documentation 2003-05-28 11:56:41 +00:00
Oliver Burn 5133219581 Fixed NPE when running ArrayTypeStyle check (bug 744573) 2003-05-28 08:40:16 +00:00
Rick Giles 5599c68a82 added documentation for CommonsLoggingListener 2003-05-27 23:45:26 +00:00
Rick Giles f2b01a44a2 Added custom listener feature 2003-05-27 17:33:24 +00:00
Oliver Burn eaa7b83bc9 Add template for the next release 2003-05-27 10:21:41 +00:00
Oliver Burn 3f0ff8a7e7 minor clean up 2003-05-23 07:30:21 +00:00
Oliver Burn 6d0cb22edf Revamped to include all checks. Also hopefully improved the documentation. 2003-05-23 07:21:21 +00:00
Oliver Burn 8531b2b318 Fixed so that the translation check will be run, except under GUMP conditions. 2003-05-23 01:18:29 +00:00
Rick Giles 9bb2ad91c9 renamed DesignForInheritanceCheck to DesignForExtensionCheck 2003-05-22 23:25:22 +00:00
Rick Giles bf8012b13d updated screenshot with Reload Java File button 2003-05-21 15:14:58 +00:00
Rick Giles 1e67ec5577 Incorporated patch from Bill Schneider to add property to
GenericIllegalRegexpCheck for case-insensitive matches
(request 740112).
2003-05-21 13:39:23 +00:00
Rick Giles cb5ab77359 document patch by Dale King for request 740545 2003-05-20 16:30:25 +00:00
Oliver Burn 8cf07f17e8 RFE 739881: Moved the location of the file
checkstyle_packages.xml to be in the directory
com/puppycrawl/tools/checkstyle. This is to work around
a bug in NetBeans.
2003-05-20 13:30:41 +00:00
Rick Giles e1c6922152 updated URL 2003-05-20 09:51:04 +00:00
Lars Kühne 1624dcb01e note about bugfix for 724573 2003-05-20 05:40:25 +00:00
Rick Giles 9b585ff48b added EmptyForIteratorPad docs 2003-05-19 19:54:53 +00:00
Rick Giles bc39ac3463 added link to BlueJ Checkstyle extension 2003-05-19 19:15:50 +00:00
Oleg Sukhodolsky f0edd3eaf1 Indentation:
fix for indentation problems found be Indentation check.
Indentation check added to checkstyle_checkstyle.xml with "warning" severity.
2003-05-19 17:34:26 +00:00
Oliver Burn 2f98a4aa29 Document bug fixed about closing files 2003-05-19 03:22:43 +00:00
Oleg Sukhodolsky 896b671caa Added property for GenericIllegalRegexp to customize reported message.
(module GenericIllegalRegexp, property message, request 738567)
2003-05-17 18:09:28 +00:00
Lars Kühne 7b745053e4 small fixes 2003-05-16 15:34:01 +00:00
Oliver Burn a4d63db21d Disabled the translation check for the moment.
Added a check to detect trailing whitespace as discussed today and fixed all
the resulting errors. Thank god for Emacs, I recorded a keyboard macro to fix
all the errors. Otherwise this would have been a tough task.
2003-05-14 08:11:49 +00:00
Oliver Burn 93277b0730 Cosmetic changes 2003-05-14 07:47:41 +00:00
Oleg Sukhodolsky bb0a041a3a Added check for redundant exceptions in
throws clause (module RedundantThrows, request 579056)
2003-05-14 03:18:33 +00:00
Lars Kühne bf6758b29d documentation improvements from Peter Dobratz 2003-05-11 07:31:23 +00:00
Rick Giles b59648d605 Added line and column numbers to configuration parse exceptions
(request 714962).
2003-05-10 15:17:54 +00:00
Rick Giles 61e6ce5ee7 Added "source" attribute to "error" element of XMLLogger output. 2003-05-10 10:59:20 +00:00
Oleg Sukhodolsky 4e1f8ef98e One more option for JavadocMethodCheck
(allowThrowsTagsForSubclasses, request 540383)
2003-05-09 18:14:25 +00:00
Rick Giles 40e9a0a4ea moved bug fix to correct release number (3.1) 2003-05-09 13:24:56 +00:00
Rick Giles 5156e90846 noted resolved bug 713845 2003-05-08 12:48:04 +00:00
Rick Giles fdc9cc3713 added item for MagicNumberCheck 2003-05-07 17:11:56 +00:00
Rick Giles 7284e8aa42 magic number check. RFE 564206 2003-05-07 16:57:32 +00:00
Lars Kühne 9a9e7318a3 added note for empty statement check
Oleg has joined the team
2003-05-06 05:40:43 +00:00
Lars Kühne ebc06c9c2e added docs for EmptyStatement 2003-05-06 05:34:49 +00:00
Lars Kühne 4c1197e35d added comments for the regexp values 2003-05-06 05:09:30 +00:00
Lars Kühne a2e58a8d5f added example for finding trailing whitespace 2003-05-06 04:58:40 +00:00
Oliver Burn e9b6614e56 Fix Clover link as requested 2003-05-05 04:04:25 +00:00
Oliver Burn beb7953571 Added reference to the new documents 2003-05-05 03:31:18 +00:00
Lars Kühne c14a267b08 added request ID for NewLineAtEOF 2003-05-04 09:55:31 +00:00
Lars Kühne 48761b6091 the config_misc file has become a real mess, restructured it into three documents 2003-05-04 09:54:43 +00:00
Lars Kühne e4eee5699c docs how to contribute to the project 2003-04-30 22:41:08 +00:00
Oliver Burn ff05a6ff5e Patch from Oleg Sukhodolsky to fix documentation. (bug 727896) 2003-04-28 12:28:29 +00:00
Oliver Burn 5ace399de6 Another quality patch from Oleg Sukhodolsky to fix TranslationCheck Test
bug. (bug 720925).
2003-04-24 08:18:53 +00:00
Oliver Burn cd6e8a32d2 Patch from Oleg Sukhodolsky to add MissingSwitchDefaultCheck to check that a
switch statement has a default clause (request 564199).
2003-04-18 11:14:48 +00:00
Lars Kühne 0c913a1b17 resolved HTML syntax errors in documentation (bug 721458) 2003-04-18 09:29:15 +00:00
Lars Kühne c8a0d72210 reset message collector in filesetchecks 2003-04-18 09:12:33 +00:00
Oliver Burn 308d5b0294 Patch from Oleg Sukhodolsky to add FinalCheck to check that classes are
declared final if they only contain private constructors (request 696290).

Quite like the use of the visit/leave token methods.
2003-04-18 08:37:34 +00:00
Lars Kühne 1197b294ce added rfe number to severity level feature 2003-04-18 06:58:44 +00:00
Oliver Burn c822fc497e Max the maximum size more lax. Peter Dobratz did an amazing job documenting
the token types. Ideally would like a way to fine grain the check
2003-04-18 06:52:36 +00:00
Lars Kühne b7f58129fa fixed java sytax error in example 2003-04-18 06:32:57 +00:00
Oliver Burn c69b2f8481 Added SlickEdit reference 2003-04-16 07:19:03 +00:00
Lars Kühne 6520032fd7 added NewLineAtEOF 2003-04-12 14:15:10 +00:00
Lars Kühne 6cbf99acd8 fixed docs of DesignForInheritance, static methods are now ignored 2003-04-11 04:44:18 +00:00
Lars Kühne 002b55c219 added NewlineAtEndOfFile check, contributed by Christopher Lenz 2003-04-06 12:27:55 +00:00
Oliver Burn 29390c5b02 Fix bug 713716: grammar bug defaulting to float and not double. 2003-04-02 11:19:17 +00:00
Lars Kühne 32c3ee46e3 removed the "threadsafe" keyword, fix for bug #710319 2003-03-30 14:58:22 +00:00
Oliver Burn 712a812fdd Fix broken Maven links 2003-03-30 06:41:04 +00:00
Lars Kühne 8f965910b0 added check to detect the double-checked locking idiom, rfe #709333 2003-03-29 17:34:12 +00:00
Lars Kühne ba1663fc94 rfe #528196, task should output version info 2003-03-29 13:39:22 +00:00
Oliver Burn f09c190dff Added support for metadata in the configuration file. This required increasing
the version number to 1.1. I thought this made sense, even though the change
was backwardly compatible.
2003-03-29 00:29:25 +00:00
Oliver Burn d1eb126cae Patch from Peter Dobratz to make the file xhtml compliant. 2003-03-27 12:12:02 +00:00
Oliver Burn 5db3630ded Trying out the new Severity level stuff from Lars. It works really well - I
like it! Not sure about the IGNORE level, as it would be easier to just remove
the Check. But I guess for completeness.
2003-03-27 11:59:03 +00:00
Lars Kühne d216ec7525 Major refactorings to allow the use of SeverityLevels in FileSetChecks
as well as in Checks and to simplify logging of messages in FileSetChecks.

Introduction of a new class called AbstractViolationReporter, from which
both Check and FileSetCheck are derived.

Severity is passed to submodules by means of the Contextualizable
mechanism. This means that the user can f.ex. set severity to INFO
in a TreeWalker and all Checks below that TreeWalker will use severity INFO.
2003-03-26 19:52:30 +00:00
Oliver Burn c0da7e0d0b Just another very useful patch from Peter Dobratz. 2003-03-19 03:48:49 +00:00
Oliver Burn 4cddf4771c Patch from Simon Kitching to allow more configuration control over the
JavadocMethodCheck.
2003-03-11 22:49:58 +00:00
Oliver Burn 093b30843e added how to not use a global classpath 2003-03-07 07:51:28 +00:00
Lars Kühne b5126f45c4 added Peter's documentation improvements 2003-03-02 16:01:06 +00:00
Lars Kühne 51987ba098 fix commandline, patch by Peter Dobratz 2003-03-02 15:58:17 +00:00
Lars Kühne 4af1cc7842 removed obsolete file, it was used to document the engine of version 2 2003-03-02 09:45:36 +00:00
Lars Kühne b99f72832a applied patches by Peter Dobratz to make lintlink happy 2003-03-02 09:35:01 +00:00
Lars Kühne 3f4fdc2743 added xhtml patch by Peter Dobratz 2003-03-01 07:43:19 +00:00
Oliver Burn 5185681ca8 added Clover reference 2003-02-24 06:12:14 +00:00
Lars Kühne 03d9719f47 added request id for InterfaceIsType 2003-02-23 13:29:27 +00:00
Lars Kühne c40ba98dbf added ConfigurationLoader bug + small fixes 2003-02-23 12:42:29 +00:00
Lars Kühne ef2aa379d8 finished the docs for the new checks 2003-02-22 17:00:23 +00:00
Lars Kühne a1f8377ec5 added docs for some new checks, still a few missing 2003-02-20 06:12:41 +00:00
Lars Kühne eb4c8c6ac6 news for 3.1 2003-02-20 06:10:40 +00:00
Lars Kühne 3203ed4840 started documenting all the new checks (help wanted :-) 2003-02-18 06:21:33 +00:00
Lars Kühne 337aa4ec81 started 3.1 2003-02-18 06:20:58 +00:00
Lars Kühne ee4bbbda9d added docs for AvoidNestedBlocks 2003-02-18 05:45:29 +00:00
Oliver Burn cbcc08934f Added reference to the old documentation. 2003-02-17 10:32:10 +00:00
Lars Kühne cee1691008 fixed header style so h4 headers are consistent 2003-02-17 05:27:23 +00:00
Lars Kühne 77d641a916 added example for SimplifyBooleanReturn 2003-02-17 05:21:31 +00:00
Lars Kühne 0b9d1c616f use new helper method to avoid duplicate code 2003-02-15 16:11:28 +00:00
Lars Kühne b5bfd70581 docs for the new fileExtensions property 2003-02-15 12:54:27 +00:00
Lars Kühne 644e610f90 fixed misspelled word, thanks to Paul Roebuck for finding this one 2003-02-11 05:20:58 +00:00
Rick Giles c97f8557e9 corrected default regexp (a Jakarta regexp error?) 2003-02-10 11:50:26 +00:00
Lars Kühne 5dfdce6d5c added example for Translation module, as suggested by Paul Roebuck 2003-02-09 18:44:09 +00:00
Lars Kühne 0251e062ab added docs for configURL attribute 2003-02-08 18:02:17 +00:00
Lars Kühne c8a0d3e6d4 new stylesheet and removal of japanese localization 2003-02-04 20:34:11 +00:00
Oliver Burn 2820c1d09d rfe-652294: added support for specifying file extension for Java files 2003-02-02 01:29:53 +00:00
Oliver Burn 8a717efd15 Added docs for {@inheritDoc} 2003-02-02 01:09:06 +00:00
Lars Kühne ee2e1a5cb3 moved property expansion from api package to private method of ConfigurationLoader (bug #670594)
also added property expansion of ANT properties
2003-01-28 19:56:24 +00:00
Lars Kühne 9d11d6a0b0 incorporated grammar patch contributed by Peter Dobratz 2003-01-28 19:32:37 +00:00
Lars Kühne 4b2f2e628d changed RedundantModifierCheck to allow token configuration and to simplify implementation 2003-01-19 08:01:13 +00:00
Lars Kühne 27cb13ca3d added resolved bug #670321 2003-01-18 17:22:09 +00:00
Lars Kühne ca43a9d7a0 added support for french error messages, contributed by Pierre Dittgen 2003-01-14 05:44:11 +00:00
Lars Kühne 67da95c8a3 added item for fi localazation 2003-01-13 05:49:39 +00:00
Lars Kühne 8809d19699 added item for pt localization 2003-01-12 08:50:23 +00:00
Lars Kühne 6f581fe28d removed old LeftCurly checks 2003-01-12 08:25:37 +00:00
Rick Giles 4a4254b285 Release note for check of space at an empty for interator. 2003-01-11 20:37:19 +00:00
Rick Giles 916417fc62 Check for policy of space at an empty for interator.
Addresses requests 565666, 583725.
ParenPad and WhitespaceAfter no longer check an empty for iterator.
Not doing so, and using check EmptyForIterator, is less complex than
providing properties for ParenPad and WhitespaceAfter.
2003-01-11 20:17:02 +00:00
Lars Kühne 46910b2061 Implement RFE 521323, detect whitespace before ';' 2003-01-11 08:08:28 +00:00
Lars Kühne 151fd548d2 close cachefile streams, fixes bug #655016 2003-01-11 07:42:20 +00:00
Lars Kühne 1eda2807c8 avoid space before option name 2003-01-11 07:34:02 +00:00
Oliver Burn 82470fc576 minor fixes 2003-01-10 06:52:11 +00:00
Lars Kühne 4046ecbdee added Rick's bugfix for 579190 2003-01-09 18:46:58 +00:00
Lars Kühne 4aee8a2213 added fixed bug to 3.0 list 2003-01-08 07:23:47 +00:00
Lars Kühne 36c2e45d44 added XML parser as a requirement - easy to forget when you're running JDK 1.4 2003-01-07 19:35:46 +00:00
Lars Kühne bba4671829 added rfe ids 2003-01-07 19:34:23 +00:00
Lars Kühne 2440fa45b2 removed PublicMemberNameCheck, check public members with MemberNameCheck
updated docs to reflect that change
2002-12-30 14:58:12 +00:00
Lars Kühne a9ad125a4c added entry for bugfix #658805 2002-12-29 10:05:17 +00:00
Lars Kühne 5ce6ad4df6 ModifierCheck to ModifierOrderCheck 2002-12-29 08:46:55 +00:00
Lars Kühne 58ce4c4097 fixed bug #648708, Misleading doc for checkUnusedThrows
Renamed property checkUnusedThrows to allowUndeclaredRTE to better reflect the meaning of the property.
2002-12-27 09:31:33 +00:00
Lars Kühne dc3bffc48f added gui screenshot to writingchecks.html 2002-12-26 16:26:22 +00:00
Rick Giles e1ca997de2 updated links to Checker 2002-12-26 13:36:47 +00:00
Rick Giles 2a24f17202 added docs for Checker and TreeWalker 2002-12-26 13:30:02 +00:00
Lars Kühne 11b2c4e8a9 added meta tag to aid search engines as requested in bug #652835 2002-12-26 08:54:51 +00:00
Rick Giles 58af01acc8 moved property tabWidth 2002-12-25 12:05:32 +00:00
Oliver Burn 5bcb30c9c2 minor tweaks 2002-12-24 04:03:49 +00:00
Oliver Burn 3f96260618 added some links to the api 2002-12-24 03:53:58 +00:00
Oliver Burn c13d2a9d2f Making printer friendly 2002-12-24 03:34:56 +00:00
Oliver Burn b5c434adc2 wordage 2002-12-24 03:31:13 +00:00
Lars Kühne 4591d6cce6 ups, I should concentrate more 2002-12-23 06:15:06 +00:00
Lars Kühne 0c507aa72b added documentation for IllegalInstantiation.classes 2002-12-23 06:13:52 +00:00
Lars Kühne 4979d67612 make it easy for the user to configure sun code conventions 2002-12-22 22:56:48 +00:00
Lars Kühne eb0e9d478c added DOCTYPE declaration and fixed document structure 2002-12-22 22:45:26 +00:00
Lars Kühne 333be33007 added check for tab characters 2002-12-22 12:20:51 +00:00
Lars Kühne e3c72076fd added required jars.
We should add some version info, but I don't know what exactly is required.
2002-12-22 12:08:45 +00:00
Rick Giles 62be57af36 Minor spelling correction 2002-12-22 12:00:20 +00:00
Lars Kühne b0dfa0580b fixed minor spelling error 2002-12-22 11:54:10 +00:00
Lars Kühne 966f7cc5eb create correct version number 2002-12-22 11:50:28 +00:00
Lars Kühne 194f604d1a added 3rd party tools from current home page
replaced upgrade procedure
2002-12-22 11:29:16 +00:00
Rick Giles 227f634b85 Minor edit changes. It's a great developer-to-developer read. 2002-12-22 11:18:58 +00:00
Lars Kühne 694549424d link to config.html as Rick suggested 2002-12-22 09:41:45 +00:00
Lars Kühne 2674c0cb24 VisibilityModifier didn't have the set of allowed names that were mentioned in the docs,
which is OK since that can be done by pattern matching.
Replaced the f-pattern with serialVersionUID and fixed the docs and tests accordingly.
2002-12-22 08:34:45 +00:00
Rick Giles 74342723b7 AvoidStarImport documentation 2002-12-21 17:00:07 +00:00
Rick Giles ae448434e9 XHTML validated 2002-12-21 11:16:59 +00:00
Rick Giles 3f3e33ccfa version 3.0 documentation.
please double-check examples.
unvalidated - validator site is currently unavailable.
2002-12-20 13:30:15 +00:00
Rick Giles 76f87ceec9 added to Package Names.
"Writing Checks - Integrating your Check" could have a link to this.
2002-12-20 11:00:11 +00:00
Lars Kühne 0b6e44780f made this a sample configuration file that enforces everything I could find
in Sun docs plus a few best practices
2002-12-20 06:39:40 +00:00
Lars Kühne 4b4fee6d47 added integration and fixed a few minor issues 2002-12-19 22:20:52 +00:00
Rick Giles d66b4752df added Parent Module links 2002-12-19 18:58:39 +00:00
Rick Giles e16a7d7872 huh? spellchecker magic? 2002-12-19 18:34:47 +00:00
Rick Giles 3f437ea751 added package names XML document 2002-12-19 18:11:26 +00:00
Rick Giles 67f9f881a6 version 3.0 documentation 2002-12-19 17:09:29 +00:00
Rick Giles 1ad759e6e7 LeftCurly docs.
Have completed a first pass of all checks - almost as much fun as
marking exams.
2002-12-19 11:14:45 +00:00
Rick Giles f1d485ff49 configure for LeftCurly 2002-12-19 11:01:13 +00:00
Rick Giles 55df1e950d version 3.0 documentation 2002-12-19 10:52:55 +00:00
Rick Giles 8ccfddcd2d version 3.0 documentation and minor corrections 2002-12-19 00:04:37 +00:00
Rick Giles 5231c6334c version 3.0 documentation and minor changes 2002-12-18 20:59:58 +00:00
Rick Giles c803de8b13 version 3.0 documentation 2002-12-18 18:05:35 +00:00
Rick Giles 3411c89f4c Removed redundant configuration 2002-12-18 16:17:50 +00:00
Rick Giles b69da28d37 added RedundantImport 2002-12-18 15:17:56 +00:00
Rick Giles ab335def94 version 3.0 documentation 2002-12-18 14:37:18 +00:00
Rick Giles 86d25d78aa Removed "acceptable" adjective" for tokens 2002-12-18 11:04:53 +00:00
Rick Giles db76ce4905 Removed "acceptable" adjective for a Check's tokens.
Spelling corrections.
2002-12-18 09:43:32 +00:00
Rick Giles 0f53fe215f version 3.0 documentation 2002-12-18 00:56:19 +00:00
Lars Kühne 71b822ec3a lots of stuff added 2002-12-17 23:02:02 +00:00
Rick Giles e56a2c1543 version 3.0 documentation 2002-12-17 21:53:21 +00:00
Rick Giles a1518aee35 Removed reference to "default tokens" - just confuses the issue. 2002-12-17 20:55:12 +00:00
Rick Giles 9b84d05630 Added section XML Details.
XHTML validated.
Ready for "proof-reading"...
2002-12-17 19:25:11 +00:00
Rick Giles 94b4bfc10f added section Treewalker Checks 2002-12-17 12:14:27 +00:00
Rick Giles 0fc6f9aad0 Properties section. 2002-12-17 00:12:53 +00:00
Rick Giles 9086d3588a Modules section 2002-12-16 17:10:43 +00:00
Rick Giles 4cc94a581c dropped suffix "Check" 2002-12-16 00:57:03 +00:00
Rick Giles 4564aecb5c Changed configuration XML element "config" to "module".
Dropped suffix "Check" in Check configurations.
2002-12-16 00:22:14 +00:00
Rick Giles 04483a77e8 Start on Configuration documentation. 2002-12-15 15:59:26 +00:00
Lars Kühne 469acd6705 fixed more typos 2002-12-15 12:30:02 +00:00
Rick Giles 39d8deed5d Added FileLengthCheck.
Improved defaults for tokens property.
Removed "Check" from config names in XML.
Will start overview next.
2002-12-15 12:26:29 +00:00
Lars Kühne 9117c94188 changed order of Checks/FileSetChecks chapters
fixed typos
2002-12-15 12:26:17 +00:00
Rick Giles c4a1f37d6a prototype for v. 3 check documentation
Comments? Should it be continued for other categories?
Help - What to say about tokens?
Note that MethodLengthCheck documentation has property ignorePattern -
could be a good thing for ignoring comments and blank lines. Should it be
implemented?
2002-12-14 12:39:49 +00:00
Lars Kühne 298563ba53 small additions 2002-12-14 10:45:10 +00:00
Rick Giles 03a5b03421 DTD for XMLLogger output 2002-12-13 15:37:26 +00:00
Lars Kühne 4bbae6fd46 added intro and FileSetChecks chapter. Not sure that FileSetCheck chapter
is at the right position, it's hard to understand the example without the
i18n chapter in Checks. I'll think about having the Checks chapter first.
2002-12-13 06:56:21 +00:00
Rick Giles b25fe8281b restore original LineLengthCheck ignorePattern property 2002-12-12 11:39:05 +00:00
Lars Kühne af34ba7204 started 'visitors in action' 2002-12-12 06:12:47 +00:00
Oliver Burn 12acba75f4 hopefully fix problems people have been having with encoding 2002-12-12 02:22:05 +00:00
Lars Kühne 677eab6dc3 Logging errors chapter 2002-12-11 07:02:29 +00:00
Lars Kühne a8fb948d68 gui chapter 2002-12-11 06:01:09 +00:00
Rick Giles 9dd70608be ignorePattern "^ *\* *[^ ]+$" is too restrictive.
Is there a better one?
2002-12-11 00:44:32 +00:00
Lars Kühne 29a657abe3 grammar chapter 2002-12-10 21:54:32 +00:00
Lars Kühne b91ba2c137 started writing a 'how to write a check' document 2002-12-10 21:23:27 +00:00
Rick Giles 9e27ad14fe XHTML-ized and CSS validated 2002-12-10 13:57:45 +00:00
Lars Kühne b852b1bad4 fixed Ville's last name and added HiddenFieldCheck to new features 2002-12-10 05:58:36 +00:00
Rick Giles 294da7f458 attempt to correct "Skyttä" 2002-12-10 01:00:17 +00:00
Rick Giles 9523899ac0 minor spelling correction 2002-12-10 00:43:20 +00:00
Lars Kühne f1e8474f25 added releasenotes for release 3.0, please check that I did not forget anything 2002-12-08 14:21:34 +00:00
Oliver Burn 8dd310c982 Changes to get the header check going again. I like the
change that was made for the properties, it leverages
off the work we did in the 2.4 release to allow properties
to be overriden in the ANT file.
It is now possible to run the checkstyle task from any
directory - nothing is now location specific. This includes
the location of the header file or the DTDs. Good to
finally reach this milestone.
2002-12-07 12:18:57 +00:00
Oliver Burn 9646bb8505 Not used anymore - that is a legacy file. 2002-12-07 12:16:48 +00:00
Rick Giles 730ade67d5 changed to regular expressions for @author and @version tags
- thanks to Lars for suggestion
2002-12-07 12:02:32 +00:00
Oliver Burn 12231e14b8 Changed the loading of package names to use the new
technique used by the configuration loader. So this means
that all the XML files are now validated against a DTD.
2002-12-07 09:51:33 +00:00
Oliver Burn 2386d3e852 Implemented proper error handling for parse errors. 2002-12-07 07:09:13 +00:00
Oliver Burn 52fa475168 Changed to make the XML be validated using the DTD. The
DTD is located using a technique that gets it from the JAR
file. Idea "borrowed" from Struts.
2002-12-07 03:28:36 +00:00
Oliver Burn d287d70b77 Cool! Used the ignoreFormat property to fix up checkstyle errors. Very nice. 2002-12-06 23:56:37 +00:00
Rick Giles 3088559eda start on real DTD incorporation 2002-12-06 16:15:08 +00:00
Rick Giles 88f46c600c start on real DTD incorporation 2002-12-06 16:04:58 +00:00
Rick Giles c98995d134 updated DTD 2002-12-06 15:40:41 +00:00
Oliver Burn 1b7dd85b3f Finish the conversion job. 2002-12-06 06:31:06 +00:00
Rick Giles 5f0d69b64d included OperatorWrapCheck with assignment tokens, now that
BeanUtils conversion of String arrays has been remedied.
2002-12-05 23:51:20 +00:00
Rick Giles 16ba5b35f9 modified for config XML and mapping names to full class names - see
posting to checkstyle-devel@lists.sourceforge.net
2002-12-05 18:54:28 +00:00
Oliver Burn a9d73e7c59 Commented out the header check 2002-11-26 06:04:45 +00:00
Oliver Burn 3e5b819aa9 Added a parameter to the HeaderCheck to actually
specify a file. Unfortunately this is relative and hence can
only be used from the root directory. Will uncomment in
a minute.
2002-11-26 05:58:22 +00:00
Oliver Burn d0b47d4be4 A working version - now to compare to ours...... 2002-11-25 01:10:46 +00:00
Oliver Burn 934ea59e7e Removed bad checks 2002-11-25 01:05:07 +00:00
Oliver Burn f7705b69c6 Work in progress to build a complete set 2002-11-25 00:55:22 +00:00
Oliver Burn bed61e1afd Fix indentation 2002-11-25 00:42:52 +00:00
Oliver Burn 91aa657832 putting back the checkstyle settings back and now getting 67 odd errors. :-( 2002-11-22 12:37:00 +00:00
Rick Giles cf7e4c19e3 renamed XML element "set-property" to "property" 2002-11-18 10:03:05 +00:00
Rick Giles 3c0608f33a Wrapped GlobalProperties and CheckConfiguration[] into a Configuration
class. TODO: Integrate with CheckStyleTask
2002-11-15 18:18:52 +00:00
Rick Giles 4a638fc0e6 Added global-property to DTD.
Removed DTD from XML file until fix of ConfigurationLoader
2002-11-14 10:10:27 +00:00
Rick Giles 6f36f2811d added DTD for checkstyle configuration 2002-11-12 23:20:51 +00:00
Rick Giles 7fb81fdf90 added WhitespaceAfterCheck 2002-11-11 11:54:06 +00:00
Rick Giles 9eb9d9b3ea replaced NoWhiteSpaceAroundCheck by NoWhitespaceAfterCheck and
NoWhitespaceBeforeCheck
2002-11-10 20:48:33 +00:00
Rick Giles bed446244a added NoWhitespaceBefore, NoWhitespaceAfter checks 2002-11-10 20:35:13 +00:00
Rick Giles 333e944de5 added check for wrap of assignment operators at eol 2002-11-10 19:45:25 +00:00
Rick Giles ecaaaeb254 added operator wrap check 2002-11-09 20:24:22 +00:00
Oliver Burn 5fc3ff2bfb Please ensure you thoroughly test code before committing it. As a sanity test,
ensure that the target "checkstyle.checkstyle" will run! If in doubt, do not
commit, but instead said a patch to the devel mailing list for a review.

Finished the port of the ClassResolver code. Even though it compiled, it had
no chance of working due to class casting problems. They have not been
fixed. Also needed to ensure the correct class loader is being used.
2002-11-06 03:57:58 +00:00
Oliver Burn 93bba09f70 Wanting to turn on the check - but it fails. Need to resolve as it is most
likely to be a classpath issue.
2002-11-06 00:14:40 +00:00
Rick Giles 3bcc2c1391 update for JavadocMethodCheck 2002-11-05 20:39:56 +00:00
Oliver Burn fb97056b9b Fixed bug in MethodLeftCurlyCheck where it did not handle interfaces and
abstract methods.
2002-11-03 12:06:15 +00:00
Oliver Burn 4945b82e6d Folded the constructor length test into the method length check. Seems silly
to have them as separate checks.
2002-11-03 02:37:20 +00:00
Oliver Burn ba8a851e90 Fixed bug in MethodLengthCheck where it was assuming that a method definition
had to have braces. Not the case for interfaces and abstract methods. Need to
make the same change to the other method check.
2002-11-03 02:14:07 +00:00
Oliver Burn 3288a81e30 Just converted over the Checkstyle ANT task to use the new framework. In
process I had to fix numerous errors now being reported.

There are some bugs with the method checks, which I will now investigate.
2002-11-02 12:22:14 +00:00