Commit Graph

607 Commits

Author SHA1 Message Date
Lars Kühne bf6758b29d documentation improvements from Peter Dobratz 2003-05-11 07:31:23 +00:00
Rick Giles b59648d605 Added line and column numbers to configuration parse exceptions
(request 714962).
2003-05-10 15:17:54 +00:00
Rick Giles 61e6ce5ee7 Added "source" attribute to "error" element of XMLLogger output. 2003-05-10 10:59:20 +00:00
Oleg Sukhodolsky 4e1f8ef98e One more option for JavadocMethodCheck
(allowThrowsTagsForSubclasses, request 540383)
2003-05-09 18:14:25 +00:00
Rick Giles 40e9a0a4ea moved bug fix to correct release number (3.1) 2003-05-09 13:24:56 +00:00
Rick Giles 5156e90846 noted resolved bug 713845 2003-05-08 12:48:04 +00:00
Rick Giles fdc9cc3713 added item for MagicNumberCheck 2003-05-07 17:11:56 +00:00
Rick Giles 7284e8aa42 magic number check. RFE 564206 2003-05-07 16:57:32 +00:00
Lars Kühne 9a9e7318a3 added note for empty statement check
Oleg has joined the team
2003-05-06 05:40:43 +00:00
Lars Kühne ebc06c9c2e added docs for EmptyStatement 2003-05-06 05:34:49 +00:00
Lars Kühne 4c1197e35d added comments for the regexp values 2003-05-06 05:09:30 +00:00
Lars Kühne a2e58a8d5f added example for finding trailing whitespace 2003-05-06 04:58:40 +00:00
Oliver Burn e9b6614e56 Fix Clover link as requested 2003-05-05 04:04:25 +00:00
Oliver Burn beb7953571 Added reference to the new documents 2003-05-05 03:31:18 +00:00
Lars Kühne c14a267b08 added request ID for NewLineAtEOF 2003-05-04 09:55:31 +00:00
Lars Kühne 48761b6091 the config_misc file has become a real mess, restructured it into three documents 2003-05-04 09:54:43 +00:00
Lars Kühne e4eee5699c docs how to contribute to the project 2003-04-30 22:41:08 +00:00
Oliver Burn ff05a6ff5e Patch from Oleg Sukhodolsky to fix documentation. (bug 727896) 2003-04-28 12:28:29 +00:00
Oliver Burn 5ace399de6 Another quality patch from Oleg Sukhodolsky to fix TranslationCheck Test
bug. (bug 720925).
2003-04-24 08:18:53 +00:00
Oliver Burn cd6e8a32d2 Patch from Oleg Sukhodolsky to add MissingSwitchDefaultCheck to check that a
switch statement has a default clause (request 564199).
2003-04-18 11:14:48 +00:00
Lars Kühne 0c913a1b17 resolved HTML syntax errors in documentation (bug 721458) 2003-04-18 09:29:15 +00:00
Lars Kühne c8a0d72210 reset message collector in filesetchecks 2003-04-18 09:12:33 +00:00
Oliver Burn 308d5b0294 Patch from Oleg Sukhodolsky to add FinalCheck to check that classes are
declared final if they only contain private constructors (request 696290).

Quite like the use of the visit/leave token methods.
2003-04-18 08:37:34 +00:00
Lars Kühne 1197b294ce added rfe number to severity level feature 2003-04-18 06:58:44 +00:00
Oliver Burn c822fc497e Max the maximum size more lax. Peter Dobratz did an amazing job documenting
the token types. Ideally would like a way to fine grain the check
2003-04-18 06:52:36 +00:00
Lars Kühne b7f58129fa fixed java sytax error in example 2003-04-18 06:32:57 +00:00
Oliver Burn c69b2f8481 Added SlickEdit reference 2003-04-16 07:19:03 +00:00
Lars Kühne 6520032fd7 added NewLineAtEOF 2003-04-12 14:15:10 +00:00
Lars Kühne 6cbf99acd8 fixed docs of DesignForInheritance, static methods are now ignored 2003-04-11 04:44:18 +00:00
Lars Kühne 002b55c219 added NewlineAtEndOfFile check, contributed by Christopher Lenz 2003-04-06 12:27:55 +00:00
Oliver Burn 29390c5b02 Fix bug 713716: grammar bug defaulting to float and not double. 2003-04-02 11:19:17 +00:00
Lars Kühne 32c3ee46e3 removed the "threadsafe" keyword, fix for bug #710319 2003-03-30 14:58:22 +00:00
Oliver Burn 712a812fdd Fix broken Maven links 2003-03-30 06:41:04 +00:00
Lars Kühne 8f965910b0 added check to detect the double-checked locking idiom, rfe #709333 2003-03-29 17:34:12 +00:00
Lars Kühne ba1663fc94 rfe #528196, task should output version info 2003-03-29 13:39:22 +00:00
Oliver Burn f09c190dff Added support for metadata in the configuration file. This required increasing
the version number to 1.1. I thought this made sense, even though the change
was backwardly compatible.
2003-03-29 00:29:25 +00:00
Oliver Burn d1eb126cae Patch from Peter Dobratz to make the file xhtml compliant. 2003-03-27 12:12:02 +00:00
Oliver Burn 5db3630ded Trying out the new Severity level stuff from Lars. It works really well - I
like it! Not sure about the IGNORE level, as it would be easier to just remove
the Check. But I guess for completeness.
2003-03-27 11:59:03 +00:00
Lars Kühne d216ec7525 Major refactorings to allow the use of SeverityLevels in FileSetChecks
as well as in Checks and to simplify logging of messages in FileSetChecks.

Introduction of a new class called AbstractViolationReporter, from which
both Check and FileSetCheck are derived.

Severity is passed to submodules by means of the Contextualizable
mechanism. This means that the user can f.ex. set severity to INFO
in a TreeWalker and all Checks below that TreeWalker will use severity INFO.
2003-03-26 19:52:30 +00:00
Oliver Burn c0da7e0d0b Just another very useful patch from Peter Dobratz. 2003-03-19 03:48:49 +00:00
Oliver Burn 4cddf4771c Patch from Simon Kitching to allow more configuration control over the
JavadocMethodCheck.
2003-03-11 22:49:58 +00:00
Oliver Burn 093b30843e added how to not use a global classpath 2003-03-07 07:51:28 +00:00
Lars Kühne b5126f45c4 added Peter's documentation improvements 2003-03-02 16:01:06 +00:00
Lars Kühne 51987ba098 fix commandline, patch by Peter Dobratz 2003-03-02 15:58:17 +00:00
Lars Kühne 4af1cc7842 removed obsolete file, it was used to document the engine of version 2 2003-03-02 09:45:36 +00:00
Lars Kühne b99f72832a applied patches by Peter Dobratz to make lintlink happy 2003-03-02 09:35:01 +00:00
Lars Kühne 3f4fdc2743 added xhtml patch by Peter Dobratz 2003-03-01 07:43:19 +00:00
Oliver Burn 5185681ca8 added Clover reference 2003-02-24 06:12:14 +00:00
Lars Kühne 03d9719f47 added request id for InterfaceIsType 2003-02-23 13:29:27 +00:00
Lars Kühne c40ba98dbf added ConfigurationLoader bug + small fixes 2003-02-23 12:42:29 +00:00
Lars Kühne ef2aa379d8 finished the docs for the new checks 2003-02-22 17:00:23 +00:00
Lars Kühne a1f8377ec5 added docs for some new checks, still a few missing 2003-02-20 06:12:41 +00:00
Lars Kühne eb4c8c6ac6 news for 3.1 2003-02-20 06:10:40 +00:00
Lars Kühne 3203ed4840 started documenting all the new checks (help wanted :-) 2003-02-18 06:21:33 +00:00
Lars Kühne 337aa4ec81 started 3.1 2003-02-18 06:20:58 +00:00
Lars Kühne ee4bbbda9d added docs for AvoidNestedBlocks 2003-02-18 05:45:29 +00:00
Oliver Burn cbcc08934f Added reference to the old documentation. 2003-02-17 10:32:10 +00:00
Lars Kühne cee1691008 fixed header style so h4 headers are consistent 2003-02-17 05:27:23 +00:00
Lars Kühne 77d641a916 added example for SimplifyBooleanReturn 2003-02-17 05:21:31 +00:00
Lars Kühne 0b9d1c616f use new helper method to avoid duplicate code 2003-02-15 16:11:28 +00:00
Lars Kühne b5bfd70581 docs for the new fileExtensions property 2003-02-15 12:54:27 +00:00
Lars Kühne 644e610f90 fixed misspelled word, thanks to Paul Roebuck for finding this one 2003-02-11 05:20:58 +00:00
Rick Giles c97f8557e9 corrected default regexp (a Jakarta regexp error?) 2003-02-10 11:50:26 +00:00
Lars Kühne 5dfdce6d5c added example for Translation module, as suggested by Paul Roebuck 2003-02-09 18:44:09 +00:00
Lars Kühne 0251e062ab added docs for configURL attribute 2003-02-08 18:02:17 +00:00
Lars Kühne c8a0d3e6d4 new stylesheet and removal of japanese localization 2003-02-04 20:34:11 +00:00
Oliver Burn 2820c1d09d rfe-652294: added support for specifying file extension for Java files 2003-02-02 01:29:53 +00:00
Oliver Burn 8a717efd15 Added docs for {@inheritDoc} 2003-02-02 01:09:06 +00:00
Lars Kühne ee2e1a5cb3 moved property expansion from api package to private method of ConfigurationLoader (bug #670594)
also added property expansion of ANT properties
2003-01-28 19:56:24 +00:00
Lars Kühne 9d11d6a0b0 incorporated grammar patch contributed by Peter Dobratz 2003-01-28 19:32:37 +00:00
Lars Kühne 4b2f2e628d changed RedundantModifierCheck to allow token configuration and to simplify implementation 2003-01-19 08:01:13 +00:00
Lars Kühne 27cb13ca3d added resolved bug #670321 2003-01-18 17:22:09 +00:00
Lars Kühne ca43a9d7a0 added support for french error messages, contributed by Pierre Dittgen 2003-01-14 05:44:11 +00:00
Lars Kühne 67da95c8a3 added item for fi localazation 2003-01-13 05:49:39 +00:00
Lars Kühne 8809d19699 added item for pt localization 2003-01-12 08:50:23 +00:00
Lars Kühne 6f581fe28d removed old LeftCurly checks 2003-01-12 08:25:37 +00:00
Rick Giles 4a4254b285 Release note for check of space at an empty for interator. 2003-01-11 20:37:19 +00:00
Rick Giles 916417fc62 Check for policy of space at an empty for interator.
Addresses requests 565666, 583725.
ParenPad and WhitespaceAfter no longer check an empty for iterator.
Not doing so, and using check EmptyForIterator, is less complex than
providing properties for ParenPad and WhitespaceAfter.
2003-01-11 20:17:02 +00:00
Lars Kühne 46910b2061 Implement RFE 521323, detect whitespace before ';' 2003-01-11 08:08:28 +00:00
Lars Kühne 151fd548d2 close cachefile streams, fixes bug #655016 2003-01-11 07:42:20 +00:00
Lars Kühne 1eda2807c8 avoid space before option name 2003-01-11 07:34:02 +00:00
Oliver Burn 82470fc576 minor fixes 2003-01-10 06:52:11 +00:00
Lars Kühne 4046ecbdee added Rick's bugfix for 579190 2003-01-09 18:46:58 +00:00
Lars Kühne 4aee8a2213 added fixed bug to 3.0 list 2003-01-08 07:23:47 +00:00
Lars Kühne 36c2e45d44 added XML parser as a requirement - easy to forget when you're running JDK 1.4 2003-01-07 19:35:46 +00:00
Lars Kühne bba4671829 added rfe ids 2003-01-07 19:34:23 +00:00
Lars Kühne 2440fa45b2 removed PublicMemberNameCheck, check public members with MemberNameCheck
updated docs to reflect that change
2002-12-30 14:58:12 +00:00
Lars Kühne a9ad125a4c added entry for bugfix #658805 2002-12-29 10:05:17 +00:00
Lars Kühne 5ce6ad4df6 ModifierCheck to ModifierOrderCheck 2002-12-29 08:46:55 +00:00
Lars Kühne 58ce4c4097 fixed bug #648708, Misleading doc for checkUnusedThrows
Renamed property checkUnusedThrows to allowUndeclaredRTE to better reflect the meaning of the property.
2002-12-27 09:31:33 +00:00
Lars Kühne dc3bffc48f added gui screenshot to writingchecks.html 2002-12-26 16:26:22 +00:00
Rick Giles e1ca997de2 updated links to Checker 2002-12-26 13:36:47 +00:00
Rick Giles 2a24f17202 added docs for Checker and TreeWalker 2002-12-26 13:30:02 +00:00
Lars Kühne 11b2c4e8a9 added meta tag to aid search engines as requested in bug #652835 2002-12-26 08:54:51 +00:00
Rick Giles 58af01acc8 moved property tabWidth 2002-12-25 12:05:32 +00:00
Oliver Burn 5bcb30c9c2 minor tweaks 2002-12-24 04:03:49 +00:00
Oliver Burn 3f96260618 added some links to the api 2002-12-24 03:53:58 +00:00
Oliver Burn c13d2a9d2f Making printer friendly 2002-12-24 03:34:56 +00:00
Oliver Burn b5c434adc2 wordage 2002-12-24 03:31:13 +00:00
Lars Kühne 4591d6cce6 ups, I should concentrate more 2002-12-23 06:15:06 +00:00
Lars Kühne 0c507aa72b added documentation for IllegalInstantiation.classes 2002-12-23 06:13:52 +00:00
Lars Kühne 4979d67612 make it easy for the user to configure sun code conventions 2002-12-22 22:56:48 +00:00
Lars Kühne eb0e9d478c added DOCTYPE declaration and fixed document structure 2002-12-22 22:45:26 +00:00
Lars Kühne 333be33007 added check for tab characters 2002-12-22 12:20:51 +00:00
Lars Kühne e3c72076fd added required jars.
We should add some version info, but I don't know what exactly is required.
2002-12-22 12:08:45 +00:00
Rick Giles 62be57af36 Minor spelling correction 2002-12-22 12:00:20 +00:00
Lars Kühne b0dfa0580b fixed minor spelling error 2002-12-22 11:54:10 +00:00
Lars Kühne 966f7cc5eb create correct version number 2002-12-22 11:50:28 +00:00
Lars Kühne 194f604d1a added 3rd party tools from current home page
replaced upgrade procedure
2002-12-22 11:29:16 +00:00
Rick Giles 227f634b85 Minor edit changes. It's a great developer-to-developer read. 2002-12-22 11:18:58 +00:00
Lars Kühne 694549424d link to config.html as Rick suggested 2002-12-22 09:41:45 +00:00
Lars Kühne 2674c0cb24 VisibilityModifier didn't have the set of allowed names that were mentioned in the docs,
which is OK since that can be done by pattern matching.
Replaced the f-pattern with serialVersionUID and fixed the docs and tests accordingly.
2002-12-22 08:34:45 +00:00
Rick Giles 74342723b7 AvoidStarImport documentation 2002-12-21 17:00:07 +00:00
Rick Giles ae448434e9 XHTML validated 2002-12-21 11:16:59 +00:00
Rick Giles 3f3e33ccfa version 3.0 documentation.
please double-check examples.
unvalidated - validator site is currently unavailable.
2002-12-20 13:30:15 +00:00
Rick Giles 76f87ceec9 added to Package Names.
"Writing Checks - Integrating your Check" could have a link to this.
2002-12-20 11:00:11 +00:00
Lars Kühne 0b6e44780f made this a sample configuration file that enforces everything I could find
in Sun docs plus a few best practices
2002-12-20 06:39:40 +00:00
Lars Kühne 4b4fee6d47 added integration and fixed a few minor issues 2002-12-19 22:20:52 +00:00
Rick Giles d66b4752df added Parent Module links 2002-12-19 18:58:39 +00:00
Rick Giles e16a7d7872 huh? spellchecker magic? 2002-12-19 18:34:47 +00:00
Rick Giles 3f437ea751 added package names XML document 2002-12-19 18:11:26 +00:00
Rick Giles 67f9f881a6 version 3.0 documentation 2002-12-19 17:09:29 +00:00
Rick Giles 1ad759e6e7 LeftCurly docs.
Have completed a first pass of all checks - almost as much fun as
marking exams.
2002-12-19 11:14:45 +00:00
Rick Giles f1d485ff49 configure for LeftCurly 2002-12-19 11:01:13 +00:00
Rick Giles 55df1e950d version 3.0 documentation 2002-12-19 10:52:55 +00:00
Rick Giles 8ccfddcd2d version 3.0 documentation and minor corrections 2002-12-19 00:04:37 +00:00
Rick Giles 5231c6334c version 3.0 documentation and minor changes 2002-12-18 20:59:58 +00:00
Rick Giles c803de8b13 version 3.0 documentation 2002-12-18 18:05:35 +00:00
Rick Giles 3411c89f4c Removed redundant configuration 2002-12-18 16:17:50 +00:00
Rick Giles b69da28d37 added RedundantImport 2002-12-18 15:17:56 +00:00
Rick Giles ab335def94 version 3.0 documentation 2002-12-18 14:37:18 +00:00
Rick Giles 86d25d78aa Removed "acceptable" adjective" for tokens 2002-12-18 11:04:53 +00:00
Rick Giles db76ce4905 Removed "acceptable" adjective for a Check's tokens.
Spelling corrections.
2002-12-18 09:43:32 +00:00
Rick Giles 0f53fe215f version 3.0 documentation 2002-12-18 00:56:19 +00:00
Lars Kühne 71b822ec3a lots of stuff added 2002-12-17 23:02:02 +00:00
Rick Giles e56a2c1543 version 3.0 documentation 2002-12-17 21:53:21 +00:00
Rick Giles a1518aee35 Removed reference to "default tokens" - just confuses the issue. 2002-12-17 20:55:12 +00:00
Rick Giles 9b84d05630 Added section XML Details.
XHTML validated.
Ready for "proof-reading"...
2002-12-17 19:25:11 +00:00
Rick Giles 94b4bfc10f added section Treewalker Checks 2002-12-17 12:14:27 +00:00
Rick Giles 0fc6f9aad0 Properties section. 2002-12-17 00:12:53 +00:00
Rick Giles 9086d3588a Modules section 2002-12-16 17:10:43 +00:00
Rick Giles 4cc94a581c dropped suffix "Check" 2002-12-16 00:57:03 +00:00
Rick Giles 4564aecb5c Changed configuration XML element "config" to "module".
Dropped suffix "Check" in Check configurations.
2002-12-16 00:22:14 +00:00
Rick Giles 04483a77e8 Start on Configuration documentation. 2002-12-15 15:59:26 +00:00
Lars Kühne 469acd6705 fixed more typos 2002-12-15 12:30:02 +00:00
Rick Giles 39d8deed5d Added FileLengthCheck.
Improved defaults for tokens property.
Removed "Check" from config names in XML.
Will start overview next.
2002-12-15 12:26:29 +00:00
Lars Kühne 9117c94188 changed order of Checks/FileSetChecks chapters
fixed typos
2002-12-15 12:26:17 +00:00
Rick Giles c4a1f37d6a prototype for v. 3 check documentation
Comments? Should it be continued for other categories?
Help - What to say about tokens?
Note that MethodLengthCheck documentation has property ignorePattern -
could be a good thing for ignoring comments and blank lines. Should it be
implemented?
2002-12-14 12:39:49 +00:00
Lars Kühne 298563ba53 small additions 2002-12-14 10:45:10 +00:00
Rick Giles 03a5b03421 DTD for XMLLogger output 2002-12-13 15:37:26 +00:00
Lars Kühne 4bbae6fd46 added intro and FileSetChecks chapter. Not sure that FileSetCheck chapter
is at the right position, it's hard to understand the example without the
i18n chapter in Checks. I'll think about having the Checks chapter first.
2002-12-13 06:56:21 +00:00
Rick Giles b25fe8281b restore original LineLengthCheck ignorePattern property 2002-12-12 11:39:05 +00:00
Lars Kühne af34ba7204 started 'visitors in action' 2002-12-12 06:12:47 +00:00
Oliver Burn 12acba75f4 hopefully fix problems people have been having with encoding 2002-12-12 02:22:05 +00:00
Lars Kühne 677eab6dc3 Logging errors chapter 2002-12-11 07:02:29 +00:00
Lars Kühne a8fb948d68 gui chapter 2002-12-11 06:01:09 +00:00
Rick Giles 9dd70608be ignorePattern "^ *\* *[^ ]+$" is too restrictive.
Is there a better one?
2002-12-11 00:44:32 +00:00
Lars Kühne 29a657abe3 grammar chapter 2002-12-10 21:54:32 +00:00
Lars Kühne b91ba2c137 started writing a 'how to write a check' document 2002-12-10 21:23:27 +00:00
Rick Giles 9e27ad14fe XHTML-ized and CSS validated 2002-12-10 13:57:45 +00:00
Lars Kühne b852b1bad4 fixed Ville's last name and added HiddenFieldCheck to new features 2002-12-10 05:58:36 +00:00
Rick Giles 294da7f458 attempt to correct "Skyttä" 2002-12-10 01:00:17 +00:00
Rick Giles 9523899ac0 minor spelling correction 2002-12-10 00:43:20 +00:00
Lars Kühne f1e8474f25 added releasenotes for release 3.0, please check that I did not forget anything 2002-12-08 14:21:34 +00:00
Oliver Burn 8dd310c982 Changes to get the header check going again. I like the
change that was made for the properties, it leverages
off the work we did in the 2.4 release to allow properties
to be overriden in the ANT file.
It is now possible to run the checkstyle task from any
directory - nothing is now location specific. This includes
the location of the header file or the DTDs. Good to
finally reach this milestone.
2002-12-07 12:18:57 +00:00
Oliver Burn 9646bb8505 Not used anymore - that is a legacy file. 2002-12-07 12:16:48 +00:00
Rick Giles 730ade67d5 changed to regular expressions for @author and @version tags
- thanks to Lars for suggestion
2002-12-07 12:02:32 +00:00
Oliver Burn 12231e14b8 Changed the loading of package names to use the new
technique used by the configuration loader. So this means
that all the XML files are now validated against a DTD.
2002-12-07 09:51:33 +00:00
Oliver Burn 2386d3e852 Implemented proper error handling for parse errors. 2002-12-07 07:09:13 +00:00
Oliver Burn 52fa475168 Changed to make the XML be validated using the DTD. The
DTD is located using a technique that gets it from the JAR
file. Idea "borrowed" from Struts.
2002-12-07 03:28:36 +00:00
Oliver Burn d287d70b77 Cool! Used the ignoreFormat property to fix up checkstyle errors. Very nice. 2002-12-06 23:56:37 +00:00
Rick Giles 3088559eda start on real DTD incorporation 2002-12-06 16:15:08 +00:00
Rick Giles 88f46c600c start on real DTD incorporation 2002-12-06 16:04:58 +00:00
Rick Giles c98995d134 updated DTD 2002-12-06 15:40:41 +00:00
Oliver Burn 1b7dd85b3f Finish the conversion job. 2002-12-06 06:31:06 +00:00
Rick Giles 5f0d69b64d included OperatorWrapCheck with assignment tokens, now that
BeanUtils conversion of String arrays has been remedied.
2002-12-05 23:51:20 +00:00
Rick Giles 16ba5b35f9 modified for config XML and mapping names to full class names - see
posting to checkstyle-devel@lists.sourceforge.net
2002-12-05 18:54:28 +00:00
Oliver Burn a9d73e7c59 Commented out the header check 2002-11-26 06:04:45 +00:00
Oliver Burn 3e5b819aa9 Added a parameter to the HeaderCheck to actually
specify a file. Unfortunately this is relative and hence can
only be used from the root directory. Will uncomment in
a minute.
2002-11-26 05:58:22 +00:00
Oliver Burn d0b47d4be4 A working version - now to compare to ours...... 2002-11-25 01:10:46 +00:00
Oliver Burn 934ea59e7e Removed bad checks 2002-11-25 01:05:07 +00:00
Oliver Burn f7705b69c6 Work in progress to build a complete set 2002-11-25 00:55:22 +00:00
Oliver Burn bed61e1afd Fix indentation 2002-11-25 00:42:52 +00:00
Oliver Burn 91aa657832 putting back the checkstyle settings back and now getting 67 odd errors. :-( 2002-11-22 12:37:00 +00:00
Rick Giles cf7e4c19e3 renamed XML element "set-property" to "property" 2002-11-18 10:03:05 +00:00
Rick Giles 3c0608f33a Wrapped GlobalProperties and CheckConfiguration[] into a Configuration
class. TODO: Integrate with CheckStyleTask
2002-11-15 18:18:52 +00:00
Rick Giles 4a638fc0e6 Added global-property to DTD.
Removed DTD from XML file until fix of ConfigurationLoader
2002-11-14 10:10:27 +00:00
Rick Giles 6f36f2811d added DTD for checkstyle configuration 2002-11-12 23:20:51 +00:00
Rick Giles 7fb81fdf90 added WhitespaceAfterCheck 2002-11-11 11:54:06 +00:00
Rick Giles 9eb9d9b3ea replaced NoWhiteSpaceAroundCheck by NoWhitespaceAfterCheck and
NoWhitespaceBeforeCheck
2002-11-10 20:48:33 +00:00
Rick Giles bed446244a added NoWhitespaceBefore, NoWhitespaceAfter checks 2002-11-10 20:35:13 +00:00
Rick Giles 333e944de5 added check for wrap of assignment operators at eol 2002-11-10 19:45:25 +00:00
Rick Giles ecaaaeb254 added operator wrap check 2002-11-09 20:24:22 +00:00
Oliver Burn 5fc3ff2bfb Please ensure you thoroughly test code before committing it. As a sanity test,
ensure that the target "checkstyle.checkstyle" will run! If in doubt, do not
commit, but instead said a patch to the devel mailing list for a review.

Finished the port of the ClassResolver code. Even though it compiled, it had
no chance of working due to class casting problems. They have not been
fixed. Also needed to ensure the correct class loader is being used.
2002-11-06 03:57:58 +00:00
Oliver Burn 93bba09f70 Wanting to turn on the check - but it fails. Need to resolve as it is most
likely to be a classpath issue.
2002-11-06 00:14:40 +00:00
Rick Giles 3bcc2c1391 update for JavadocMethodCheck 2002-11-05 20:39:56 +00:00
Oliver Burn fb97056b9b Fixed bug in MethodLeftCurlyCheck where it did not handle interfaces and
abstract methods.
2002-11-03 12:06:15 +00:00
Oliver Burn 4945b82e6d Folded the constructor length test into the method length check. Seems silly
to have them as separate checks.
2002-11-03 02:37:20 +00:00
Oliver Burn ba8a851e90 Fixed bug in MethodLengthCheck where it was assuming that a method definition
had to have braces. Not the case for interfaces and abstract methods. Need to
make the same change to the other method check.
2002-11-03 02:14:07 +00:00
Oliver Burn 3288a81e30 Just converted over the Checkstyle ANT task to use the new framework. In
process I had to fix numerous errors now being reported.

There are some bugs with the method checks, which I will now investigate.
2002-11-02 12:22:14 +00:00
Oliver Burn 2effcfd0bc Start of conversion to only supporting the new framework. Also refactored
error handling.
2002-10-31 12:28:47 +00:00
Oliver Burn 75482cc4f0 disable todo checking when run under gump 2002-09-15 11:30:51 +00:00
Oliver Burn 2b9b1e2021 Added some advice on upgrading 2002-09-14 05:14:15 +00:00
Oliver Burn 310100c239 Added some advice on upgrading 2002-09-14 05:07:00 +00:00
Oliver Burn ea13b70f2f updated for JDE 2002-09-14 04:24:08 +00:00
Oliver Burn 63c7ac019f removed unused property 2002-09-13 09:10:07 +00:00
Lars Kühne 3fecb73fb3 incorporte patch 607481 from Ville Skyttä to enforce wrap on operator at EOL 2002-09-13 05:43:47 +00:00
Lars Kühne 8a65d2ff82 docs for package name check 2002-09-08 12:55:14 +00:00
Lars Kühne 218bbeb80d added <h2> headers 2002-09-08 07:53:14 +00:00
Oliver Burn 7f06106f4e Yahoo! Implemented checking for unused private fields. Just need to document
the new feature. It is off by default as the class path must be set up. Can
use the same technique for private methods.
2002-09-08 07:31:37 +00:00
Oliver Burn 98c8a0db55 The absolutely last refactoring change with the properties config stuff. I am
sick it. Absolutely sick of it! Completely and utterly sick of it!! Still, the
change is better for the future.
2002-09-07 02:02:24 +00:00
Oliver Burn 49eb0e934e Yet another refactor to have the ANT task support a nested <property>
element. This let me remove the ugly have I put in to support relative
paths. Got the idea from Vincet Massol. Bug 605141.
2002-09-07 01:36:40 +00:00
Oliver Burn aff5047c9e Patch to make loading of relative file paths work. Basically duplicating the
work that ANT used to do. There had to be some pain in the refactoring. ;-)
2002-09-05 02:46:40 +00:00
Oliver Burn ac18264bf6 Patch to make Checkstyle run. Need to fix the TODO reported. 2002-09-04 14:35:10 +00:00
Oliver Burn 8a2f9d179f Fixed bugs in the build.xml file. 2002-09-04 14:30:14 +00:00
Oliver Burn a5bd0522b8 Cleaned up to use the new config files. 2002-09-04 12:28:11 +00:00
Oliver Burn 47f3495932 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 12:17:29 +00:00
Oliver Burn a926120685 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 12:10:15 +00:00
Oliver Burn ece0896556 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 12:02:11 +00:00
Oliver Burn 87879a7e57 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 11:55:19 +00:00
Oliver Burn a743ec6339 fixed null reference :-) 2002-09-04 11:54:51 +00:00
Oliver Burn f02124d9d3 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 11:40:53 +00:00
Oliver Burn 19815691c6 Added copyright statements (I have lawyers!). Also removed invalid docs from
main documents.
2002-09-04 11:37:28 +00:00
Oliver Burn 573daea049 Against a snap shot of changes I do not want to lose. 2002-09-04 11:00:28 +00:00
Oliver Burn 2817b05ecc Against a snap shot of changes I do not want to lose. 2002-09-04 10:23:55 +00:00
Oliver Burn c6d2120f6e Against a snap shot of changes I do not want to lose. 2002-09-04 08:03:05 +00:00
Oliver Burn bfe1cbdbed Against a snap shot of changes I do not want to lose. 2002-09-04 04:04:03 +00:00
Oliver Burn e55cf9b0bc Please ignore - a work in progress that I want to backup. 2002-09-03 13:45:38 +00:00
Oliver Burn 0e733a20c8 Please ignore - a work in progress that I want to backup. 2002-09-02 13:19:01 +00:00
Oliver Burn 1192d56554 Please ignore - a work in progress that I want to backup. 2002-09-02 13:13:11 +00:00
Oliver Burn e98d817e3f Please ignore - a work in progress that I want to backup. 2002-09-02 12:21:17 +00:00
Oliver Burn a37a1d7ba9 Please ignore - a work in progress that I want to backup. 2002-09-02 12:12:38 +00:00
Oliver Burn f8a53831f0 Incorporate patch 555878 from Rick Giles to allow pattern for local final
variables to be specified.
2002-08-21 08:08:43 +00:00
Oliver Burn 1fdf65bf01 Incorporate patch 566855 from Rob Worth to optionally check that parenthesis
are padded with spaces.

Big thanks to Lars for suggesting that the Pad Option not be a boolean so
somebody could one day submit this patch. :-)
2002-08-21 04:39:27 +00:00
Oliver Burn d92ceb81a6 Implemented enforcing having @version tag. (Request 543964). 2002-08-20 13:08:37 +00:00
Oliver Burn ecc852d48b Added support to specify a country so that the call to the Locale()
constructor is not dependent on JDK 1.4.
2002-08-12 12:10:57 +00:00
Oliver Burn 5890d22a6d Added documentation for localisation and the ability to set the language. 2002-08-12 09:02:41 +00:00
Oliver Burn 7781985a34 Request 582144: added documentation. 2002-08-12 07:40:29 +00:00
Oliver Burn c682b5725d Major rework to support localized error messages. Inspired by patch 580410. At
the moment it is not possible to override the system locale, this probably
should be added.
2002-08-10 14:15:00 +00:00
Oliver Burn 6946a8440c Incorporate patch 590931 from Vijay Aravamudhan. 2002-08-10 09:23:52 +00:00
Oliver Burn e7c7215349 request 583719 - detect unused @throws that subclass java.lang.Error. 2002-08-04 05:01:20 +00:00
Oliver Burn a9884dffce Incorporate patch from ronald _DOT d _DOT hastings _AT boeing _DOT com to
correctly handle C++ style comments being between Javadoc comments and
declarations.
2002-08-02 00:02:26 +00:00
Oliver Burn 257d848c62 Added reference to an example report. 2002-07-17 00:08:22 +00:00
Oliver Burn ea371c4f3a Changed the wrap on operator implementation to take an option rather than a
boolean. This allows it to be extended easily in the future.
2002-07-08 03:47:56 +00:00
Lars Kühne 3230cfbc88 use checkstyle-all in the -jar example to make sure that the example works no matter how the CLASSPATH is setup 2002-07-06 09:08:11 +00:00
Lars Kühne f10286c78b avoid double negation in description of illegal.instantiations 2002-07-06 08:56:30 +00:00
Lars Kühne 90f1a05e2b removed my email address to avoid spam 2002-07-06 08:50:57 +00:00
Oliver Burn fd1225fe8b Fixed grammar mistake - thanks Lars. 2002-07-04 06:01:02 +00:00
Oliver Burn ba5a640c86 Document the -jar option. 2002-07-04 00:01:59 +00:00
Lars Kühne 8c8aabd141 added example for -r option (rfe #568911) 2002-07-02 20:50:18 +00:00
Lars Kühne b87542b262 fixed bug 561616 2002-07-02 20:21:04 +00:00
Oliver Burn b3133035a4 576165: better error handling for missing properties file. 2002-07-02 11:51:56 +00:00
Oliver Burn bbe51f6884 571161: Added support for basedir attribute. 2002-07-01 01:57:36 +00:00
Oliver Burn 0e62f23a10 573485: detect redundant 'abstract' 2002-06-26 13:17:31 +00:00
Oliver Burn 0c8c6f3b45 Added jEdit reference. 2002-06-25 02:50:22 +00:00
Oliver Burn ab32ca0d86 Fixed typo 2002-06-22 12:05:15 +00:00
Oliver Burn c176f8b8eb 568553: fix Javadoc errors under JDK 1.4 2002-06-22 10:50:13 +00:00
Oliver Burn 119aa7439f Implement checking for whitespace around "{" & "}". 2002-06-17 12:17:31 +00:00
Oliver Burn d8d9269bbc Added documentation for checkUnusedThrows. 2002-06-16 12:23:37 +00:00
Lars Kühne 14f2b27f8f added new commandline flag '-p' 2002-06-11 04:23:19 +00:00
Oliver Burn 3da466b9bf Added check to ensure that long integer literals use L, not l. Also fixed bug
by my over zealous removal of toString() methods.
2002-06-06 11:45:40 +00:00
Oliver Burn 4018efa9fe Refactored the catch block checking code to include try/catch/finally blocks. 2002-06-05 13:17:20 +00:00
Lars Kühne 87fb75661f added new feature "detect illegal instantiation" to 2.3 2002-05-30 04:45:18 +00:00
Oliver Burn ccd30545e2 Added documentation for checking for wrapping on operators 2002-05-29 13:00:28 +00:00
Lars Kühne da940af362 Implementation, tests and docs for generalization of instantiation check. Users can now specify a list of classes that are not allowed to be instantiated.
This also fixes Bug 556317, Boolean instantiation, as now a config option is provided and the check for java.lang.Boolean is turned off by default
2002-05-28 20:23:00 +00:00
Oliver Burn 1c5c068b3a Updated for catchBlock option 2002-05-26 13:27:36 +00:00
Lars Kühne 502082c736 docs for '-p' option 2002-05-20 10:36:25 +00:00
Lars Kühne 4425afa0c2 - #516255, find empty exception handlers. Maybe we should add some
"OK if commented" option, but I don't see how to do that in the grammar.
- initial support for #550205, find instantiations of Boolean. This is not
  configurable yet, and we should generalize it to find instantiation of
  arbitrary types. Docs are also still missing, will write them after
  generalization.
2002-05-15 04:34:59 +00:00
Oliver Burn dfd7310b96 Fix documentation to:
- Include a version number in headings
- Use the ANT <filterset> to update the version number. No longer need to
  update the docs for each release.
2002-05-14 04:33:54 +00:00
Oliver Burn fca8c91804 Request 504275: detect to-do comments 2002-05-13 12:52:55 +00:00
Oliver Burn 65989e76a4 Request 555262: Include column number in the XML output 2002-05-13 01:48:41 +00:00
Oliver Burn 9556af52eb Updated the version number. 2002-05-10 11:50:03 +00:00
Lars Kühne 1b7f3c143d real names for style sheet contributors 2002-05-10 04:39:00 +00:00
Lars Kühne 475115172e added hint about regexp-disabling of linelength check 2002-05-05 12:27:55 +00:00
Lars Kühne a84406be77 doc for tab expansion 2002-05-05 11:45:53 +00:00
Lars Kühne 7a9a4c2045 added releasenotes for old releases, rewrote 2.2 releasenotes 2002-05-01 07:35:39 +00:00
Lars Kühne a851e6db3c added releasenotes. Oliver, please spellcheck and fill in the 2.1 release if possible 2002-04-30 20:36:38 +00:00
Lars Kühne a736b629f8 added documentation for patch 531230, 'add properties file functionality' 2002-04-28 12:53:33 +00:00
Lars Kühne 1825bf38b9 fixed capitalization error that prevented link from working 2002-04-28 12:47:17 +00:00
Oliver Burn 3ded17ac3d Changed support for parenthesises padding to take an option, rather that being
a boolean of whether to ignore or not. This will allow the adding of more
styles in the future. Good idea Lars! :-)
2002-04-24 14:36:27 +00:00
Oliver Burn 083a7d432a Added option to disable checking for padding of parenthesis. As asked for by
Lars. Eventually should have an option to allow different styles - rather the
current "Sun way" or the "highway.
2002-04-22 10:41:10 +00:00
Lars Kühne caf539ded2 Implementation + docs for rfe 537107, "public" in interface methods 2002-04-21 21:02:57 +00:00
Oliver Burn e200d9bf3d 545128: implemented "-r" recursive option and improved the argument handling 2002-04-17 11:59:52 +00:00
Lars Kühne 00447a8fe3 added check for illegal imports 2002-04-17 04:43:55 +00:00
Lars Kühne 8eb824037e added documentation for regexp-disabling of line-length checks 2002-04-13 08:31:46 +00:00
Oliver Burn 49314771b6 Fixed bug that allowed constant declarations to contain "__". 2002-04-07 09:16:43 +00:00
Lars Kühne 9a8acc01fd added example for failureProperty, contribution from Gray Herter [gray _AT_ fgm _DOT_ com] 2002-03-24 09:05:28 +00:00
Lars Kühne 50d5a434f1 removed Eclipse from 'plugins wanted' list 2002-03-24 08:04:32 +00:00
Lars Kühne 0e0ca2bddf added failureProperty to ant task (RFE 534038) 2002-03-23 17:03:15 +00:00
Oliver Burn 2666ced62f Added reference to Eclipse plug-in 2002-03-21 11:32:34 +00:00
Oliver Burn ba441b3fd6 Added doc for allowing tabs. 2002-03-15 14:14:02 +00:00
Lars Kühne 59a8339758 updated tested JREs, fixed bug 517398 2002-02-26 06:03:31 +00:00
Oliver Burn 1a596b6827 Renamed anttasks.properties to checkstyletask.properties. A much clearer name. 2002-02-25 12:15:07 +00:00
Lars Kühne 10691121f4 fixed typo (making vs. maximum) 2002-02-24 16:00:00 +00:00
Lars Kühne 2a1cd247d2 upated feature list to reflect current status 2002-02-24 15:58:47 +00:00
Lars Kühne 15640a8a1a added documentation for anttasks.properties 2002-02-24 15:56:22 +00:00
Oliver Burn 171e8d02b5 Documented the rcurly option 2002-02-23 11:14:59 +00:00
Oliver Burn 05e366ecf3 Fixed errors found by Tidy (http://www.w3.org/People/Raggett/tidy/). 2002-02-22 04:49:30 +00:00
Oliver Burn 2afaad3fa2 Added documentation for the lcurly options. 2002-02-22 04:43:09 +00:00
Oliver Burn 59ce3f31d7 Added support for brace checking on the keywords try, catch, finally, static.
What are not covered deliberately are labels and instance initializers.
2002-02-22 04:12:04 +00:00