Commit Graph

607 Commits

Author SHA1 Message Date
Lars Kühne da2328d0f1 added new check EmptyForInitializerPad and changed logic in NoWhiteSpaceBefore and ParenPad to fix bug #895072 2004-02-15 11:31:32 +00:00
Lars Kühne 2bbeb9e27a fixed typo
improved the rationale explanation in response to invalid bug report.
2004-02-15 07:04:25 +00:00
Rick Giles e5ad46010b Fixed MagicNumberCheck bug when checking a cast, bug 890706. 2004-02-04 22:44:59 +00:00
Oleg Sukhodolsky 63fc2b75aa One more update of release notes 2004-01-30 07:26:09 +00:00
Oleg Sukhodolsky 7f103f3760 TrailingComment check, request 744970 2004-01-29 19:30:03 +00:00
Oleg Sukhodolsky 30a744e620 release notes' update 2004-01-29 07:41:51 +00:00
Oleg Sukhodolsky 74b57239f5 Implementation of rfe 695935 (Valid public identifier is still failing field naming style). Not sure that this is a best approach to implement. Open to discussions. 2004-01-25 14:17:27 +00:00
Rick Giles c9a1a41a16 fixed bug 880954: UnusedPrivateMethod false positive (ternary call). 2004-01-23 01:02:56 +00:00
Rick Giles 43a05ed66d added MethodParamPadCheck 2004-01-21 01:22:20 +00:00
Rick Giles dc5ea22c73 Added check for the padding between the
identifier of a method definition, constructor definition,
method call, or constructor invocation;
and the left parenthesis of the parameter list.  (module
MethodParamPad, request 843254)
2004-01-21 01:10:59 +00:00
Oleg Sukhodolsky 09f901f537 Added link to optional checks into TreeWalker's checks section. (patch 880026, from Ville Skytta) 2004-01-20 03:52:28 +00:00
Rick Giles 30a895e589 Fixed bug: JavadocStyleCheck throws StringIndexOutOfBoundsException when open tag character, <, is the last character on a line. 2004-01-18 20:08:07 +00:00
Rick Giles a7bede3cb4 Fixed bug: MagicNumberCheck throws NumberFormatException with negative octal and hex ints and longs. 2004-01-18 19:37:48 +00:00
Rick Giles ddff555c2d Fixed bug 878608: Error in reporting UnusedLocalVariable for multi-dimensional array index. 2004-01-17 15:28:18 +00:00
Oliver Burn 5670252b46 updated license details 2004-01-14 21:10:39 +00:00
Rick Giles d28061d9f2 Removed JDK 1.4 dependency (bug 876570) 2004-01-14 17:26:19 +00:00
Rick Giles 02e614f091 Noted that UnusedPrivateMethod may require configuring the classpath. 2004-01-12 21:35:57 +00:00
Oleg Sukhodolsky d298d68e67 Added multiLines property for RegexpHeaderCheck. Added AbstractHeaderCheck - superclass for header checks. 2004-01-11 04:43:25 +00:00
Oleg Sukhodolsky 95871dcc26 Some enhancement and documentation for RequireThis check. 2004-01-10 14:41:28 +00:00
Oleg Sukhodolsky a6a288813e MultipleVariableDeclarations (requests 639233, 753858, 844705). 2004-01-10 03:54:15 +00:00
Oleg Sukhodolsky 553f3eb61e FallThrough check, request 754438. 2004-01-08 19:21:45 +00:00
Oleg Sukhodolsky e029c0077f MissingCtor check, request 696129. 2004-01-06 19:32:58 +00:00
Lars Kühne 41833b1ce3 got info from Simon that false alarms are theoretically possible
but highly unlikely in Simian (just like in our own check)
2004-01-06 14:47:43 +00:00
Lars Kühne 4ec69ed49e fixed copy&paste error in main header 2004-01-06 09:08:42 +00:00
Oleg Sukhodolsky d559cf9414 DefaultComesLast check (request 754486) 2004-01-06 05:50:49 +00:00
Oleg Sukhodolsky 3396d43ff2 Fix for rfe #843551 (Additional log call for Check API class) 2004-01-05 12:36:41 +00:00
Oleg Sukhodolsky d2fb67faae Fix for 866501 (Inconsistent lcurly new line on wrap). Some grammar changes made to fix this problem. 2004-01-05 07:38:33 +00:00
Oleg Sukhodolsky bbd5145467 Docs for metric checks. Changing default max for BooleanExpressionComplexity to 3 as requested. 2004-01-04 05:12:31 +00:00
Oleg Sukhodolsky 1da0f94aa7 Added checkstyle-csv.xsl (request 764153) 2004-01-02 02:34:34 +00:00
Lars Kühne f608bf65e1 Improved german translation, contributed by Oliver Fischer (patch 862911) 2003-12-30 15:20:32 +00:00
Oleg Sukhodolsky 0b4c120056 Several improvements of FinalParameter check.
Fixed bug #864900 - Wrong column for method parameters in FinalParametersCheck
Added I18N support.
Implemented FRE #848820 - Final Catch Parameter.
2003-12-30 04:16:59 +00:00
Lars Kühne 501ce585ab integrated Paul King's example for WebLogic WorkShop integration
to demonstrate String Set usage. See
https://sourceforge.net/tracker/?func=detail&aid=865610&group_id=29721&atid=397078
2003-12-25 08:51:51 +00:00
Lars Kühne 6f570b60a7 removed docs for "-e" option (bug 865610) 2003-12-25 08:46:15 +00:00
Lars Kühne 7968b29418 Added a 'version' attribute to the 'checkstyle' element in the XML output document (request 853128) 2003-12-23 11:25:39 +00:00
Lars Kühne 8ceae21f09 close "patch" #841087 2003-12-16 20:41:43 +00:00
Rick Giles 1518765e7f fixed bug 860990, wrong documentation for FinalLocalVariable 2003-12-16 14:47:18 +00:00
Oleg Sukhodolsky c75472399f Fix for 853225 - Indentation gives false errors 2003-12-13 12:47:23 +00:00
Oleg Sukhodolsky 72be23f288 Fix for 855839 - JavadocMethod does not correctly treat {@inheritDoc}. 2003-12-08 18:58:05 +00:00
Oleg Sukhodolsky 42d34c7e16 Fix for 791245 (checkstyle-frames.xsl cannot handle multiple leafs). 2003-12-05 08:17:54 +00:00
Oleg Sukhodolsky 204c472399 Fixed 852397 (checkstyle frames lacks summary link)
Fixed problem in IllegalType check reported by Venkatesh Prasad Ranganath.
Fixed checkstyle.style target in build.xml.
2003-12-05 04:41:21 +00:00
Oleg Sukhodolsky f8946ef533 Fix for 849450 (ArrayTypeStyle should only check variable/parameter decls). 2003-11-27 06:12:26 +00:00
Rick Giles dee81b907a fixed xmllogger.dtd is out-of-date (bug 847974) 2003-11-26 10:54:17 +00:00
Oleg Sukhodolsky d4fe5e2ce1 Applying patch 848483 (Documentation fixes) from Ville Skytta (scop) 2003-11-25 09:56:43 +00:00
Oleg Sukhodolsky e57fd63469 Fix for 848750 (Linebreak confuses ArrayTypeStyle) 2003-11-25 08:55:27 +00:00
Oleg Sukhodolsky 59d5b734cc Marking 8433887 as fixed. 2003-11-23 09:44:09 +00:00
Oleg Sukhodolsky 24ba45a971 Fix for ArrayIndexOutOfBounds in JavadocStyle (bug 841942 ) 2003-11-23 08:33:41 +00:00
Rick Giles b9b72f9692 fixed bug 846110, j2ee.EntityBean check for constructor is incorrect 2003-11-22 13:30:57 +00:00
Oleg Sukhodolsky ec70b77765 Applying patch 835896(classpathref support for Ant task) 2003-11-17 05:20:19 +00:00
Oleg Sukhodolsky c6bbd67749 Added caseSensitive property to ImportOrder check (bug 842604). 2003-11-16 08:40:33 +00:00
Oleg Sukhodolsky 4d8c68ec20 Removed MutableException dependency from 1.4 API.(bug 842756) 2003-11-16 06:14:16 +00:00
Oleg Sukhodolsky c4c966c971 Fix grammar build process (RFE 827781) 2003-11-13 16:32:53 +00:00
Lars Kühne 4f9debc29b fixed copy+paste problem in examples of StrictDuplicateCode check
damn, there's always something you notice right after making a release
2003-11-12 05:17:55 +00:00
Lars Kühne 392e556d70 made optional.jar maven friendly (requested by V.Massol, maintainer of Maven plugin) 2003-11-11 05:53:07 +00:00
Oliver Burn ac9fe51610 Added JBuilder link 2003-11-10 09:35:25 +00:00
Rick Giles f90a08de09 spelling correction 2003-11-08 20:56:25 +00:00
Rick Giles b7d4d721a2 spelling correction 2003-11-08 12:50:51 +00:00
Lars Kühne 53638cd097 added note about core vs optional 2003-11-08 12:43:19 +00:00
Lars Kühne 5c3762cef2 fixed bug 837012, false alarms for abstract classes 2003-11-08 12:29:19 +00:00
Rick Giles 476f90c5d3 update Filter UML diagram 2003-11-07 14:57:24 +00:00
Oleg Sukhodolsky 8d242382f8 Filter.accept() now takes AuditEvent, not an Object. 2003-11-07 04:49:54 +00:00
Lars Kühne 100353f305 ... and antlr has been version 2.7.2 since March. I guess it's too late to put that into the 3.1 releasenotes :-) 2003-11-05 05:22:50 +00:00
Lars Kühne 5fa9891d4b we now use jakarta-regexp 1.3 2003-11-05 05:16:08 +00:00
Oleg Sukhodolsky 778e844080 Added removeListener() and removeFilter() to Checker (bug 834367) 2003-11-05 04:26:12 +00:00
Lars Kühne 08a76dba14 fixed bug 824754 2003-10-27 06:14:36 +00:00
Rick Giles 84d33e55d9 Fixed HiddenFieldCheck error for a local variable of a static
method with same name as an instance field(bug 827713)
2003-10-27 00:32:00 +00:00
Lars Kühne 60ecfe9c06 documented StrictDuplicate code check and incompatible API change 2003-10-24 05:43:11 +00:00
Lars Kühne e16c4a8259 spec for StrictDuplicateCode 2003-10-12 07:15:52 +00:00
Oleg Sukhodolsky 861e2af0e1 Changed default format for ConstantName. (see bug 807571). 2003-10-09 04:20:46 +00:00
Oleg Sukhodolsky 984eb8d742 ExplicitInitialization added to checkstyle's style. Fixed problems it found. 2003-10-08 17:46:58 +00:00
Oliver Burn 1bb0fb09a3 Upgraded to jakarta-regexp-1.3. 2003-10-08 13:02:30 +00:00
Oleg Sukhodolsky 03c3efabf3 Check for variable explicit initialization (request 614387) 2003-10-04 17:01:27 +00:00
Oleg Sukhodolsky 194f86d218 Release notes update. 2003-10-04 01:28:58 +00:00
Oleg Sukhodolsky 868ae755c1 Fixed documentation for Indentation check. 2003-09-30 10:06:53 +00:00
Lars Kühne 2200323756 fixed typos and html layout 2003-09-28 05:27:00 +00:00
Oleg Sukhodolsky 60d0673dcc Documentation for Indentation check. 2003-09-27 05:26:28 +00:00
Oleg Sukhodolsky ee987808d1 Update for releasenotes 2003-09-22 12:47:03 +00:00
Rick Giles 0527cab338 documented optional Checks (bug 806961) 2003-09-21 14:11:28 +00:00
Oleg Sukhodolsky 2a1705e70d ImportOrder check from Bill Schneider (request 745548)docs/releasenotes.html 2003-09-16 18:37:57 +00:00
Oleg Sukhodolsky 77ca904cf5 Fixed 806242 (NoWhitespaceBeforeCheck error with an interface).
Fixed 806243 (NoWhitespaceBeforeCheck error for anonymous inner
class).
Now build will fail if antlr fails to process the grammar.
2003-09-15 06:01:31 +00:00
Rick Giles cdbb83775e Fixed Unused... checks don't work together (bug 805954) 2003-09-14 22:39:58 +00:00
Rick Giles 0c717ef2ab Added FinalLocalVariable check from Roland Auckenthaler and Kevin Gibbs. 2003-09-11 12:01:47 +00:00
Oleg Sukhodolsky 2acda3b127 Fix for 803577 (allowThrowsTagsForSubclasses/allowMissingThrowsTag interfere) 2003-09-11 03:53:51 +00:00
Oleg Sukhodolsky 15ccd93806 Added ParameterAssignment check contributed by Simon Harris (request 750748).
Fixed internatialization support in DeclarationOrder check.
2003-09-07 11:15:58 +00:00
Oleg Sukhodolsky d041e5226b DeclarationOrder check contibuted by Roland Auckenthaler 2003-09-06 20:14:39 +00:00
Oleg Sukhodolsky 75773acf4f Added IllegalType check from Simon Harris (request 750739).
Added getter for illegalClassNames property of IllegalCatch check.
2003-09-04 18:35:22 +00:00
Rick Giles 39c810009d Commented out HeaderCheck.
Now sun_checks.xml can be used without setting properties for property expansion.
2003-09-02 19:47:29 +00:00
Oleg Sukhodolsky a56be052af Changed configuration documentation example from checkstyle_checks.xml to sun_checks.xml (see bug 750169) 2003-09-02 17:27:52 +00:00
Rick Giles 4ba49828ac Fixed bug 798111: Unused local variables are not always detected.
Example given was caused by incorrectly considering a typecast to
be a variable reference. Types were also incorrectly considered as
variable references.
2003-09-02 09:30:51 +00:00
Rick Giles 611722a893 Fixed bug 798405 JavadocStyleCheck doesn't accept {@inheritDoc} javadoc 2003-09-01 10:10:40 +00:00
Rick Giles a00160b33c Added property to HiddenFieldCheck to ignore constructor parameters (request 798240). 2003-08-31 21:35:07 +00:00
Rick Giles 20b7faa450 Moved ExecutableStatementCountCheck to sizes package. 2003-08-31 16:26:01 +00:00
Rick Giles d8766886f2 Added INSTANCE_INIT to tokens for EmptyBlockCheck. 2003-08-31 10:26:42 +00:00
Rick Giles b8f9b199ad Added ExecutableStatementCount check from Simon Harris (request 750751). 2003-08-30 21:17:41 +00:00
Rick Giles 1952077d3e Changed configuration documentation example from checkstyle_checks.xml
to sun_checks.xml  (see bug 750169)
2003-08-29 19:12:47 +00:00
Rick Giles 32fcc5d7db documented CyclomaticComplexity (bug 783800) 2003-08-29 18:44:59 +00:00
Rick Giles 6b1ad4f2d6 corrected usage checks documentation (bug 790457) 2003-08-29 15:05:02 +00:00
Oleg Sukhodolsky 9bc9f41827 Added ThrowsCount check from Simon Harris (request 750742).
Added ReturnCount check from Simon Harris (request 750745).
Minor fixes in release notes.
2003-08-28 19:18:31 +00:00
Oleg Sukhodolsky ec796dc641 moving/renaming [Illegal]AbstractClassName check to naming package. 2003-08-28 06:50:45 +00:00
Oleg Sukhodolsky f06e7b12c3 Added IllegalAbstractClassName check (request 750749). 2003-08-27 21:14:39 +00:00
Oleg Sukhodolsky 5245c14883 Added MutableException check (request 750750).
This is a very simple algorithm, but, I believe, it catches most of
real-life problems.
2003-08-26 20:06:58 +00:00