59de966a7e
Added allowInSwitchCase property to AvoidNestedBlocksCheck
...
to allow limiting the scope of variables to one case of a switch statement.
Also currently playing with the Clover IDEA plugin - man, this rocks!!
2003-07-05 11:09:52 +00:00
6db0b3effd
Code cleanup to force the class name for the cause of the message to be
...
logged. Required as part of changes I am making for RFE 756416.
2003-07-05 10:47:35 +00:00
b07f845ac1
added IllegalTokenCheck, request 750755
2003-07-02 12:48:43 +00:00
2617fa0175
added tests for StringLiteralEqualityCheck
2003-06-29 10:43:34 +00:00
d1b597e289
added tests for StringLiteralEquality
2003-06-29 10:41:47 +00:00
8de6dda16b
Fix javadoc problem.
2003-06-29 10:04:52 +00:00
a30cd217f3
Implementation for NestedIfDepthCheck and NestedTryDepthCheck.
...
Thanks Simon.
2003-06-28 20:02:25 +00:00
784842200f
Refactored, that was really ugly code I had written.
2003-06-27 12:10:58 +00:00
768256c32a
I am sick of Spam! :-(
2003-06-27 11:04:38 +00:00
5be2f0b799
corrected checkstyle error
2003-06-27 10:22:32 +00:00
d91d824ac7
guard against null
2003-06-27 10:19:43 +00:00
a03dc8c1c9
simplified algorithm
2003-06-27 09:58:28 +00:00
9eb27f99a3
re-ordered tests for efficiency
2003-06-26 17:51:11 +00:00
e03dd7a0a0
handle anonymous classes with CovariantEqualsCheck
2003-06-26 17:25:02 +00:00
9309a78471
defined CovariantEqualsCheck method getRequiredTokens to prevent
...
mis-configuration
2003-06-26 16:30:21 +00:00
71d92d649f
check that a class that defines a covariant equals method also overrides
...
equals(java.lang.Object)
2003-06-26 16:19:46 +00:00
9a702cf864
CSortedVS: ----------------------------------------------------------------------
2003-06-25 12:48:39 +00:00
1546ad654f
implementation for rfe #754835 , detect string equality checking with ==
...
still have to do tests and docs
2003-06-24 19:40:45 +00:00
3a75454e8d
Added CyclomaticComplexityCheck from Simon Harris.
...
Refactored quite a bit
2003-06-24 12:35:40 +00:00
ed7fc0e632
Fix Checkstyle errors
2003-06-24 00:53:00 +00:00
731b581a1c
Added excludes property to AvoidStarImport, request 744955
...
contributed by Bill Schneider
2003-06-23 21:11:23 +00:00
32f5f97181
Major refactoring to remove duplicate code detected
...
by Simian. Just demonstrates the power of the tools for
find code that needs refactoring.
I can hardly wait to use Simian on my current project.
<evil_grin/>
2003-06-23 13:31:20 +00:00
7bd1126a3b
Code cleanup - removed the stupid AbstractImportCheck.
...
It served no purpose but to add to our huge inheritance
hierarchy.
I was suprised how deep our hierarchy actually is. Is this
the sign of to much abstraction. I wonder?
2003-06-23 12:09:08 +00:00
cf089fe1a1
Fix the Checkstyle errors created by Spud's patch.
2003-06-23 11:36:07 +00:00
e03dab4d1f
Patch from Matt Quail to stop the ugly hack of having hard
...
coded constants in TokenTypes. The big risk was that when
the grammar changed, the generated constants could
change. (patch 757846)
2003-06-21 12:34:01 +00:00
f4a85d495c
Fix for bug#755744
2003-06-20 08:51:47 +00:00
db5ec5f654
Nice patch from Matt Quail to DetailAST to replace all the repeated int[] array construction with a BitSet.
2003-06-19 13:20:33 +00:00
e7778ef9e2
Removed unread private field.
2003-06-16 13:12:25 +00:00
9920857810
Refactored the Coding checks
2003-06-15 12:39:40 +00:00
e464c231ec
Indentation:
...
Fixes for several TODO comments.
Added AssignHandler.
2003-06-14 17:47:41 +00:00
ca5c92f2e7
Added ignoreFormat property to HiddenFieldCheck (request 748830).
2003-06-12 17:30:23 +00:00
78faabd14f
Removed equals + hashcode. sorry for the trouble.
2003-06-10 22:07:14 +00:00
494d1835fb
Fix for [ 694111 ] Syntax error crashes Checkstyle.
2003-06-10 21:08:13 +00:00
88f6d6ffe7
Fixed hashCode() and equals() problems which cause DetailASTTest
...
and EqualsHashCodeCheckTest unit-tests failures.
But I wonder if we realy need hashCode() and equals() for DetailAST,
since it's a mutable.
2003-06-10 21:04:28 +00:00
c37cc9e521
added equals + hashCode
2003-06-10 14:50:07 +00:00
889587fdd2
Updated the license file for the current year. All this legal license stuff is
...
a real drag. :-(
2003-06-09 07:48:20 +00:00
56dcef50fb
re-added test now Lars has commited input file
2003-06-09 07:26:53 +00:00
f97fc5cdc5
input file for AnonInnerLength unit tests
2003-06-09 07:08:32 +00:00
99ed7a7d2c
bug-750348: added check for typecast parens. Involved
...
a bit of refactoring.
2003-06-09 06:20:19 +00:00
75a289111e
bug-750348: removed broken support for checking typecasts
2003-06-09 05:17:39 +00:00
33b86f5b25
bug-750348: removed broken support for checking typecasts
2003-06-09 05:05:23 +00:00
04918025d0
disable check until Lars commits the input file.
2003-06-09 04:19:47 +00:00
1531f6f772
Removed old code that was meant already deleted?
2003-06-09 01:23:10 +00:00
8054b3f09b
added messages for AnonInnerLength
2003-06-07 08:44:14 +00:00
9c1f6761b7
added tests for AnonInnerLength and ArrayTypeStyle
2003-06-07 08:32:05 +00:00
2b9b30e986
implementation for rfe #715709 (anonymous inner classes should be short)
...
contributed by Rob Worth
2003-06-07 08:31:09 +00:00
b176d50603
Moving IndentationCheck to indentation sub-directory.
2003-06-06 21:54:12 +00:00
4d88dbf477
Moving IndentationCheck to indentation sub-directory.
2003-06-06 21:48:40 +00:00
52dea9dcdc
build.xml:
...
now clean target also removes expandedjava14.g generated by antlr.
GenericIllegalRegexpCheck:
removed to item about explicit setting of match flags.
Indentation:
Todo item about static init blocks fixed in
IndentationCheckTest.testInvalidBlockWithChecker().
2003-06-06 20:38:06 +00:00
4f892fe43a
Indentation. Fix for testBraceAdjustment unit test.
2003-06-05 11:33:47 +00:00
Lars Kühne
Oliver Burn
Rick Giles
Oleg Sukhodolsky