Commit Graph

1020 Commits

Author SHA1 Message Date
Rick Giles 9eb27f99a3 re-ordered tests for efficiency 2003-06-26 17:51:11 +00:00
Rick Giles e03dd7a0a0 handle anonymous classes with CovariantEqualsCheck 2003-06-26 17:25:02 +00:00
Rick Giles 9309a78471 defined CovariantEqualsCheck method getRequiredTokens to prevent
mis-configuration
2003-06-26 16:30:21 +00:00
Rick Giles 71d92d649f check that a class that defines a covariant equals method also overrides
equals(java.lang.Object)
2003-06-26 16:19:46 +00:00
Oliver Burn 9a702cf864 CSortedVS: ---------------------------------------------------------------------- 2003-06-25 12:48:39 +00:00
Lars Kühne 1546ad654f implementation for rfe #754835, detect string equality checking with ==
still have to do tests and docs
2003-06-24 19:40:45 +00:00
Oliver Burn 3a75454e8d Added CyclomaticComplexityCheck from Simon Harris.
Refactored quite a bit
2003-06-24 12:35:40 +00:00
Oliver Burn ed7fc0e632 Fix Checkstyle errors 2003-06-24 00:53:00 +00:00
Lars Kühne 731b581a1c Added excludes property to AvoidStarImport, request 744955
contributed by Bill Schneider
2003-06-23 21:11:23 +00:00
Oliver Burn 32f5f97181 Major refactoring to remove duplicate code detected
by Simian. Just demonstrates the power of the tools for
find code that needs refactoring.

I can hardly wait to use Simian on my current project.
<evil_grin/>
2003-06-23 13:31:20 +00:00
Oliver Burn 7bd1126a3b Code cleanup - removed the stupid AbstractImportCheck.
It served no purpose but to add to our huge inheritance
hierarchy.

I was suprised how deep our hierarchy actually is. Is this
the sign of to much abstraction. I wonder?
2003-06-23 12:09:08 +00:00
Oliver Burn cf089fe1a1 Fix the Checkstyle errors created by Spud's patch. 2003-06-23 11:36:07 +00:00
Oliver Burn e03dab4d1f Patch from Matt Quail to stop the ugly hack of having hard
coded constants in TokenTypes. The big risk was that when
the grammar changed, the generated constants could
change. (patch 757846)
2003-06-21 12:34:01 +00:00
Oleg Sukhodolsky f4a85d495c Fix for bug#755744 2003-06-20 08:51:47 +00:00
Oliver Burn db5ec5f654 Nice patch from Matt Quail to DetailAST to replace all the repeated int[] array construction with a BitSet. 2003-06-19 13:20:33 +00:00
Rick Giles e7778ef9e2 Removed unread private field. 2003-06-16 13:12:25 +00:00
Oliver Burn 9920857810 Refactored the Coding checks 2003-06-15 12:39:40 +00:00
Oleg Sukhodolsky e464c231ec Indentation:
Fixes for several TODO comments.
Added AssignHandler.
2003-06-14 17:47:41 +00:00
Rick Giles ca5c92f2e7 Added ignoreFormat property to HiddenFieldCheck (request 748830). 2003-06-12 17:30:23 +00:00
Rick Giles 78faabd14f Removed equals + hashcode. sorry for the trouble. 2003-06-10 22:07:14 +00:00
Oleg Sukhodolsky 494d1835fb Fix for [ 694111 ] Syntax error crashes Checkstyle. 2003-06-10 21:08:13 +00:00
Oleg Sukhodolsky 88f6d6ffe7 Fixed hashCode() and equals() problems which cause DetailASTTest
and EqualsHashCodeCheckTest unit-tests failures.

But I wonder if we realy need hashCode() and equals() for DetailAST,
since it's a mutable.
2003-06-10 21:04:28 +00:00
Rick Giles c37cc9e521 added equals + hashCode 2003-06-10 14:50:07 +00:00
Oliver Burn 889587fdd2 Updated the license file for the current year. All this legal license stuff is
a real drag. :-(
2003-06-09 07:48:20 +00:00
Oliver Burn 56dcef50fb re-added test now Lars has commited input file 2003-06-09 07:26:53 +00:00
Lars Kühne f97fc5cdc5 input file for AnonInnerLength unit tests 2003-06-09 07:08:32 +00:00
Oliver Burn 99ed7a7d2c bug-750348: added check for typecast parens. Involved
a bit of refactoring.
2003-06-09 06:20:19 +00:00
Oliver Burn 75a289111e bug-750348: removed broken support for checking typecasts 2003-06-09 05:17:39 +00:00
Oliver Burn 33b86f5b25 bug-750348: removed broken support for checking typecasts 2003-06-09 05:05:23 +00:00
Oliver Burn 04918025d0 disable check until Lars commits the input file. 2003-06-09 04:19:47 +00:00
Oliver Burn 1531f6f772 Removed old code that was meant already deleted? 2003-06-09 01:23:10 +00:00
Lars Kühne 8054b3f09b added messages for AnonInnerLength 2003-06-07 08:44:14 +00:00
Lars Kühne 9c1f6761b7 added tests for AnonInnerLength and ArrayTypeStyle 2003-06-07 08:32:05 +00:00
Lars Kühne 2b9b30e986 implementation for rfe #715709 (anonymous inner classes should be short)
contributed by Rob Worth
2003-06-07 08:31:09 +00:00
Oleg Sukhodolsky b176d50603 Moving IndentationCheck to indentation sub-directory. 2003-06-06 21:54:12 +00:00
Oleg Sukhodolsky 4d88dbf477 Moving IndentationCheck to indentation sub-directory. 2003-06-06 21:48:40 +00:00
Oleg Sukhodolsky 52dea9dcdc build.xml:
now clean target also removes expandedjava14.g generated by antlr.

GenericIllegalRegexpCheck:
removed to item about explicit setting of match flags.

Indentation:
Todo item about static init blocks fixed in
IndentationCheckTest.testInvalidBlockWithChecker().
2003-06-06 20:38:06 +00:00
Oleg Sukhodolsky 4f892fe43a Indentation. Fix for testBraceAdjustment unit test. 2003-06-05 11:33:47 +00:00
Oleg Sukhodolsky 0ddd77847d Fixed javadoc links. 2003-06-05 10:37:36 +00:00
Oleg Sukhodolsky 7d5a2853eb Grammar improvement.
Now STATIC_INIT node should have correct line and column numbers.
2003-06-05 07:09:08 +00:00
Oliver Burn 32d19d6801 Refactored the Design checks 2003-06-04 23:52:04 +00:00
Rick Giles 679f818267 fixed NumberFormatException in MagicNumberCheck (bug 748913) 2003-06-04 16:08:36 +00:00
Oliver Burn ec6582beb1 Refactored the Sizes checks 2003-06-04 12:23:29 +00:00
Oliver Burn 2e8126e990 Refactored the Whitespace checks 2003-06-04 11:55:29 +00:00
Oliver Burn 3bd6412e39 Refactored the Block checks 2003-06-04 10:42:47 +00:00
Oliver Burn a0844ab125 Refactoring naming checks 2003-06-04 09:31:00 +00:00
Oliver Burn d80cbf6104 Moved the Naming checks to a sub-package. I had some
spare time between meetings today.
2003-06-04 07:14:41 +00:00
Oleg Sukhodolsky 03ac7a0878 cosmetic change to please javadoc tool 2003-06-04 04:21:49 +00:00
Oliver Burn ddb334d9e4 Moved the Import checks to a sub-package. That is all
the refactoring I have time for over the next few days.
2003-06-03 14:13:22 +00:00
Oliver Burn 04ac5dd87c Moving another Javadoc check to see what is involved.
A suprisingly small amount. Love the Eclipse refactoring
support having the smarts to do the CVS operations.
2003-06-03 13:51:29 +00:00