Commit Graph

580 Commits

Author SHA1 Message Date
Lars Kühne d471c9cd54 override read(), leads to ~10 percent performance increase 2002-11-03 15:03:36 +00:00
Oliver Burn fb97056b9b Fixed bug in MethodLeftCurlyCheck where it did not handle interfaces and
abstract methods.
2002-11-03 12:06:15 +00:00
Lars Kühne bf1b83ee6f made class package local again 2002-11-03 09:53:29 +00:00
Lars Kühne 1aa2134399 fixed NPE 2002-11-03 08:37:00 +00:00
Oliver Burn 4945b82e6d Folded the constructor length test into the method length check. Seems silly
to have them as separate checks.
2002-11-03 02:37:20 +00:00
Oliver Burn ba8a851e90 Fixed bug in MethodLengthCheck where it was assuming that a method definition
had to have braces. Not the case for interfaces and abstract methods. Need to
make the same change to the other method check.
2002-11-03 02:14:07 +00:00
Oliver Burn ce177456e7 Made some style changes. 2002-11-03 01:47:12 +00:00
Oliver Burn 15c641997d Minor tweak to the style. Rather not use the local variable of the name
sListAST as it matches the format used for static member variables. Also like
to use parenthesis.
2002-11-03 01:42:36 +00:00
Lars Kühne fde1418532 include the new commons jars in checkstyle-all.jar 2002-11-02 18:20:12 +00:00
Lars Kühne a865663e99 fixed NPE 2002-11-02 17:09:46 +00:00
Lars Kühne e70cb13b07 fixed NPE 2002-11-02 16:44:52 +00:00
Lars Kühne 642d9c5035 java.g cleanup as requested by Rick, also removed empty methods 2002-11-02 15:29:59 +00:00
Rick Giles 04eaaf55e1 patch following need braces check. 2002-11-02 12:54:09 +00:00
Rick Giles da7118ff79 patch following need braces check. updated braces tests. 2002-11-02 12:53:08 +00:00
Rick Giles 61b8d9ef88 patch following need braces check. removed verify braces. 2002-11-02 12:51:54 +00:00
Rick Giles c2b58c7459 need braces check test 2002-11-02 12:49:02 +00:00
Rick Giles 1eb8cee0fb need braces check 2002-11-02 12:48:24 +00:00
Oliver Burn 3288a81e30 Just converted over the Checkstyle ANT task to use the new framework. In
process I had to fix numerous errors now being reported.

There are some bugs with the method checks, which I will now investigate.
2002-11-02 12:22:14 +00:00
Oliver Burn 90c0f0affe removed unused import. Eclipse reported it in the task list, so I needed fix
it ;-)
2002-11-02 07:27:09 +00:00
Lars Kühne a2fded8ed7 Added getAcceptableTokens to Check.
Prevent registration for tokens the Check is not
designed for
2002-11-02 06:48:52 +00:00
Oliver Burn 2effcfd0bc Start of conversion to only supporting the new framework. Also refactored
error handling.
2002-10-31 12:28:47 +00:00
Oliver Burn cd32cd1ab0 fix checkstyle errors 2002-10-31 09:59:49 +00:00
Lars Kühne c0a8e0ff6c ported Verifier.verifyDot() to NoWhiteSpaceAroundCheck 2002-10-31 06:25:59 +00:00
Lars Kühne 67ac0b2ade DropTargetAdapter is only available in JDK 1.4, using DropTargetListener instead
as this was the only place in the source tree where 1.4 was required
2002-10-31 04:58:11 +00:00
Oliver Burn 663a1a72f4 Fixed Checkstyle errors 2002-10-30 22:28:39 +00:00
Lars Kühne 471cc3509b Ported constructor length check, patch contributed by Rick Giles 2002-10-29 20:20:14 +00:00
Oliver Burn 87c1f4ffb6 Patch from Rick Giles 2002-10-29 13:56:28 +00:00
Oliver Burn b368f9b91f Patch from Rick Giles 2002-10-29 13:50:06 +00:00
Oliver Burn 6e676cac5d Patch from Rick Giles. Also removed dead code 2002-10-29 13:44:30 +00:00
Oliver Burn cbce85c08c Patch for Rick Giles 2002-10-29 13:37:20 +00:00
Oliver Burn 96abec9ddf Patch from Rick Giles - also removed the dead code 2002-10-29 13:30:30 +00:00
Oliver Burn 50ffeeae38 Finished port of Local name check - deleted old code 2002-10-29 13:22:11 +00:00
Oliver Burn ff49be94c4 Patch from Rick Giles 2002-10-29 13:17:16 +00:00
Oliver Burn d000ac3d7b Finished port of Local Final name check - deleted old code 2002-10-29 13:00:25 +00:00
Oliver Burn 64a5413307 Patch from Rick Giles 2002-10-29 12:51:27 +00:00
Oliver Burn 7fa61f5c0b Finished porting across the Javadoc checking for types.
Cleaned up Javadoc errors.
Removed unused imports.
Minor refactoring.
2002-10-29 12:39:42 +00:00
Lars Kühne 2a8aba9a54 Avoid duplicate matching and logging code by introding an abstract name check class.
patch contributed by Rick Giles
2002-10-29 06:20:46 +00:00
Lars Kühne 59c9c64381 fixed style problems 2002-10-28 16:27:58 +00:00
Lars Kühne 675c037c85 fixed style problems 2002-10-28 16:10:21 +00:00
Lars Kühne 40496d0f8c import cleanup 2002-10-28 14:47:57 +00:00
Lars Kühne eecd476fa8 moved static AST helpers in Util to DetailAST 2002-10-28 09:31:54 +00:00
Oliver Burn 4bbe4acd31 Removed old constant name check 2002-10-27 22:52:18 +00:00
Oliver Burn e44cd4ec43 Added Constant Name Check 2002-10-27 21:58:10 +00:00
Oliver Burn 4d9e56e2b3 Start of port of javadoc check for types. 2002-10-26 08:00:35 +00:00
Oliver Burn b881f65b1a removing dead code 2002-10-26 07:01:32 +00:00
Oliver Burn 0c58241ecd removing dead code 2002-10-26 06:34:46 +00:00
Oliver Burn 8dd406793d Removed unused imports and also refactor scope utilities into a simple class. 2002-10-26 06:21:02 +00:00
Oliver Burn c8958bcd0e added bin to ignore list (Eclipse thing) 2002-10-25 21:58:39 +00:00
Lars Kühne 45e8617a5f removed DnD todo entry 2002-10-25 09:03:25 +00:00
Lars Kühne 5f19a9c5a7 fixed javadoc warning 2002-10-25 07:19:40 +00:00