Commit Graph

2811 Commits

Author SHA1 Message Date
vlad e8255c208f remove dead code from MutableExceptionCheck, #1103 2015-05-19 04:29:03 +03:00
vlad 947e230fbf 100% test coverage for FinalClassCheck, #1009 2015-05-19 03:29:55 +03:00
vlad 989745bb60 remove dead code from FinalClassCheck, #1100 2015-05-18 17:10:50 -07:00
vlad 2c99b9706e 100% test coverage for ThrowsCountCheck, #1009 2015-05-19 00:00:05 +03:00
vlad 893621b965 100% test coverage for HideUtilityClassConstructor, #1009 2015-05-18 18:06:44 +03:00
Michal Kordas cf5851ed29 Use EqualsVerifier to test CSVFilter. #1088 2015-05-18 05:56:41 -07:00
vlad e67c9bf046 100% coverage for DesignForExtensionCheck, #1009 2015-05-18 11:37:47 +03:00
vlad c5e7dea987 fix for testGetRequiredTokens() methods in the package, #1009 2015-05-18 11:37:47 +03:00
Michal Kordas 2f1b20f220 Use EqualsVerifier to test SuppressWithNearbyCommentFilter. #1088 2015-05-17 19:31:28 +02:00
Michal Kordas 0f58857d73 Change location of left curly braces to end of line. #1089 2015-05-17 13:47:09 +02:00
Michal Kordas fb9f55e890 Make tests of Main class platform independent. #1086 2015-05-16 22:22:27 -07:00
Michal Kordas 56743942d5 Extend ReturnCount Check to treat lambdas separately. #1068 2015-05-16 22:19:07 -07:00
Roman Ivanov 6cdcfc135a Findbugs violation: defines compareTo(LineColumn) and uses Object.equals(). #911 2015-05-15 23:52:15 -07:00
Roman Ivanov e6034ec381 Findbugs violation: AuditEvent.message is transient but isn't set by deserialization. #909 2015-05-15 17:04:32 -07:00
Roman Ivanov 5e0b6286ac Findbugs violation: api.TokenTypes do System.exit(...). #923 2015-05-15 15:31:59 -07:00
Roman Ivanov 0f06b92909 minor, activate link in javadoc/xdoc 2015-05-15 13:52:01 -07:00
Roman Ivanov 3e22f93479 minor, activate link in javadoc/xdoc 2015-05-15 13:46:10 -07:00
Roman Ivanov c3dc1a94f3 Findbugs violation: resolve all violations from gui package. #925 2015-05-15 13:23:17 -07:00
Roman Ivanov e1a27939ae method setClassloader was renamed to setClassLoader with deprecation of old method. #922 2015-05-15 10:59:13 -07:00
MEZk 9122a37b9c test coverage for getRequiredTokens() and getAcceptableTokens(), issue #1024 2015-05-13 14:13:32 -07:00
Ivan Sopov bf10b021a7 removing abandoned test input files 2015-05-13 23:58:18 +03:00
Michal Kordas 38be87d86c Fix exception in OneTopLevelClass Check for package-info files. #1065 2015-05-13 10:12:45 -07:00
Vladlis 42fc689da0 test coverage for getRequiredTokens() and getAcceptableTokens(), #1009 2015-05-13 10:02:02 -07:00
Michal Kordas dba746ba93 Fix PMD violations from PrematureDeclaration rule. #948 2015-05-13 09:58:12 -07:00
Michal Kordas 5ff1834a22 Fix PMD violations from AvoidFieldNameMatchingMethodName rule. #984 2015-05-13 09:54:48 -07:00
Michal Kordas 466b1ebb31 Fix SeparatorWrap Check violations in Checkstyle code. #945 2015-05-13 09:47:17 -07:00
Michal Kordas 7fdcaa5929 Fix exception in FallThrough Check for nested switch statements. #837 2015-05-13 09:26:45 -07:00
Mehmet Can Cömert 795968d20e Magic Number annotation detection enhanced for arbitary parent nodes, Issue #926 2015-05-11 12:53:51 -07:00
Roman Ivanov 1076e12e69 minor: suggested format for issue reference is changed to avoid misunderstanding 2015-05-06 13:07:06 -07:00
Roman Ivanov e3b3bfb999 Util classes should be moved out of api package. Issue #1057 2015-05-05 19:40:30 -04:00
Roman Ivanov 93e0187129 removal of validation suppressions, and resoling of them. Issue #596 2015-05-05 17:40:26 -04:00
Roman Ivanov 1a2c318e22 huge refactoring for CLI Main class. Issue #596 2015-05-05 11:12:12 -07:00
Michal Kordas a0acabc125 Fix FallThrough check violation in code, issue #945 2015-05-03 11:34:00 -07:00
Michal Kordas a2b8be14bb Fix PMD violations from SimplifyStartsWith rule, issue #949 2015-05-03 17:00:25 +02:00
Michal Kordas 0f543a21fe Fix DeclarationOrder check violations in Checkstyle code, issue #1049 2015-05-02 23:27:11 -07:00
Andrew Gaul 1df2edb7d6 Complete descriptions in checks index
Previously MissingDeprecated and MissingOverride had truncated
descriptions.
2015-05-02 14:39:40 -07:00
Michal Kordas 224d8144c2 Fix EmptyLineSeparator violations for fields, issue #1040 2015-05-02 01:32:54 +02:00
Michal Kordas b83375fc6d Fix EmptyLineSeparator violations for methods, issue #1040 2015-05-02 01:32:53 +02:00
Michal Kordas bc573aaaaf Fix EmptyLineSeparator violations for classes, issue #1040 2015-05-02 01:32:53 +02:00
Michal Kordas 31421dcdda Fix EmptyLineSeparator violations for packages, issue #1040 2015-05-02 01:32:48 +02:00
Michal Kordas 463bf8d92e Move test input files to resources, issue #1040
These files have to be moved to be excluded from Checkstyle analysis.
2015-05-02 00:49:38 +02:00
Michal Kordas f9374238b2 Fix inner class should be static FindBugs violations, issue #928
All violations of [SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS](http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS) are fixed.
2015-05-01 09:28:08 -07:00
Michal Kordas 7d5e825abd Fix PMD violations from AvoidThrowingNullPointerException, issue #960 2015-05-01 17:03:00 +02:00
Michal Kordas 193474f518 Fix PMD violations from TooFewBranchesForASwitchStatement rule, issue #998 2015-05-01 07:29:17 -07:00
Michal Kordas 4f9b3cdad8 Fix EmptyCatchBlock violations in Checkstyle codebase, issue #945 2015-05-01 15:19:10 +02:00
Roman Ivanov f24ef8374c fix for typo in documentation. Issue #1017 2015-05-01 00:18:40 -07:00
Michal Kordas c0e9bd2df7 Remove FastStack from API, issue #989 2015-04-30 17:53:29 -07:00
Michal Kordas a15e6af728 Include enums in CovariantEquals check analysis, issue #1011 2015-04-30 17:42:41 -07:00
Roman Ivanov e2ba2e95b3 minor extension for docs 2015-04-30 17:39:26 -07:00
Michal Kordas cf4f4b5357 Improve standard package regexp for CustomImportOrder check, issue #1020 2015-04-30 17:27:42 -07:00
Roman Ivanov 949f78ab60 OneTopLevelClass check example is broken and documentation missing, for 'tokens' property. Issue #1017 2015-04-30 20:08:04 -04:00
Michal Kordas 260490c05b Fix NPE in ModifiedControlVariable check, issue #1012 2015-04-30 16:30:46 -07:00
Michał Kordas aeef83ee58 Remove obsolete space from error message 2015-04-30 16:21:10 -07:00
Roman Ivanov ec83f8e883 OneTopLevelClass check example in documentation has invalid XML syntax. Issue #1016 2015-04-30 15:22:45 -07:00
Michał Kordas 3231bfbefa Add missing space in error message for CustomImportOrder check 2015-04-30 23:54:47 +02:00
Michal Kordas c0446a8255 Fix PMD violations from UseVarargs rule, issue #999
The changes are fully backward-compatible. Method with vararg can be invoked both using array and list of parameters.
2015-04-29 17:21:14 -07:00
Roman Ivanov 6a9872d60c minor fix for documentation 2015-04-28 15:12:02 -07:00
Michał Kordas db2266902f Fixes to Release Notes for Checkstyle 6.6 2015-04-27 08:23:57 +02:00
Roman Ivanov e3a57f5622 release notes 6.6 2015-04-26 15:11:19 -07:00
Michal Kordas 4208891158 Repair ignored test, issue #994 2015-04-26 13:43:14 -07:00
Roman Ivanov 0552912c9f fix for violations of PMD LogicInversion. Issue #744 2015-04-26 10:14:36 -07:00
Roman Ivanov e453e5bdb3 fixed violations for PMD rule SingularField. Issue #744 2015-04-26 09:57:28 -07:00
Roman Ivanov c1ce1f8f0c fixed violations for PMD rule UseCollectionIsEmpty. Issue #744 2015-04-26 09:49:35 -07:00
Michal Kordas 51b2114e61 Fix AnnotationLocation violation in Checkstyle codebase, issue #945 2015-04-26 09:15:13 -07:00
Michal Kordas f374e2e7a0 Fix AvoidStaticImport check violations in codebase, issue #979 2015-04-26 09:13:56 -07:00
Michal Kordas 55b266cd92 Fix AtclauseOrder check violations in codebase, issue #978 2015-04-26 02:30:41 +02:00
Michal Kordas 31db0435b7 Resolve Javadoc problems found by Checkstyle, issue #978 2015-04-26 01:42:24 +02:00
Michal Kordas 53eddca5d1 Replace all occurrences of FastStack with ArrayDeque, issue #86 2015-04-25 16:35:30 -07:00
Michal Kordas b29ca6b5f6 Fix and suppress PMD violations from ShortClassName rule, issue #982 2015-04-24 23:09:13 +02:00
Michal Kordas 4ac32a7c0c Fix PMD violations from ShortMethodName rule, issue #982 2015-04-24 21:21:29 +02:00
Michal Kordas f9a9d6c3d3 Fix PMD violations from BooleanGetMethodName rule, issue #982 2015-04-24 21:19:14 +02:00
Michal Kordas 5cd16d56a2 Fix PMD violations - AvoidFieldNameMatchingTypeName rule, issue #982 2015-04-24 21:12:15 +02:00
Roman Ivanov 589c5a261a added validation for header in setHeader in RegexpHeaderCheck.java to provide better feedback when an invalid Pattern is specified (was InvocationTargetException only before). Changes are made base on @krichter722 commit. Issue #897 2015-04-24 09:10:26 -07:00
Damian Szczepanik ab2f93f9bf Delete System.exit() and delegate exit control into separate method.
Issue #596
2015-04-23 22:18:45 -07:00
Roman Ivanov 3d3f3d5f9c PMD rule AbstractClassWithoutAbstractMethod is activated. Issue #744 2015-04-23 19:51:10 -04:00
Roman Ivanov 18ed7958cf PMD rule AvoidSynchronizedAtMethodLevel is activated. Issue #744 2015-04-23 19:34:59 -04:00
Roman Ivanov e30fa27dc4 PMD Rule:AccessorClassGeneration Priority:3 Avoid instantiation through private constructors from outside of the constructors class. Issue #744 2015-04-23 18:52:43 -04:00
Roman Ivanov 8bd1d6869b PMD rule AvoidDeeplyNestedIfStmts is activated. Issue #744 2015-04-23 18:09:00 -04:00
Roman Ivanov 232246fb93 PMD Rule:SwitchStmtsShouldHaveDefault Priority:3 Switch statements should have a default label. Issue #744 2015-04-23 16:48:10 -04:00
Michal Kordas 9399831eea Extend LeftCurly check to verify static initializers, issue #966 2015-04-23 13:11:19 -07:00
Mehmet Can Cömert 335d28b494 issue969: Fix upper/lower case conversation, enhance tests 2015-04-23 12:43:24 -07:00
Michal Kordas 9ea33d0720 Extend EmptyBlock check to verify synchronized blocks, issue #964 2015-04-23 21:24:55 +02:00
Roman Ivanov dd6b080a16 all TODO/FIXME were removed , some of them converted to issues 2015-04-23 13:38:31 -04:00
Roman Ivanov bc9eae330a PMD Rule:OneDeclarationPerLine Priority:4 Use one line for each declaration, it enhances code readability. Issue #744 2015-04-22 17:05:31 -04:00
Roman Ivanov a733182557 PMD Rule:AssignmentInOperand Priority:3 Avoid assignments in operands. Issue #744 2015-04-22 16:37:37 -04:00
Roman Ivanov 9b5594952d Rule:UnnecessaryConstructor Priority:3 Avoid unnecessary constructors - the compiler will generate these for you. Issue #744 2015-04-22 12:38:46 -07:00
Roman Ivanov ece98b65cb Rule:CommentRequired Priority:3 XXXXXXXXXXCommentRequirement Required. Issue #744 2015-04-21 16:48:57 -04:00
Roman Ivanov 3b0a914b39 Rule:CommentRequired Priority:3 headerCommentRequirement Required. Issue #744 2015-04-21 13:42:05 -07:00
Roman Ivanov cbb51d7852 Rule:CommentRequired Priority:3 XXXXXXXXXXCommentRequirement Required. Issue #744 2015-04-21 13:33:45 -07:00
Roman Ivanov c9cf116fcb PMD Rule:ExcessiveMethodLength Priority:3 Avoid really long methods. Issue #744 2015-04-21 10:48:28 -07:00
Roman Ivanov 7f65ac9c09 PMD Rule:ExcessiveMethodLength Priority:3 Avoid really long methods . Issue #744 2015-04-21 09:52:03 -07:00
Michal Kordas 3ab0516997 Fix PMD violations from RedundantFieldInitializer rule, issue #942 2015-04-20 14:30:34 -07:00
Michal Kordas ba4f230c35 Fix generics with arrays handling in NoWhitespaceAfter, issue #931 2015-04-18 23:38:54 -07:00
liscju ffde404dba Introduce new handler SynchronizedHandler for checking identation. Fixes Issue #580 2015-04-16 11:34:11 -07:00
Michal Kordas 8dbfd35435 Fix PMD violations from 'sunsecure' ruleset, issue #874 2015-04-16 07:07:41 -07:00
Michal Kordas b798438ecd Add test for non existing cache file, issue #921 2015-04-15 11:02:39 -07:00
Michal Kordas 1c42e3eeb9 Fix PMD violations from 'strings' ruleset, issue #873 2015-04-15 17:56:07 +02:00
Roman Ivanov 22a5c6af71 fix for findbugs violation SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS. Issue #912 2015-04-13 17:09:12 -07:00
Roman Ivanov d4578980b0 fix for findbugs violation JavadocNodeImpl to not return null for array type. Issue #912 2015-04-13 16:40:24 -07:00
Roman Ivanov 4ffb4d7f1b fix for findbugs violation RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE. Issue #912 2015-04-13 16:40:19 -07:00