Commit Graph

1435 Commits

Author SHA1 Message Date
Rick Giles d0fbb100b6 added check for FinderException throws clause to ejbSelect check 2003-06-30 23:49:37 +00:00
Rick Giles 772107d27c correct checkstyle errors 2003-06-30 23:48:29 +00:00
Rick Giles 9f4164a450 Added ejbPostCreate, ejbHome, ejbSelect checks for entity beans.
Uniform error messages.
2003-06-30 23:38:36 +00:00
Rick Giles 24a774b1e8 correct checkstyle errors 2003-06-30 20:44:17 +00:00
Rick Giles 1bca9cc443 every Home interface must have findByPrimaryKey method 2003-06-30 20:40:13 +00:00
Rick Giles 7a2c495da7 added interface checks 2003-06-30 19:15:39 +00:00
Rick Giles cc857f0940 EntityBean finder checks. 2003-06-30 13:26:14 +00:00
Rick Giles 304ca8487a Refactor. Extend ejbCreate checks 2003-06-30 11:51:29 +00:00
Rick Giles 3c4a10ca03 J2EE checks 2003-06-29 20:54:38 +00:00
Oleg Sukhodolsky 50c242141a indent.severity removed, translation.severity added to checkstyle.style target 2003-06-29 12:56:51 +00:00
Lars Kühne 2617fa0175 added tests for StringLiteralEqualityCheck 2003-06-29 10:43:34 +00:00
Lars Kühne d1b597e289 added tests for StringLiteralEquality 2003-06-29 10:41:47 +00:00
Oleg Sukhodolsky 8de6dda16b Fix javadoc problem. 2003-06-29 10:04:52 +00:00
Oleg Sukhodolsky a30cd217f3 Implementation for NestedIfDepthCheck and NestedTryDepthCheck.
Thanks Simon.
2003-06-28 20:02:25 +00:00
Oliver Burn 784842200f Refactored, that was really ugly code I had written. 2003-06-27 12:10:58 +00:00
Oliver Burn 768256c32a I am sick of Spam! :-( 2003-06-27 11:04:38 +00:00
Rick Giles 5be2f0b799 corrected checkstyle error 2003-06-27 10:22:32 +00:00
Rick Giles d91d824ac7 guard against null 2003-06-27 10:19:43 +00:00
Rick Giles a03dc8c1c9 simplified algorithm 2003-06-27 09:58:28 +00:00
Lars Kühne cc822a77b4 fixed typo (security vs severity) 2003-06-27 04:25:12 +00:00
Rick Giles 9eb27f99a3 re-ordered tests for efficiency 2003-06-26 17:51:11 +00:00
Rick Giles e03dd7a0a0 handle anonymous classes with CovariantEqualsCheck 2003-06-26 17:25:02 +00:00
Rick Giles 9309a78471 defined CovariantEqualsCheck method getRequiredTokens to prevent
mis-configuration
2003-06-26 16:30:21 +00:00
Rick Giles 71d92d649f check that a class that defines a covariant equals method also overrides
equals(java.lang.Object)
2003-06-26 16:19:46 +00:00
Lars Kühne b19b59296f added docs for StringLiteralEquality 2003-06-26 04:43:28 +00:00
Oliver Burn 9a702cf864 CSortedVS: ---------------------------------------------------------------------- 2003-06-25 12:48:39 +00:00
Lars Kühne 1546ad654f implementation for rfe #754835, detect string equality checking with ==
still have to do tests and docs
2003-06-24 19:40:45 +00:00
Oliver Burn 3a75454e8d Added CyclomaticComplexityCheck from Simon Harris.
Refactored quite a bit
2003-06-24 12:35:40 +00:00
Rick Giles 3da302031b restrict field and method reference recording to configured reference check scopes 2003-06-24 10:06:32 +00:00
Oliver Burn ed7fc0e632 Fix Checkstyle errors 2003-06-24 00:53:00 +00:00
Rick Giles db428ff350 added scope property to BCEL reference checks 2003-06-23 21:55:07 +00:00
Lars Kühne 731b581a1c Added excludes property to AvoidStarImport, request 744955
contributed by Bill Schneider
2003-06-23 21:11:23 +00:00
Oliver Burn 32f5f97181 Major refactoring to remove duplicate code detected
by Simian. Just demonstrates the power of the tools for
find code that needs refactoring.

I can hardly wait to use Simian on my current project.
<evil_grin/>
2003-06-23 13:31:20 +00:00
Oliver Burn 7bd1126a3b Code cleanup - removed the stupid AbstractImportCheck.
It served no purpose but to add to our huge inheritance
hierarchy.

I was suprised how deep our hierarchy actually is. Is this
the sign of to much abstraction. I wonder?
2003-06-23 12:09:08 +00:00
Oliver Burn cf089fe1a1 Fix the Checkstyle errors created by Spud's patch. 2003-06-23 11:36:07 +00:00
Rick Giles c12d4a848c remove singleton pattern for tree walker 2003-06-22 14:32:14 +00:00
Lars Kühne e7898bc1df fixed javadoc 2003-06-22 13:17:10 +00:00
Oliver Burn e03dab4d1f Patch from Matt Quail to stop the ugly hack of having hard
coded constants in TokenTypes. The big risk was that when
the grammar changed, the generated constants could
change. (patch 757846)
2003-06-21 12:34:01 +00:00
Oleg Sukhodolsky f4a85d495c Fix for bug#755744 2003-06-20 08:51:47 +00:00
Rick Giles 54f09ae36c BCEL .class file checks 2003-06-19 23:51:44 +00:00
Oliver Burn db5ec5f654 Nice patch from Matt Quail to DetailAST to replace all the repeated int[] array construction with a BitSet. 2003-06-19 13:20:33 +00:00
Rick Giles e7778ef9e2 Removed unread private field. 2003-06-16 13:12:25 +00:00
Oliver Burn 9920857810 Refactored the Coding checks 2003-06-15 12:39:40 +00:00
Oleg Sukhodolsky e464c231ec Indentation:
Fixes for several TODO comments.
Added AssignHandler.
2003-06-14 17:47:41 +00:00
Oleg Sukhodolsky 41758923b8 Fix for [ 694111 ] Syntax error crashes Checkstyle. Update for release notes missed from previous putback 2003-06-14 17:07:26 +00:00
Rick Giles ca5c92f2e7 Added ignoreFormat property to HiddenFieldCheck (request 748830). 2003-06-12 17:30:23 +00:00
Rick Giles 78faabd14f Removed equals + hashcode. sorry for the trouble. 2003-06-10 22:07:14 +00:00
Oleg Sukhodolsky 494d1835fb Fix for [ 694111 ] Syntax error crashes Checkstyle. 2003-06-10 21:08:13 +00:00
Oleg Sukhodolsky 88f6d6ffe7 Fixed hashCode() and equals() problems which cause DetailASTTest
and EqualsHashCodeCheckTest unit-tests failures.

But I wonder if we realy need hashCode() and equals() for DetailAST,
since it's a mutable.
2003-06-10 21:04:28 +00:00
Rick Giles c37cc9e521 added equals + hashCode 2003-06-10 14:50:07 +00:00