Commit Graph

3769 Commits

Author SHA1 Message Date
Roman Ivanov e5dd96d8dc Issue #2089: fix for checkstyle violations 2015-09-14 06:40:08 -07:00
Roman Ivanov a42475db9e Issue #2089: Allow COMMA again in NoWhiteSpaceBefore 2015-09-14 06:39:08 -07:00
Roman Ivanov 0bff657f61 Issue #2129: logging as WARN for misconfigurated Check is changed to Exception, we should fail fast. 2015-09-13 18:19:24 -07:00
Michal Kordas 0fc8b62a35 Issue #2080: Fix typos in code 2015-09-11 16:32:42 -07:00
Michal Kordas daae0431d1 Issue #2161: Unify naming files with test inputs 2015-09-11 22:48:59 +02:00
Andrei Selkin dba6c944cd Issue #382: Fix HiddenField false positive violations for anonymous classes 2015-09-11 13:14:33 -04:00
Andrei Selkin bd9efb5e66 Issue #759: Create wide message for CheckstyleException in PackageObjectFactory 2015-09-11 18:04:45 +03:00
Roman Ivanov d58e2892c3 doc: improvement of formatting 2015-09-11 07:17:26 -07:00
Ilja Dubinin 526c9d0cba Issue #46: blocks of code should not be duplicated 2015-09-10 17:25:58 -07:00
Michal Kordas c1ce291701 Issue #2130: Fix "deprecation" compiler warnings in input files 2015-09-10 17:12:35 -07:00
Michal Kordas 9e5803a8ec Issue #2130: Fix "rawtypes" compiler warnings in input files 2015-09-10 21:11:44 +02:00
Andrei Selkin a29f01a95b Issue #67: Added support of logging severity for all audit events 2015-09-10 12:57:54 +03:00
Michal Kordas 4687b0b801 Issue #2130: Fix unchecked compiler warnings in input files 2015-09-09 15:58:56 -07:00
Andrei Selkin af9ed7386d Issue #606: Reorganized sections in eclipse.xml 2015-09-09 11:29:20 -07:00
Andrei Selkin e52892ba62 Issue #606: Extended Eclipse user guide for newbies of Checkstyle 2015-09-09 11:29:20 -07:00
Ilja Dubinin b9cad4d385 doc: examles order for DescedantTokenCheck has been changed. 2015-09-09 01:56:54 +01:00
Michal Kordas c0d3652d1b Issue #2135: Fix exception at NeedBraces check in enhanced for loops 2015-09-08 22:23:23 +02:00
Phillip Webb f7698ed23b Issue #2141: Allow @return tags from annotation types 2015-09-07 22:37:23 -07:00
Roman Ivanov 66b07f10af Issue #46: suppression was added to false-positive that IntelijIdea found in previous commit 2015-09-07 18:35:06 -07:00
Ilja Dubinin 33ab409c4e Issue #46: loops should not have more then one break or continue statement 2015-09-08 01:02:50 +01:00
Michal Kordas 4ae3c95822 Issue #2137: Make test for FileTabCharacter locale and OS independent 2015-09-07 22:57:18 +02:00
Roman Ivanov 78103da033 Issue #2080: name violations are fixed, checkstyle suppressions were updated to validate names in tests too 2015-09-06 17:23:55 -07:00
Roman Ivanov dc90dd2845 inspection suppression was moved to javadoc 2015-09-06 15:54:01 -07:00
Roman Ivanov 9ef8a38684 Revert "Issue #2065: additional attempt to resolve violation on TeamCity, DeclareCollectionAsInterface is disabled"
This reverts commit 18d5fd7eeb.
2015-09-06 15:37:09 -07:00
Roman Ivanov a36ac91b27 Revert "Issue #2065: additional attempt to resolve violation on TeamCity"
This reverts commit 652848ae06.
2015-09-06 15:36:39 -07:00
Michal Kordas 20b73ed383 Issue #2131: Add inspection scope profile for IDEA analysis 2015-09-06 22:55:23 +02:00
Michal Kordas ccf2d8315c Issue #1555: Remove usage of obsolete junit.framework.Assert class 2015-09-06 20:15:51 +02:00
Roman Ivanov 18d5fd7eeb Issue #2065: additional attempt to resolve violation on TeamCity, DeclareCollectionAsInterface is disabled 2015-09-06 06:34:07 -07:00
Roman Ivanov 652848ae06 Issue #2065: additional attempt to resolve violation on TeamCity 2015-09-06 06:11:24 -07:00
liscju cd10c41ca5 Issue #937: added tests for validating commit message. 2015-09-06 05:32:26 -07:00
Michal Kordas 4d8d047f46 Issue #2080: Fix typos in code
Fixes some `SpellCheckingInspection` inspection violations.

Description:
>Spellchecker inspection helps locate typos and misspelling in your code, comments and literals.
2015-09-06 14:17:36 +02:00
Roman Ivanov 5dffb5a301 Revert "minor: Intelij violation(Redundant suppression) is resolved"
This reverts commit 7e6084f236.
2015-09-05 17:26:51 -07:00
Roman Ivanov 7e6084f236 minor: Intelij violation(Redundant suppression) is resolved 2015-09-05 16:33:55 -07:00
Vladislav Lisetskiy 6f1406f980 Issue #2094: fix StringIndexOutOfBoundsException 2015-09-05 15:24:14 -07:00
Michal Kordas be7f7ed37b Issue #2065: Remove additional context from IDEA suppression
While suppression works fine, it causes false positive in `RedundantSuppression` inspection reported as [IDEA-144818](https://youtrack.jetbrains.com/issue/IDEA-144818).

Tag `@noinspection` is self-descriptive enough on its own.
2015-09-05 15:18:01 -07:00
Michal Kordas d105a27046 Issue #1555: Tune down inspection for overridden parameter names
ParameterNameDiffersFromOverriddenParameter does not require parameters to match names anymore if method is from external library and parameter may be wrongly named there.
2015-09-05 23:07:11 +02:00
Andrei Selkin 0e8002b728 Issue #2092: Corrected xdoc for TranslationCheck. 2015-09-05 20:57:04 +03:00
Andrei Selkin 984fd1cb8f Issue #2092: Activated TranslationCheck in checkstyle_checks.xml. 2015-09-05 16:01:48 +03:00
Michal Kordas d220d7c3cc Issue #2080: Fix typos in code
Fixes some `SpellCheckingInspection` inspection violations.

Description:
>Spellchecker inspection helps locate typos and misspelling in your code, comments and literals.
2015-09-04 20:28:43 -04:00
Michal Kordas 31f6765fdc Issue #2080: Fix typos in code
Fixes some `SpellCheckingInspection` inspection violations.

Description:
>Spellchecker inspection helps locate typos and misspelling in your code, comments and literals.
2015-09-04 14:48:17 -07:00
Michal Kordas 6839ac4fd8 Issue #2080: Add missing assertions to utils tests
Fixes some `TestMethodWithoutAssertion` inspection violations.

Description:
>Reports test methods of JUnit test case classes that do not contain any assertions. Such methods indicate either incomplete or weak test cases.
2015-09-04 14:47:31 -07:00
Vladislav Lisetskiy 45e3ec229d Issue #1214: Update all Checks html docs with link to hosted
configurations
2015-09-04 05:38:52 -07:00
Andrei Selkin 9acda0b233 Issue #1833: Fixed redundant modifier false positive for abstract classes in interfaces. 2015-09-04 05:32:51 -07:00
Ilja Dubinin 0b4ae9160b Issue #46: loops should not contain more then one break. 2015-09-03 21:24:05 -04:00
Michal Kordas f7e41edb94 Issue #2080: Replace ternary condition operator with if
Fixes `ConditionalExpression` inspection violations.

Description:
>Reports the ternary condition operator. Some coding standards prohibit the use of the condition operator, in favor of if-else statements.
2015-09-03 18:07:24 -07:00
Michal Kordas 2b4a02d2c8 Issue #2080: Fix typos in code
Fixes `SpellCheckingInspection` inspection violations introduced in recent commits.

Description:
>Spellchecker inspection helps locate typos and misspelling in your code, comments and literals.
2015-09-03 18:06:15 -07:00
Michal Kordas b115e9afe5 Issue #2080: Replace tabs with spaces
Fixes `ProblematicWhitespace` inspection violations introduced in recent commits.

Description:
>Reports tabs used for indentation when the code style is configured to use only spaces.
2015-09-03 18:04:08 -07:00
Michal Kordas 92182aea44 Issue #1555: Rename local variables according to convention
Fixes `LocalVariableNamingConvention` inspection violations introduced in recent commits.

Description:
>Reports local variables whose names are either too short, too long, or do not follow the specified regular expression pattern.
2015-09-03 18:02:23 -07:00
Michal Kordas 1e0de782f6 Issue #1555: Use constants for empty arrays
Fixes `ZeroLengthArrayInitialization` inspection violations introduced in recent commits.

Description:
>Reports on allocations of arrays with known lengths of zero. Since array lengths in Java are non-modifiable, it is almost always possible to share zero-length arrays, rather than repeatedly allocating new zero-length arrays. Such sharing may provide useful optimizations in program runtime or footprint. Note that this inspection does not report zero-length arrays allocated as static final fields, as it is assumed that those arrays are being used to implement array sharing.
2015-09-03 18:02:23 -07:00
Michal Kordas 8cf5116925 Issue #1555: Simplify JUnit assertions
Fixes `SimplifiableJUnitAssertion` inspection violations introduced in recent commits.

Description:
>Reports any JUnit assertTrue calls which can be replaced by equivalent assertEquals calls. assertEquals calls will normally give better error messages in case of test failure than assertTrue can.
2015-09-03 18:02:23 -07:00