Commit Graph

4860 Commits

Author SHA1 Message Date
Roman Ivanov f2dacddde9 minor: update for --ff-only and fail-fast 2015-09-03 21:30:38 -04:00
Ilja Dubinin 0b4ae9160b Issue #46: loops should not contain more then one break. 2015-09-03 21:24:05 -04:00
Michal Kordas f7e41edb94 Issue #2080: Replace ternary condition operator with if
Fixes `ConditionalExpression` inspection violations.

Description:
>Reports the ternary condition operator. Some coding standards prohibit the use of the condition operator, in favor of if-else statements.
2015-09-03 18:07:24 -07:00
Michal Kordas 2b4a02d2c8 Issue #2080: Fix typos in code
Fixes `SpellCheckingInspection` inspection violations introduced in recent commits.

Description:
>Spellchecker inspection helps locate typos and misspelling in your code, comments and literals.
2015-09-03 18:06:15 -07:00
Michal Kordas de39a36a6b Issue #2080: Enable AbstractClassNamingConvention inspection 2015-09-03 18:05:00 -07:00
Michal Kordas b115e9afe5 Issue #2080: Replace tabs with spaces
Fixes `ProblematicWhitespace` inspection violations introduced in recent commits.

Description:
>Reports tabs used for indentation when the code style is configured to use only spaces.
2015-09-03 18:04:08 -07:00
Michal Kordas 92182aea44 Issue #1555: Rename local variables according to convention
Fixes `LocalVariableNamingConvention` inspection violations introduced in recent commits.

Description:
>Reports local variables whose names are either too short, too long, or do not follow the specified regular expression pattern.
2015-09-03 18:02:23 -07:00
Michal Kordas 1e0de782f6 Issue #1555: Use constants for empty arrays
Fixes `ZeroLengthArrayInitialization` inspection violations introduced in recent commits.

Description:
>Reports on allocations of arrays with known lengths of zero. Since array lengths in Java are non-modifiable, it is almost always possible to share zero-length arrays, rather than repeatedly allocating new zero-length arrays. Such sharing may provide useful optimizations in program runtime or footprint. Note that this inspection does not report zero-length arrays allocated as static final fields, as it is assumed that those arrays are being used to implement array sharing.
2015-09-03 18:02:23 -07:00
Michal Kordas 8cf5116925 Issue #1555: Simplify JUnit assertions
Fixes `SimplifiableJUnitAssertion` inspection violations introduced in recent commits.

Description:
>Reports any JUnit assertTrue calls which can be replaced by equivalent assertEquals calls. assertEquals calls will normally give better error messages in case of test failure than assertTrue can.
2015-09-03 18:02:23 -07:00
Michal Kordas ea891b1fd0 Issue #1555: Use proper order in assertEquals assertions
Fixes `MisorderedAssertEqualsParameters` inspection violations introduced in recent commits.

Description:
>Reports any calls to JUnit assertEquals() which have a non-literal as the expected result argument and a literal as the actual result argument. Such calls will behave fine for assertions which pass, but may give confusing error reports if their expected and actual arguments differ.
2015-09-03 18:02:23 -07:00
Michal Kordas ee7d6e9df3 Issue #1555: Add locale to lower case conversion
Fixes `StringToUpperWithoutLocale` inspection violations introduced in recent commits.

Description:
>Reports any call of toUpperCase() or toLowerCase() on String objects which do not specify a java.util.Locale. Such calls are usually incorrect in an internationalized environment.
2015-09-03 18:02:23 -07:00
Michal Kordas 9ce956473b Issue #1555: Add argument to exception constructor call
Fixes `NewExceptionWithoutArguments` inspection violations introduced in recent commits.

Description:
>Reports exception instance creation without any arguments specified. When an exception is constructed without arguments it contains no information about the fault that happened, which makes debugging needlessly hard.
2015-09-03 18:02:23 -07:00
Michal Kordas dd7935491a Issue #1555: Narrow scope of variable
Fixes `TooBroadScope` inspection violations introduced in recent commits.

Description:
>Reports any variable declarations of which the scope can be narrowed. Especially useful for "Pascal style" declarations at the start of a method, but variables with too broad a scope are also often left over after refactorings.
2015-09-03 18:02:23 -07:00
Michal Kordas 2085758156 Issue #1555: Replace qualifier with an import
Fixes `UnnecessaryFullyQualifiedName` inspection violations introduced in recent commits.

Description:
>Reports on fully qualified class names which can be shortened. The quick fix for this inspection will shorten the fully qualified names, adding import statements as necessary.
2015-09-03 18:02:23 -07:00
Ilja Dubinin 47b8d42145 Issue #1290: AbstractOptionCheck has been removed from list of checks to cover 2015-09-03 22:44:07 +01:00
Michal Kordas a3daead123 Issue #2065: Add suppression for IntelliJ IDEA inspection as comment 2015-09-03 21:47:35 +02:00
Vladislav Lisetskiy 6389959930 Issue #2064: ignore classes nested in interaces or annotations in Final
Class Check
2015-09-03 11:11:56 -07:00
Vladislav Lisetskiy c569113723 Issue #2063: Create separate web page for old release notes 2015-09-03 13:52:12 -04:00
Vladislav Lisetskiy f66dcdbd94 Issue #1530: Detect nested enums marked as static in RedundantModifier
check
2015-09-03 06:45:44 -07:00
Andrei Selkin 860e442d53 Issue #1900: Extended javadoc/xdoc for RightCurlyCheck. 2015-09-03 06:34:06 -07:00
Andrei Selkin 8f5c67b836 Issue #1900: Extended violation message for right curly brace policy 'same'. 2015-09-03 06:34:06 -07:00
Andrei Selkin 0689f76ab3 Issue #1903: Fixed NPE in MutableExceptionCheck.isExtendedClassNamedAsException . 2015-09-03 06:17:12 -07:00
Andrei Selkin 0b23dba45a Issue #945: Added UT which validates that all checks which exist in classpath are referenced in checkstyle_checks.xml. 2015-09-03 06:11:18 -07:00
Andrei Selkin ab4bce61c5 Issue #945: Added 'IllegalCatch' into checkstyle_checks.xml. 2015-09-03 06:11:18 -07:00
Vladislav Lisetskiy 1455655c75 Issue #2074: Correct SummuryJavadoc IT 2015-09-03 06:05:15 -07:00
Vladislav Lisetskiy 54c907e6ae Issue #2062: Change message in SummaryJavadocCheck 2015-09-03 06:04:13 -07:00
Michal Kordas 137caa82cb Issue #2065: Add suppression for IntelliJ IDEA inspection
Inspection in this case is right. Parameter `Properties` can be replaced with `Map<Object, Object>`. It works fine with Checkstyle, but it breaks binary compatiblity with Maven Checkstyle Plugin, which is not acceptable.
2015-09-03 05:55:42 -07:00
Andrei Selkin 0b6d22e69b Issue #2029: New option 'switchBlockAsSingleDecisionPoint' for CyclomaticComplexityCheck. 2015-09-03 05:51:41 -07:00
Ilja Dubinin 4ea84c811b Issue #1290: Coverage has been increased to 100% in AbstractTypeAwareCheck and nested classes 2015-09-03 05:39:43 -07:00
Ilja Dubinin c6c9ad9d33 Issue #1290: coverage has been increased to 100% in TranslationCheck 2015-09-03 05:34:28 -07:00
Ilja Dubinin 2c6e941a26 Issue #1290: Coverage has been increased to 100% in NewLineAtTheEndOfFileCheck 2015-09-03 01:00:31 +01:00
Roman Ivanov b3abeac94c config: changes in team members 2015-09-02 12:55:09 -07:00
Roman Ivanov 56489da86b config: timeout for linkcheck plugin was extended to allow avoid error for github issue page that have too much content, so loading slow 2015-09-02 09:37:34 -04:00
Michal Kordas 14db0ec7e9 Tidy up in release notes 2015-09-02 09:38:01 +02:00
Andrei Selkin ed280ebd0b Minor: refactoring of TreeWalker to increase readability 2015-09-01 21:51:26 -07:00
Andrei Selkin 6f7dfc3c69 Corrected javadoc/xdoc for IllegalTypeCheck 2015-09-01 21:50:33 -07:00
Ilja Dubinin 8607274a92 Issue #46: Loops should not contain more than a single 'break' or 'continue' statement 2015-09-01 21:47:52 -07:00
Ilja Dubinin 6e775898e7 Issue #46: Statements shouldn't be nested too deep. 2015-09-01 20:01:26 +01:00
Roman Ivanov 9183d6c240 update to 6.11-SNAPSHOT 2015-09-01 09:31:22 -07:00
Roman Ivanov 355b0dc121 [maven-release-plugin] prepare for next development iteration 2015-09-01 09:05:43 -07:00
Roman Ivanov 6ef45a76dd [maven-release-plugin] prepare release checkstyle-6.10.1 2015-09-01 09:05:41 -07:00
Roman Ivanov 340b36d952 update to 6.10.1-SNAPSHOT 2015-09-01 08:53:32 -07:00
Roman Ivanov ac4b253d1d release notes 6.10.1 2015-09-01 08:52:16 -07:00
Roman Ivanov 0eaa4aff52 config: update for linkcheck to suppress lnk and raise timeout for github pages that open too long but valid 2015-09-01 08:50:27 -07:00
Roman Ivanov af95472a09 Issue #2065: broken compatibility with maven-checkstyle-plugin:2.15 at checkstyle:6.10 2015-09-01 07:24:43 -07:00
Roman Ivanov 72daf5df87 version bump 2015-08-31 23:43:37 -07:00
Roman Ivanov ef8b078396 [maven-release-plugin] prepare for next development iteration 2015-08-31 23:18:21 -07:00
Roman Ivanov f72624c920 [maven-release-plugin] prepare release checkstyle-6.10 2015-08-31 23:18:19 -07:00
Roman Ivanov c1e40c92a0 release notes 6.10 2015-08-31 23:12:04 -07:00
Roman Ivanov 092dd6864f minor: fix for incorrect link 2015-08-31 23:11:25 -07:00